Skip to content

Update update-ray-job.kueue-toy-sample.yaml #3782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

Update update-ray-job.kueue-toy-sample.yaml #3782

merged 1 commit into from
Jun 16, 2025

Conversation

troychiu
Copy link
Contributor

@troychiu troychiu commented Jun 15, 2025 •
edited
Loading

Why are these changes needed?

The entrypoint is using a weird one-liner which is not readable.

Screenshots

Screenshot 2025-06-16 at 2 52 13 PM

Related issue number

N/A

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@troychiu
make the entrypoint readable
e1e7a61 
Signed-off-by: Troy Chiu <y.troychiu@gmail.com>
@troychiu troychiu changed the title make the entrypoint readable Update update-ray-job.kueue-toy-sample.yaml Jun 15, 2025
@troychiu
Copy link
Contributor Author

@MortalHappiness PTAL. Thank you!

@MortalHappiness
Copy link
Member

Could you paste a screenshot showing that it can be successfully run? Thanks.

@troychiu
Copy link
Contributor Author

Added. Thank you!

@kevin85421 kevin85421 merged commit e6b2920 into ray-project:master Jun 16, 2025
25 checks passed
MortalHappiness pushed a commit to MortalHappiness/kuberay that referenced this pull request Jun 17, 2025
@troychiu @MortalHappiness
Update update-ray-job.kueue-toy-sample.yaml (ray-project#3782)
a3255e7 
Signed-off-by: Troy Chiu <y.troychiu@gmail.com>
MortalHappiness added a commit that referenced this pull request Jun 17, 2025
@MortalHappiness @troychiu
Update update-ray-job.kueue-toy-sample.yaml (#3782) (#3788)
bd8930e 
Signed-off-by: Troy Chiu <y.troychiu@gmail.com>
Co-authored-by: Troy Chiu <114708546+troychiu@users.noreply.github.com>
chipspeak pushed a commit to chipspeak/kuberay that referenced this pull request Jul 2, 2025
@troychiu @chipspeak
Update update-ray-job.kueue-toy-sample.yaml (ray-project#3782)
c1df181 
Signed-off-by: Troy Chiu <y.troychiu@gmail.com>
kryanbeane pushed a commit to kryanbeane/kuberay that referenced this pull request Jul 2, 2025
@troychiu @kryanbeane
Update update-ray-job.kueue-toy-sample.yaml (ray-project#3782)
dac9af2 
Signed-off-by: Troy Chiu <y.troychiu@gmail.com>
DW-Han pushed a commit to DW-Han/kuberay that referenced this pull request Jul 30, 2025
@troychiu @DW-Han
Update update-ray-job.kueue-toy-sample.yaml (ray-project#3782)
c15a6da 
Signed-off-by: Troy Chiu <y.troychiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin85421 kevin85421 kevin85421 approved these changes

Assignees

@kevin85421 kevin85421

@MortalHappiness MortalHappiness

Labels
1.4.0 release-blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@troychiu @MortalHappiness @kevin85421