Skip to content

chore: run yamlft pre-commit hook #3729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025
Merged

Conversation

davidxia
Copy link
Contributor

@davidxia davidxia commented Jun 2, 2025

only on ray-operator/config/samples dir to keep YAML formatting consistent.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

only on `ray-operator/config/samples` dir to keep YAML formatting consistent.

Signed-off-by: David Xia <david@davidxia.com>
@@ -0,0 +1,3 @@
formatter:
indentless_arrays: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo uses a mix of both. Both false and true here result in large diffs so I picked one. I like indentless because it results in shorter lines especially when the arrays are nested.

@davidxia davidxia marked this pull request as ready for review June 2, 2025 15:57
@davidxia
Copy link
Contributor Author

davidxia commented Jun 2, 2025

The non-whitespace diff is small.
image

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any manual changes for YAMLs under config/samples or all of them are from the linter?

@davidxia
Copy link
Contributor Author

davidxia commented Jun 2, 2025

Are there any manual changes for YAMLs under config/samples or all of them are from the linter?

all linter

@kevin85421 kevin85421 merged commit adcea8e into ray-project:master Jun 2, 2025
25 checks passed
@davidxia davidxia deleted the patch301 branch June 3, 2025 00:38
pawelpaszki pushed a commit to opendatahub-io/kuberay that referenced this pull request Jun 10, 2025
only on `ray-operator/config/samples` dir to keep YAML formatting consistent.

Signed-off-by: David Xia <david@davidxia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants