Skip to content

Conversation

davidxia
Copy link
Contributor

@davidxia davidxia commented Jun 1, 2025

follow-up to #3547

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

follow-up to ray-project#3547

Signed-off-by: David Xia <david@davidxia.com>
from 1G. Otherwise, tests like TestCreateJobSubmission fail because the head
Contiainer is OOMKilled. Seems like the newer Ray 2.46.0 uses more memory in
the head.

Signed-off-by: David Xia <david@davidxia.com>
@davidxia davidxia marked this pull request as ready for review June 2, 2025 21:24
@davidxia
Copy link
Contributor Author

davidxia commented Jun 2, 2025

all checks have passed, ready for review.

I wonder if some of the e2e tests (like for apiserver and ray-operator, see second commit) have gotten flakier as a result? I don't have a sense of how often these e2e tests flake in master branch. Is there a flaky test tracker with historical data?

@kevin85421 kevin85421 requested a review from Copilot June 3, 2025 00:12
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the Ray version references across multiple configuration and test files to version 2.46.0, ensuring consistency throughout the project.

  • Updated Docker image tags and Ray version strings in benchmark, API server, and e2e test configurations.
  • Aligned the version across both YAML configurations and Makefile variables.

Reviewed Changes

Copilot reviewed 49 out of 49 changed files in this pull request and generated no comments.

Show a summary per file
File Description
benchmark/perf-tests/1000-rayjob/config.yaml Updated image tag to ray:2.46.0.
benchmark/perf-tests/1000-raycluster/raycluster.yaml Updated rayVersion to 2.46.0.
benchmark/perf-tests/1000-raycluster/config.yaml Updated image tag to ray:2.46.0.
benchmark/perf-tests/100-rayjob/ray-data-image-resize.yaml Updated rayVersion to 2.46.0.
benchmark/perf-tests/100-rayjob/pytorch-mnist-rayjob.yaml Updated rayVersion to 2.46.0.
benchmark/perf-tests/100-rayjob/config.yaml Updated image tag to ray:2.46.0.
benchmark/perf-tests/100-raycluster/raycluster.yaml Updated image tags to ray:2.46.0.
benchmark/memory_benchmark/scripts/ray-cluster.benchmark.yaml.template Updated rayVersion and image tag to 2.46.0.
apiserver/test/service/serviceV2 Updated image tag to ray:2.46.0-py310.
apiserver/test/service/serviceV1 Updated image tag to ray:2.46.0-py310.
apiserver/test/job/query Updated image tag to ray:2.46.0-py310.
apiserver/test/job/job Updated image tag to ray:2.46.0-py310.
apiserver/test/e2e/utils.go Increased memory constant from 1 to 4.
apiserver/test/e2e/defaults.go Updated RayVersion and RayImage to 2.46.0.
apiserver/test/e2e/apiserversdk/constants.go Updated RayImage to 2.46.0.
apiserver/test/cluster/cluster_external_redis.yaml Updated rayVersion and image to 2.46.0.
apiserver/test/cluster/cluster/cluster Updated image tag to ray:2.46.0-py310.
apiserver/Makefile Updated E2E_API_SERVER_RAY_IMAGE variable to ray:2.46.0-py310 and its arm64 variant.
apiserver/HttpRequestSpec.md Updated version and image tags to 2.46.0 and 2.46.0-py310 respectively.
apiserver/DEVELOPMENT.md Updated E2E_API_SERVER_RAY_IMAGE documentation to 2.46.0-py310.

@kevin85421 kevin85421 merged commit 564524c into ray-project:master Jun 3, 2025
25 checks passed
pawelpaszki pushed a commit to opendatahub-io/kuberay that referenced this pull request Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants