Skip to content

[Fix][RayCluster] fix missing pod name in CreatedWorkerPod and Failed… #3057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2025
Merged

[Fix][RayCluster] fix missing pod name in CreatedWorkerPod and Failed… #3057

merged 1 commit into from
Feb 14, 2025

Conversation

rueian
Copy link
Contributor

@rueian rueian commented Feb 13, 2025 •
edited
Loading

Why are these changes needed?

Fixes #3056

Before the fix:

Events:
  Type    Reason            Age   From                   Message
  ----    ------            ----  ----                   -------
  Normal  CreatedService    43m   raycluster-controller  Created service default/raycluster-kuberay-head-svc
  Normal  CreatedHeadPod    43m   raycluster-controller  Created head Pod default/raycluster-kuberay-head-l7v7q
  Normal  CreatedWorkerPod  43m   raycluster-controller  Created worker Pod default/

After the fix:
image

Related issue number

Fixes #3056

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@rueian
[Fix][RayCluster] fix missing pod name in CreatedWorkerPod and Failed…
aa35295 
…ToCreateWorkerPod events

Signed-off-by: Rueian <rueiancsie@gmail.com>
@rueian rueian marked this pull request as ready for review February 13, 2025 23:51
@kevin85421 kevin85421 merged commit 084368a into ray-project:master Feb 14, 2025
20 checks passed
andrewsykim pushed a commit to andrewsykim/kuberay that referenced this pull request Feb 14, 2025
@rueian @andrewsykim
[Fix][RayCluster] fix missing pod name in CreatedWorkerPod and Failed…
c096a0b 
…ToCreateWorkerPod events (ray-project#3057)

Signed-off-by: Rueian <rueiancsie@gmail.com>
@andrewsykim andrewsykim mentioned this pull request Feb 14, 2025
Merged
4 tasks
andrewsykim added a commit that referenced this pull request Feb 15, 2025
@andrewsykim @rueian
[Fix][RayCluster] fix missing pod name in CreatedWorkerPod and Failed…
7f8f278 
…ToCreateWorkerPod events (#3057) (#3065)

Signed-off-by: Rueian <rueiancsie@gmail.com>
Co-authored-by: Rueian <rueiancsie@gmail.com>
Ygnas pushed a commit to Ygnas/kuberay that referenced this pull request Mar 20, 2025
@andrewsykim @rueian @Ygnas
[Fix][RayCluster] fix missing pod name in CreatedWorkerPod and Failed…
ddf3c0b 
…ToCreateWorkerPod events (ray-project#3057) (ray-project#3065)

Signed-off-by: Rueian <rueiancsie@gmail.com>
Co-authored-by: Rueian <rueiancsie@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin85421 kevin85421 kevin85421 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] RayCluster K8s event for creating worker Pods
2 participants
@rueian @kevin85421