Skip to content

Conversation

MortalHappiness
Copy link
Member

@MortalHappiness MortalHappiness commented Dec 31, 2024

Why are these changes needed?

See the description in the corresponding issue for details.

Related issue number

Closes: #2388

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@MortalHappiness MortalHappiness force-pushed the feature/#2388-port-forward-retry branch from c056e27 to f466186 Compare December 31, 2024 12:42
Closes: ray-project#2388
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@MortalHappiness MortalHappiness force-pushed the feature/#2388-port-forward-retry branch from f466186 to 7c7604f Compare December 31, 2024 13:08
Closes: ray-project#2388
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@MortalHappiness MortalHappiness force-pushed the feature/#2388-port-forward-retry branch from 7c7604f to d3c83a8 Compare December 31, 2024 13:36
@MortalHappiness MortalHappiness marked this pull request as ready for review December 31, 2024 14:12
@MortalHappiness
Copy link
Member Author

@chiayi @andrewsykim PTAL

Copy link
Contributor

@chiayi chiayi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevin85421
Copy link
Member

stamp

@kevin85421 kevin85421 merged commit 6e8b0b0 into ray-project:master Jan 9, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][kubectl-plugin] Run port-forward in a goroutine and retry if the connection fails
4 participants