Skip to content

add support for pipeline-parallel-size in vLLM example #2370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andrewsykim
Copy link
Member

Why are these changes needed?

Allow pipeline-parallel-size to be configurable in the vLLM example

Related issue number

Related to #2354

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@andrewsykim
Copy link
Member Author

Tested as part of #2354 (comment)

@kevin85421
Copy link
Member

@andrewsykim would you mind rebasing with the master branch? Thanks!

@kevin85421 kevin85421 self-assigned this Sep 10, 2024
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
@andrewsykim andrewsykim force-pushed the vllm-pipeline-parallelism branch from c6d6e5b to 5f50e46 Compare September 10, 2024 21:36
@andrewsykim
Copy link
Member Author

rebased!

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kevin85421 kevin85421 merged commit d6fbdd5 into ray-project:master Sep 10, 2024
27 checks passed
ahsanemon added a commit to ahsanemon/kuberay that referenced this pull request Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants