Skip to content

[2/N][Refactor] Run pre-commit for all files (without golangci-lint) #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MortalHappiness
Copy link
Member

@MortalHappiness MortalHappiness commented May 9, 2024

Why are these changes needed?

Run pre-commit for all files (without the new golangci-lint rules in #2128)

Depends on #2127

Related issue number

N/A

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@MortalHappiness MortalHappiness changed the title [Refactor] Run pre-commit for all files (without golangci-lint) [2/N][Refactor] Run pre-commit for all files (without golangci-lint) May 9, 2024
@MortalHappiness MortalHappiness force-pushed the feature/run-pre-commit-all-files branch from 0cde9e0 to a313664 Compare May 9, 2024 19:30
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files under config/grafana are generated files. It is unnecessary to update them.

Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@MortalHappiness MortalHappiness force-pushed the feature/run-pre-commit-all-files branch from a313664 to f97936a Compare May 10, 2024 12:17
@MortalHappiness
Copy link
Member Author

Files under config/grafana are generated files. It is unnecessary to update them.

Done

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kevin85421 kevin85421 merged commit bed3897 into ray-project:master May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants