Skip to content

[1/N][Chore] Add pre-commit hooks #2127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2024
Merged

[1/N][Chore] Add pre-commit hooks #2127

merged 1 commit into from
May 9, 2024

Conversation

MortalHappiness
Copy link
Member

@MortalHappiness MortalHappiness commented May 9, 2024 •
edited
Loading

Why are these changes needed?

Add pre-commit hooks supports so that developers can know format errors without running the CI.

Reference: https://github.com/nginxinc/nginx-gateway-fabric/blob/0b0f7111364cd6f06883e414f7ef118207ee7677/.pre-commit-config.yaml

Related issue number

N/A

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@MortalHappiness MortalHappiness changed the title [Chore] Add pre-commit hooks [1/N][Chore] Add pre-commit hooks May 9, 2024
This was referenced May 9, 2024
Merged
Merged
@MortalHappiness MortalHappiness force-pushed the feature/pre-commit branch 4 times, most recently from e3acc4b to d7376c5 Compare May 9, 2024 14:44
@MortalHappiness MortalHappiness mentioned this pull request May 9, 2024
Merged
4 tasks
@MortalHappiness MortalHappiness force-pushed the feature/pre-commit branch 4 times, most recently from a8b61a6 to 95137bc Compare May 9, 2024 15:43
@MortalHappiness
[Chore] Add pre-commit hooks
6bd24a7 
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@kevin85421 kevin85421 self-requested a review May 9, 2024 18:44
@kevin85421 kevin85421 self-assigned this May 9, 2024
kevin85421
kevin85421 approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't review the PR carefully. It doesn't touch the operator codebase, so it is safe to merge. I will merge it and try it on my devbox.

@kevin85421 kevin85421 merged commit 49a5725 into ray-project:master May 9, 2024
@kevin85421
Copy link
Member

I tried it locally by adding trailing whitespaces in a YAML file. It works. Niceeeeee!

@boddumanohar boddumanohar mentioned this pull request May 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin85421 kevin85421 kevin85421 approved these changes

Assignees

@kevin85421 kevin85421

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MortalHappiness @kevin85421