Remove the BigInt based NIST reduction functions #4385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going forward the assumption is that if the user cares about ECC performance then pcurves is enabled.
reneme
approved these changes
Oct 17, 2024
|
@guidovranken FYI when merged this will break the cryptofuzz build |
Thanks, now removed https://github.com/guidovranken/cryptofuzz/commit/687d3064c5cef2b0fe1f30824065a2f2c9c0bbd8 |
randombit
added a commit
that referenced
this pull request
Oct 27, 2024
randombit
added a commit
that referenced
this pull request
Oct 29, 2024
randombit
added a commit
that referenced
this pull request
Oct 29, 2024
Fix random test failure introduced by #4385
fanquake
added a commit
to fanquake/cryptofuzz
that referenced
this pull request
Oct 29, 2024
Probably should have been part of 687d306. The header was removed as part of randombit/botan#4385, and it's inclusion is causing build issues downstream, i.e: google/oss-fuzz#12659.
fanquake
added a commit
to fanquake/cryptofuzz
that referenced
this pull request
Nov 22, 2024
Probably should have been part of 687d306. The header was removed as part of randombit/botan#4385, and it's inclusion is causing build issues downstream, i.e: google/oss-fuzz#12659.
fanquake
added a commit
to fanquake/cryptofuzz
that referenced
this pull request
Feb 5, 2025
Probably should have been part of 687d306. The header was removed as part of randombit/botan#4385, and it's inclusion is causing build issues downstream, i.e: google/oss-fuzz#12659.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going forward the assumption is that if the user cares about ECC performance then pcurves is enabled.