Skip to content

Conversation

fanquake
Copy link
Contributor

@fanquake fanquake commented Oct 28, 2024

Copy link

fanquake (verified) is either the primary contact or is in the CCs list of projects/bitcoin-core.

@fanquake fanquake marked this pull request as ready for review October 28, 2024 10:48
fanquake added a commit to fanquake/cryptofuzz that referenced this pull request Oct 29, 2024
Probably should have been part of
687d306.

The header was removed as part of
randombit/botan#4385, and it's inclusion is
causing build issues downstream, i.e:
google/oss-fuzz#12659.
@fanquake
Copy link
Contributor Author

PR'd here that should fix the build issue: https://github.com/guidovranken/cryptofuzz/pull/84.

Copy link
Contributor

@vitorguidi vitorguidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vitorguidi vitorguidi merged commit e0b8762 into google:master Nov 1, 2024
15 checks passed
@fanquake fanquake deleted the no_upnp_no_natpmp branch November 1, 2024 13:52
fanquake added a commit to fanquake/cryptofuzz that referenced this pull request Nov 22, 2024
Probably should have been part of
687d306.

The header was removed as part of
randombit/botan#4385, and it's inclusion is
causing build issues downstream, i.e:
google/oss-fuzz#12659.
fanquake added a commit to fanquake/cryptofuzz that referenced this pull request Feb 5, 2025
Probably should have been part of
687d306.

The header was removed as part of
randombit/botan#4385, and it's inclusion is
causing build issues downstream, i.e:
google/oss-fuzz#12659.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants