Skip to content

[v2.11.0] Removal of catalog v1 #47661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 2, 2024
Merged

[v2.11.0] Removal of catalog v1 #47661

merged 10 commits into from
Dec 2, 2024

Conversation

rohitsakala
Copy link
Member

@rohitsakala rohitsakala commented Oct 22, 2024 •
edited
Loading

Fixes #39525

Please check the issue for more details.

Summary

  • Catalogv1 is deprecated in previous versions. So removing the codebase related to it now in Rancher 2.11.0.
  • Please ignore the shepherd failures in the CI. It will be fixed before merging.

@rohitsakala rohitsakala force-pushed the removal-of-catalog-v1 branch from 39d317c to a0286d7 Compare October 24, 2024 22:55
@rohitsakala rohitsakala marked this pull request as draft October 24, 2024 22:55
@rohitsakala rohitsakala added this to the v2.11.0 milestone Oct 24, 2024
pjbgf
pjbgf reviewed Oct 25, 2024
View reviewed changes
@rohitsakala rohitsakala changed the title Removal of catalog v1 [main] Removal of catalog v1 Oct 25, 2024
@rohitsakala rohitsakala force-pushed the removal-of-catalog-v1 branch 4 times, most recently from 44913b5 to a2a6c5b Compare October 25, 2024 18:02
@rohitsakala rohitsakala requested a review from pjbgf October 25, 2024 18:02
@rohitsakala rohitsakala force-pushed the removal-of-catalog-v1 branch 6 times, most recently from 942daf3 to c240858 Compare October 25, 2024 19:45
@rohitsakala rohitsakala changed the title [main] Removal of catalog v1 [v2.11.0] Removal of catalog v1 Oct 25, 2024
@rohitsakala rohitsakala force-pushed the removal-of-catalog-v1 branch from c240858 to 45c6a75 Compare October 25, 2024 20:20
@rohitsakala rohitsakala requested a review from tashima42 October 25, 2024 20:34
pjbgf
pjbgf reviewed Oct 25, 2024
View reviewed changes
@rohitsakala rohitsakala requested a review from pjbgf October 28, 2024 15:46
@rohitsakala rohitsakala force-pushed the removal-of-catalog-v1 branch 2 times, most recently from 620ed93 to f7d0f0f Compare October 28, 2024 19:18
@rohitsakala rohitsakala marked this pull request as ready for review October 28, 2024 19:33
@rohitsakala rohitsakala force-pushed the removal-of-catalog-v1 branch from b2e8790 to 78c5bbf Compare November 27, 2024 17:42
jiaqiluo
jiaqiluo previously approved these changes Nov 27, 2024
View reviewed changes
JonCrowther
JonCrowther previously approved these changes Nov 28, 2024
View reviewed changes
tashima42
tashima42 previously approved these changes Nov 28, 2024
View reviewed changes
diogoasouza
diogoasouza previously approved these changes Nov 28, 2024
View reviewed changes
pjbgf
pjbgf previously approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohitsakala great job getting this over the line! 🥇 🙇

caliskanugur
caliskanugur approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@caliskanugur caliskanugur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shepherd bits look good to me, thank you for updating codecov stuff! 🚀

prachidamle
prachidamle previously approved these changes Dec 2, 2024
View reviewed changes
@rohitsakala rohitsakala merged commit 90658b9 into rancher:main Dec 2, 2024
19 checks passed
This was referenced Dec 2, 2024
Merged
Merged
HarrisonWAffel added a commit to HarrisonWAffel/terraform-provider-rancher2 that referenced this pull request Feb 12, 2025
@HarrisonWAffel
Remove code related to deprecation of catalog v1, relates to rancher/…
b9736d8 
…rancher#47661

Signed-off-by: Harrison Affel <harrisonaffel@gmail.com>
@HarrisonWAffel HarrisonWAffel mentioned this pull request Mar 4, 2025
Merged
@git-ival git-ival mentioned this pull request Mar 13, 2025
Open
@yonasberhe23 yonasberhe23 mentioned this pull request Mar 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diogoasouza diogoasouza diogoasouza approved these changes

@caliskanugur caliskanugur caliskanugur approved these changes

@prachidamle prachidamle prachidamle left review comments

@pjbgf pjbgf pjbgf left review comments

@jiaqiluo jiaqiluo jiaqiluo left review comments

@JonCrowther JonCrowther JonCrowther left review comments

@tashima42 tashima42 tashima42 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.

Remove legacy feature catalogv1 including multi-cluster app
8 participants
@rohitsakala @pjbgf @diogoasouza @JonCrowther @prachidamle @jiaqiluo @tashima42 @caliskanugur