-
Notifications
You must be signed in to change notification settings - Fork 741
Prepare 0.23.31 #2587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Prepare 0.23.31 #2587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is complex because it does too much (we should fix that) but roughly either operates in "handshake" or "data" mode. The condition here is unreachable in "data" mode (thanks to the line above). In "handshake" mode IO flips between reading and writing rather than doing both at once, so it is rare that both reading and writing are attempted in one loop.
cpu
approved these changes
Jul 29, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel-0.23 #2587 +/- ##
============================================
+ Coverage 95.23% 95.25% +0.02%
============================================
Files 97 97
Lines 21782 21792 +10
============================================
+ Hits 20743 20759 +16
+ Misses 1039 1033 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picks of:
complete_io()
for non-blocking IO #2586Release notes:
complete_io()
not making progress when used with non-blocking IO. This was a regression in 0.23.30 (now yanked).