Fix complete_io() for non-blocking IO
#2586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2586 +/- ##
==========================================
+ Coverage 95.28% 95.31% +0.02%
==========================================
Files 97 97
Lines 21581 21591 +10
==========================================
+ Hits 20564 20580 +16
+ Misses 1017 1011 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cpu
approved these changes
Jul 29, 2025
This function is complex because it does too much (we should fix that) but roughly either operates in "handshake" or "data" mode. The condition here is unreachable in "data" mode (thanks to the line above). In "handshake" mode IO flips between reading and writing rather than doing both at once, so it is rare that both reading and writing are attempted in one loop.
bcd96cb to
ab1d978
Compare
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2584 re #2559 re #2556
This introduces improved testing of
complete_io()(tests which demonstrate the lack of progress bug reported in #2584) and then fixes it in two ways. It also fixes a case where the original issue would return(0, 0)rather than the desired error.I don't much like
complete_io(); it is doing way too much. But this PR is intended to apply cleanly onto rel-0.23, so I'll leave more significant changes to later.