Skip to content

client: pass all of ClientHelloInput into tls12 handle_server_hello() #2518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

client: pass all of ClientHelloInput into tls12 handle_server_hello() #2518

merged 1 commit into from
Jun 25, 2025

Conversation

djc
Copy link
Member

@djc djc commented Jun 24, 2025

@djc djc requested review from cpu and ctz June 24, 2025 11:59
@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Jun 24, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3106368 3157600 ⚠️ 51232 (1.65%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_1.2_no_crypto_server 1052871 1045611 -7260 (-0.69%) 3.68%
handshake_tickets_1.2_no_crypto_server 1213691 1205951 -7740 (-0.64%) 2.65%
handshake_session_id_1.2_no_crypto_client 1149172 1142782 -6390 (-0.56%) 2.08%
handshake_tickets_1.2_no_crypto_client 1236854 1230434 -6420 (-0.52%) 2.74%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9511006 9469746 -41260 (-0.43%) 0.71%
handshake_tickets_1.3_no_crypto_server 2074494 2066514 -7980 (-0.38%) 7.35%
handshake_session_id_1.3_no_crypto_server 2110434 2102484 -7950 (-0.38%) 7.17%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1761396 1767744 6348 (0.36%) 1.04%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11296617 11332856 36239 (0.32%) 1.45%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10419852 10451029 31177 (0.30%) 0.81%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 64822908 64655960 -166948 (-0.26%) 0.69%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4276426 4286424 9998 (0.23%) 0.43%
handshake_no_resume_1.3_no_crypto_server 98330 98105 -225 (-0.23%) 3.96%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 64289645 64408300 118655 (0.18%) 0.28%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 49527837 49437585 -90252 (-0.18%) 0.38%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3751161 3744561 -6600 (-0.18%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3827747 3822017 -5730 (-0.15%) 0.20%
handshake_session_id_1.3_no_crypto_client 2209682 2206472 -3210 (-0.15%) 4.27%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4885858 4878778 -7080 (-0.14%) 0.20%
handshake_tickets_1.3_no_crypto_client 2228228 2225018 -3210 (-0.14%) 4.23%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4160071 4154311 -5760 (-0.14%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 47997959 48063029 65070 (0.14%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4157630 4153100 -4530 (-0.11%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4612294 4607324 -4970 (-0.11%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 64362072 64427698 65626 (0.10%) 0.29%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 64701588 64766968 65380 (0.10%) 0.57%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 64269728 64333468 63740 (0.10%) 0.26%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 64445348 64507643 62295 (0.10%) 0.58%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 64437367 64495223 57856 (0.09%) 0.60%
handshake_session_id_ring_1.2_rsa_aes_client 4232706 4229046 -3660 (-0.09%) 0.20%
handshake_no_resume_1.3_no_crypto_client 111301 111209 -92 (-0.08%) 2.13%
handshake_tickets_ring_1.2_rsa_aes_client 4486031 4482341 -3690 (-0.08%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 48044777 48083103 38326 (0.08%) 0.32%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 47995076 48032505 37429 (0.08%) 0.21%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9489921 9482770 -7151 (-0.08%) 0.91%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 49446023 49483070 37047 (0.07%) 0.50%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 48126045 48161426 35381 (0.07%) 0.38%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 48127537 48162573 35036 (0.07%) 0.50%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3302838 3300861 -1977 (-0.06%) 0.20%
handshake_no_resume_1.2_no_crypto_server 74937 74897 -40 (-0.05%) 1.55%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 64602068 64573199 -28869 (-0.04%) 0.42%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 64629081 64600441 -28640 (-0.04%) 0.68%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3112970 3114183 1213 (0.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11311795 11315721 3926 (0.03%) 0.94%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 48120975 48137406 16431 (0.03%) 0.42%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 64417417 64438948 21531 (0.03%) 0.44%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4279123 4280442 1319 (0.03%) 0.23%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30748350 30756450 8100 (0.03%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30840030 30848130 8100 (0.03%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30752208 30760278 8070 (0.03%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30843888 30851958 8070 (0.03%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30745301 30753331 8030 (0.03%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30836951 30844981 8030 (0.03%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31067898 31075966 8068 (0.03%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31139553 31147621 8068 (0.03%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31072001 31080039 8038 (0.03%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31065035 31073065 8030 (0.03%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31143656 31151694 8038 (0.03%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31136645 31144675 8030 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 64718351 64703642 -14709 (-0.02%) 0.29%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2666320 2666849 529 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1763669 1764001 332 (0.02%) 0.29%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 49377127 49368251 -8876 (-0.02%) 0.35%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 49420105 49411355 -8750 (-0.02%) 0.45%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 49386410 49394329 7919 (0.02%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31730677 31734277 3600 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31732132 31735732 3600 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31732366 31735966 3600 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 31852657 31856257 3600 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 31854112 31857712 3600 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 31854346 31857946 3600 (0.01%) 0.20%
handshake_no_resume_1.2_no_crypto_client 98433 98444 11 (0.01%) 1.86%
handshake_tickets_ring_1.3_rsa_chacha_server 32188617 32192187 3570 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32189786 32193356 3570 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32189801 32193371 3570 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32290857 32294427 3570 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32292026 32295596 3570 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32292041 32295611 3570 (0.01%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2242815 2243015 200 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3303954 3304218 264 (0.01%) 0.33%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2669712 2669909 197 (0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2329878 2330042 164 (0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2335529 2335693 164 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 64616912 64621332 4420 (0.01%) 0.26%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1291158 1291245 87 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 49426822 49423615 -3207 (-0.01%) 0.33%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1289986 1290059 73 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717394 1717440 46 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57901356 57902643 1287 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58057386 58058668 1282 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10987461 10987610 149 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7215601 7215685 84 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58120284 58119641 -643 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58003242 58002602 -640 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58115021 58114380 -641 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58110314 58109678 -636 (-0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_client 117295305 117296586 1281 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 57995387 57994755 -632 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58006214 58005583 -631 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7213649 7213724 75 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92521473 92520828 -645 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92576468 92575823 -645 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11113567 11113644 77 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92532303 92531662 -641 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92570474 92569833 -641 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92580442 92579805 -637 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92530597 92529968 -629 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11119330 11119405 75 (0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_client 117342502 117341861 -641 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34734293 34734468 175 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34732594 34732749 155 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 45917935 45917926 -9 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46010600 46010591 -9 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46176187 46176179 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80245478 80245470 -8 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80367039 80367046 7 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46013174 46013170 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46124480 46124484 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46176465 46176462 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46186559 46186562 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46003288 46003290 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80249967 80249969 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80356950 80356948 -2 (-0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_server 105032246 105032244 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80238177 80238176 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80356023 80356022 -1 (-0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_server 104985036 104985036 0 (0.00%) 0.20%

Wall-time

Significant differences

⚠️ There are significant wall-time differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_1.2_no_crypto 387.13 µs 372.12 µs ✅ -15.01 µs (-3.88%) 3.09%
handshake_tickets_ring_1.2_rsa_aes 1.57 ms 1.55 ms ✅ -0.02 ms (-1.48%) 1.12%
handshake_session_id_ring_1.2_rsa_aes 1.49 ms 1.47 ms ✅ -0.02 ms (-1.26%) 1.11%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_1.2_no_crypto 358.49 µs 343.54 µs -14.95 µs (-4.17%) 6.46%
handshake_no_resume_1.3_no_crypto 87.84 µs 84.62 µs -3.23 µs (-3.67%) 9.25%
handshake_no_resume_1.2_no_crypto 78.90 µs 76.37 µs -2.53 µs (-3.21%) 6.09%
handshake_tickets_1.3_no_crypto 645.69 µs 634.13 µs -11.57 µs (-1.79%) 8.95%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.29 ms 5.21 ms -0.09 ms (-1.64%) 7.01%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.60 ms 4.53 ms -0.08 ms (-1.64%) 8.61%
handshake_session_id_1.3_no_crypto 662.89 µs 652.27 µs -10.62 µs (-1.60%) 8.36%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.37 ms 5.29 ms -0.09 ms (-1.60%) 6.67%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.25 ms 5.17 ms -0.07 ms (-1.43%) 6.84%
transfer_no_resume_ring_1.3_rsa_aes 5.86 ms 5.77 ms -0.08 ms (-1.41%) 5.78%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.03 ms 4.97 ms -0.06 ms (-1.27%) 5.95%
transfer_no_resume_ring_1.2_rsa_aes 5.78 ms 5.71 ms -0.07 ms (-1.22%) 4.28%
transfer_no_resume_1.2_no_crypto 11.75 ms 11.65 ms -0.10 ms (-0.84%) 2.03%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.76 ms 1.74 ms -0.01 ms (-0.83%) 4.01%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 582.00 µs 577.31 µs -4.69 µs (-0.81%) 3.25%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 581.59 µs 576.92 µs -4.67 µs (-0.80%) 3.23%
handshake_no_resume_ring_1.3_ecdsap256_chacha 457.90 µs 454.31 µs -3.59 µs (-0.78%) 3.05%
handshake_no_resume_ring_1.3_ecdsap256_aes 460.42 µs 456.94 µs -3.48 µs (-0.76%) 3.11%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.46 ms 8.40 ms -0.06 ms (-0.72%) 4.45%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.93 ms 12.85 ms -0.08 ms (-0.64%) 2.62%
transfer_no_resume_ring_1.3_rsa_chacha 13.41 ms 13.33 ms -0.08 ms (-0.61%) 2.67%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.07 ms 12.99 ms -0.08 ms (-0.59%) 2.49%
transfer_no_resume_1.3_no_crypto 11.77 ms 11.70 ms -0.07 ms (-0.57%) 3.43%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.75 ms 13.68 ms -0.08 ms (-0.56%) 2.38%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.73 ms 13.66 ms -0.07 ms (-0.52%) 2.63%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.02 ms 15.95 ms -0.07 ms (-0.42%) 2.28%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 8.65 ms 8.61 ms -0.03 ms (-0.40%) 2.26%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 8.67 ms 8.64 ms -0.03 ms (-0.38%) 2.22%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 8.46 ms 8.43 ms -0.03 ms (-0.38%) 2.06%
handshake_no_resume_ring_1.3_rsa_chacha 949.75 µs 946.21 µs -3.54 µs (-0.37%) 1.73%
handshake_no_resume_ring_1.3_rsa_aes 950.72 µs 947.36 µs -3.36 µs (-0.35%) 1.57%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 8.49 ms 8.46 ms -0.03 ms (-0.34%) 2.26%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.26 ms 1.26 ms -0.00 ms (-0.32%) 1.72%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 9.13 ms 9.10 ms -0.03 ms (-0.31%) 2.14%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.22 ms 1.23 ms 0.00 ms (0.30%) 5.87%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 9.13 ms 9.10 ms -0.03 ms (-0.30%) 2.63%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 9.35 ms 9.32 ms -0.03 ms (-0.29%) 1.74%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.59 ms 1.59 ms -0.00 ms (-0.28%) 5.53%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 9.16 ms 9.14 ms -0.03 ms (-0.27%) 1.71%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.23 ms 1.24 ms 0.00 ms (0.27%) 8.29%
handshake_no_resume_ring_1.2_rsa_aes 942.37 µs 940.09 µs -2.28 µs (-0.24%) 1.16%
handshake_session_id_ring_1.3_rsa_aes 5.96 ms 5.94 ms -0.01 ms (-0.23%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.02 ms 6.00 ms -0.01 ms (-0.23%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.55 ms 3.56 ms 0.01 ms (0.23%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.06 ms 1.06 ms 0.00 ms (0.22%) 7.50%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 9.31 ms 9.29 ms -0.02 ms (-0.21%) 2.19%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.56 ms 3.56 ms 0.01 ms (0.21%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 5.92 ms 5.91 ms -0.01 ms (-0.21%) 1.10%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 9.30 ms 9.28 ms -0.02 ms (-0.21%) 2.62%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 9.32 ms 9.30 ms -0.02 ms (-0.20%) 2.33%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.25 ms 1.25 ms -0.00 ms (-0.19%) 1.39%
handshake_tickets_ring_1.3_rsa_chacha 5.98 ms 5.97 ms -0.01 ms (-0.17%) 1.07%
handshake_tickets_ring_1.3_ecdsap256_aes 5.52 ms 5.51 ms -0.01 ms (-0.13%) 1.05%
handshake_session_id_ring_1.3_ecdsap256_aes 5.46 ms 5.45 ms -0.01 ms (-0.12%) 1.29%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 9.15 ms 9.14 ms -0.01 ms (-0.11%) 3.05%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.43 ms 5.42 ms -0.01 ms (-0.10%) 1.32%
handshake_session_id_ring_1.3_ecdsap384_aes 8.55 ms 8.55 ms -0.01 ms (-0.09%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 8.62 ms 8.61 ms -0.01 ms (-0.07%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.52 ms 8.52 ms -0.01 ms (-0.06%) 1.28%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.49 ms 5.48 ms -0.00 ms (-0.06%) 1.43%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.58 ms 8.58 ms -0.00 ms (-0.01%) 1.00%

Additional information

Historical results

Checkout details:

djc
djc commented Jun 24, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Jun 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.31%. Comparing base (6cc7a45) to head (9e1e98b).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2518      +/-   ##
==========================================
- Coverage   95.31%   95.31%   -0.01%     
==========================================
  Files          97       97              
  Lines       21507    21504       -3     
==========================================
- Hits        20499    20496       -3     
  Misses       1008     1008

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djc djc added this pull request to the merge queue Jun 25, 2025
Merged via the queue into main with commit 4b3c053 Jun 25, 2025
34 checks passed
@djc djc deleted the tls12-input branch June 25, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctz ctz ctz approved these changes

@cpu cpu Awaiting requested review from cpu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djc @ctz