Skip to content

client: refactor in preparation for PSK support #2516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 23, 2025
Merged

client: refactor in preparation for PSK support #2516

merged 3 commits into from
Jun 23, 2025

Conversation

djc
Copy link
Member

@djc djc commented Jun 23, 2025

I believe these are all more or less useful in isolation.

@djc djc requested review from cpu and ctz June 23, 2025 13:59
@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Jun 23, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_1.3_no_crypto_client 2248948 2216518 ✅ -32430 (-1.44%) 0.20%
handshake_tickets_1.3_no_crypto_client 2267498 2235068 ✅ -32430 (-1.43%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1786960 1761846 ✅ -25114 (-1.41%) 1.22%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4325405 4277174 ✅ -48231 (-1.12%) 1.01%
handshake_tickets_1.3_no_crypto_server 2104505 2081645 ✅ -22860 (-1.09%) 0.20%
handshake_session_id_1.3_no_crypto_server 2140584 2117694 ✅ -22890 (-1.07%) 0.20%
handshake_no_resume_1.3_no_crypto_server 99200 98595 ✅ -605 (-0.61%) 0.20%
handshake_no_resume_1.3_no_crypto_client 112144 111480 ✅ -664 (-0.59%) 0.20%
handshake_session_id_1.2_no_crypto_client 1153890 1147470 ✅ -6420 (-0.56%) 0.20%
handshake_tickets_1.2_no_crypto_client 1241534 1235114 ✅ -6420 (-0.52%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11303861 11358302 54441 (0.48%) 1.45%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10397742 10443766 46024 (0.44%) 0.95%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 64572570 64402059 -170511 (-0.26%) 0.60%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11332276 11305827 -26449 (-0.23%) 0.95%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 64723482 64594104 -129378 (-0.20%) 0.64%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 48207223 48115067 -92156 (-0.19%) 0.50%
handshake_session_id_ring_1.2_rsa_aes_client 4240866 4233816 -7050 (-0.17%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4494161 4487111 -7050 (-0.16%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3833117 3827417 -5700 (-0.15%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 64471421 64377205 -94216 (-0.15%) 0.59%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 49479527 49407782 -71745 (-0.14%) 0.42%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4165411 4159711 -5700 (-0.14%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 64626738 64698879 72141 (0.11%) 0.70%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 48159931 48106254 -53677 (-0.11%) 0.52%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30798910 30766500 -32410 (-0.11%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30802804 30770394 -32410 (-0.11%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30795821 30763451 -32370 (-0.11%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30890590 30858180 -32410 (-0.10%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30894484 30862074 -32410 (-0.10%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30887471 30855101 -32370 (-0.10%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31118464 31086048 -32416 (-0.10%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31122537 31090121 -32416 (-0.10%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31115551 31083185 -32366 (-0.10%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31190119 31157703 -32416 (-0.10%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31194192 31161776 -32416 (-0.10%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31187161 31154795 -32366 (-0.10%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 64376001 64440865 64864 (0.10%) 0.63%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 48100669 48053614 -47055 (-0.10%) 0.22%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 64445991 64390302 -55689 (-0.09%) 0.32%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3115299 3112741 -2558 (-0.08%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31771233 31748313 -22920 (-0.07%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31772926 31750006 -22920 (-0.07%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31772692 31749802 -22890 (-0.07%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 31893213 31870293 -22920 (-0.07%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 31894906 31871986 -22920 (-0.07%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 31894672 31871782 -22890 (-0.07%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32229147 32206287 -22860 (-0.07%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32230316 32207456 -22860 (-0.07%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32230331 32207471 -22860 (-0.07%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32331387 32308527 -22860 (-0.07%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32332556 32309696 -22860 (-0.07%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32332571 32309711 -22860 (-0.07%) 0.20%
handshake_session_id_1.2_no_crypto_server 1052991 1052301 -690 (-0.07%) 0.20%
handshake_no_resume_1.2_no_crypto_client 98616 98552 -64 (-0.06%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 49428814 49458417 29603 (0.06%) 0.38%
handshake_tickets_1.2_no_crypto_server 1214171 1213481 -690 (-0.06%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 64611751 64647249 35498 (0.05%) 0.29%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 48103179 48128803 25624 (0.05%) 0.42%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 64659388 64625870 -33518 (-0.05%) 0.50%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 64403627 64371496 -32131 (-0.05%) 0.31%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 64356206 64324962 -31244 (-0.05%) 0.32%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1292300 1291683 -617 (-0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 48077383 48054508 -22875 (-0.05%) 0.40%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 49419198 49395788 -23410 (-0.05%) 0.28%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 48050348 48028042 -22306 (-0.05%) 0.52%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1291106 1290511 -595 (-0.05%) 0.20%
handshake_no_resume_1.2_no_crypto_server 75160 75128 -32 (-0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 49427601 49409638 -17963 (-0.04%) 0.55%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 64641271 64618298 -22973 (-0.04%) 0.57%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3106813 3105731 -1082 (-0.03%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2330971 2330327 -644 (-0.03%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2336622 2335978 -644 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 49385317 49396092 10775 (0.02%) 0.34%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2670412 2669848 -564 (-0.02%) 0.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1764202 1763852 -350 (-0.02%) 0.29%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3304847 3304231 -616 (-0.02%) 0.50%
transfer_no_resume_ring_1.2_rsa_aes_client 57900716 57891760 -8956 (-0.02%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58005577 57996615 -8962 (-0.02%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 57994747 57985787 -8960 (-0.02%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58002604 57993645 -8959 (-0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58056749 58047782 -8967 (-0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58114384 58105422 -8962 (-0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58109679 58100718 -8961 (-0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58119643 58110681 -8962 (-0.02%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4158980 4158380 -600 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3303697 3303225 -472 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 49393717 49387204 -6513 (-0.01%) 0.38%
handshake_tickets_ring_1.2_rsa_aes_server 4613938 4613338 -600 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2667388 2667069 -319 (-0.01%) 0.33%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9499398 9498347 -1051 (-0.01%) 0.92%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92569842 92560871 -8971 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92520834 92511874 -8960 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92529963 92521008 -8955 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92579795 92570839 -8956 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92531654 92522703 -8951 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92575817 92566865 -8952 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7216740 7216128 -612 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7214769 7214174 -595 (-0.01%) 0.20%
transfer_no_resume_1.2_no_crypto_client 117294668 117285699 -8969 (-0.01%) 0.20%
transfer_no_resume_1.3_no_crypto_client 117341860 117332900 -8960 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9502453 9501742 -711 (-0.01%) 0.71%
handshake_no_resume_ring_1.3_rsa_aes_server 11114687 11114092 -595 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11120450 11119855 -595 (-0.01%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2243163 2243084 -79 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717627 1717577 -50 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4279093 4278984 -109 (-0.00%) 0.26%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34735415 34734726 -689 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34733689 34733020 -669 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 64611572 64612582 1010 (0.00%) 0.52%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3750291 3750321 30 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4885348 4885378 30 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10987799 10987770 -29 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46133437 46133446 9 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46019550 46019558 8 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 45926893 45926886 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80247128 80247137 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46185424 46185419 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80376000 80376008 8 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80258930 80258937 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80365901 80365908 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46195524 46195528 4 (0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_server 104993999 104993990 -9 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46022132 46022135 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80364976 80364980 4 (0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_server 105041208 105041203 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46185143 46185141 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46012250 46012249 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80254438 80254437 -1 (-0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_1.2_no_crypto 80.45 µs 77.62 µs -2.84 µs (-3.53%) 5.00%
handshake_session_id_1.2_no_crypto 353.58 µs 342.34 µs -11.24 µs (-3.18%) 5.00%
handshake_no_resume_1.3_no_crypto 89.66 µs 86.82 µs -2.84 µs (-3.17%) 5.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.24 ms 1.28 ms 0.04 ms (3.00%) 9.08%
handshake_tickets_1.2_no_crypto 383.35 µs 373.42 µs -9.92 µs (-2.59%) 5.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.07 ms 1.10 ms 0.03 ms (2.53%) 7.52%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.23 ms 1.26 ms 0.03 ms (2.40%) 6.40%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.77 ms 1.80 ms 0.04 ms (2.07%) 4.20%
transfer_no_resume_1.3_no_crypto 11.97 ms 11.74 ms -0.24 ms (-1.97%) 5.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.66 ms 4.56 ms -0.09 ms (-1.96%) 8.72%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.34 ms 5.25 ms -0.09 ms (-1.69%) 7.33%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.41 ms 5.33 ms -0.09 ms (-1.61%) 6.87%
transfer_no_resume_ring_1.3_rsa_aes 5.90 ms 5.81 ms -0.09 ms (-1.52%) 6.20%
handshake_session_id_1.3_no_crypto 664.79 µs 654.88 µs -9.91 µs (-1.49%) 5.00%
transfer_no_resume_ring_1.2_rsa_aes 5.82 ms 5.74 ms -0.08 ms (-1.39%) 5.84%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.60 ms 1.62 ms 0.02 ms (1.25%) 4.59%
handshake_tickets_1.3_no_crypto 644.82 µs 636.96 µs -7.86 µs (-1.22%) 5.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.30 ms 5.25 ms -0.06 ms (-1.05%) 7.18%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.51 ms 8.42 ms -0.09 ms (-1.01%) 4.56%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.09 ms 5.04 ms -0.05 ms (-0.93%) 6.99%
handshake_no_resume_ring_1.3_ecdsap256_chacha 460.48 µs 456.40 µs -4.07 µs (-0.88%) 3.94%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 583.12 µs 578.15 µs -4.97 µs (-0.85%) 3.24%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 586.11 µs 581.21 µs -4.90 µs (-0.84%) 3.60%
handshake_no_resume_ring_1.3_ecdsap256_aes 463.68 µs 459.86 µs -3.82 µs (-0.82%) 3.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 8.70 ms 8.63 ms -0.07 ms (-0.81%) 3.28%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 8.53 ms 8.46 ms -0.07 ms (-0.81%) 3.48%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 9.16 ms 9.09 ms -0.07 ms (-0.80%) 2.77%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 8.48 ms 8.41 ms -0.07 ms (-0.79%) 3.12%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 9.21 ms 9.14 ms -0.07 ms (-0.78%) 3.28%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 8.66 ms 8.60 ms -0.07 ms (-0.76%) 2.98%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 9.39 ms 9.32 ms -0.07 ms (-0.72%) 2.98%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 9.34 ms 9.28 ms -0.06 ms (-0.68%) 2.64%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.97 ms 12.88 ms -0.09 ms (-0.67%) 2.68%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.12 ms 13.04 ms -0.08 ms (-0.61%) 2.87%
transfer_no_resume_ring_1.3_rsa_chacha 13.46 ms 13.38 ms -0.08 ms (-0.60%) 2.74%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.07 ms 15.98 ms -0.09 ms (-0.57%) 2.29%
handshake_tickets_ring_1.2_rsa_aes 1.56 ms 1.55 ms -0.01 ms (-0.57%) 1.13%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.80 ms 13.72 ms -0.08 ms (-0.57%) 2.85%
transfer_no_resume_1.2_no_crypto 11.76 ms 11.70 ms -0.06 ms (-0.55%) 5.00%
handshake_no_resume_ring_1.3_rsa_aes 952.96 µs 948.44 µs -4.52 µs (-0.47%) 1.65%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.78 ms 13.72 ms -0.06 ms (-0.44%) 2.73%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 9.37 ms 9.33 ms -0.04 ms (-0.43%) 3.17%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.27 ms 1.27 ms -0.00 ms (-0.39%) 1.77%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 9.34 ms 9.30 ms -0.04 ms (-0.38%) 2.84%
handshake_no_resume_ring_1.3_rsa_chacha 952.76 µs 949.13 µs -3.64 µs (-0.38%) 1.88%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 9.16 ms 9.13 ms -0.03 ms (-0.38%) 3.32%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 9.20 ms 9.17 ms -0.03 ms (-0.33%) 3.15%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.26 ms 1.26 ms -0.00 ms (-0.32%) 1.40%
handshake_session_id_ring_1.3_rsa_aes 5.95 ms 5.96 ms 0.02 ms (0.26%) 1.08%
handshake_no_resume_ring_1.2_rsa_aes 944.99 µs 942.71 µs -2.28 µs (-0.24%) 1.17%
handshake_session_id_ring_1.3_ecdsap256_aes 5.46 ms 5.47 ms 0.01 ms (0.22%) 1.48%
handshake_session_id_ring_1.3_ecdsap384_aes 8.54 ms 8.56 ms 0.02 ms (0.21%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.48 ms 1.48 ms -0.00 ms (-0.20%) 1.17%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.56 ms 3.55 ms -0.00 ms (-0.13%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.56 ms 3.55 ms -0.00 ms (-0.12%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 5.92 ms 5.93 ms 0.01 ms (0.11%) 1.57%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.43 ms 5.44 ms 0.00 ms (0.08%) 1.84%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.59 ms 8.58 ms -0.01 ms (-0.08%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 5.53 ms 5.53 ms 0.00 ms (0.07%) 1.27%
handshake_tickets_ring_1.3_rsa_aes 6.01 ms 6.02 ms 0.00 ms (0.03%) 1.02%
handshake_tickets_ring_1.3_rsa_chacha 5.98 ms 5.98 ms -0.00 ms (-0.01%) 1.29%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.53 ms 8.53 ms 0.00 ms (0.01%) 1.29%
handshake_tickets_ring_1.3_ecdsap384_aes 8.62 ms 8.62 ms 0.00 ms (0.01%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.49 ms 5.49 ms -0.00 ms (-0.00%) 1.59%

Additional information

Historical results

Checkout details:

@djc djc enabled auto-merge June 23, 2025 14:23
@djc djc force-pushed the client-tweaks branch from b0b6be5 to b41d46f Compare June 23, 2025 15:35
@djc djc force-pushed the client-tweaks branch from b41d46f to e702e4d Compare June 23, 2025 15:36
@djc djc added this pull request to the merge queue Jun 23, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (692f981) to head (e702e4d).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2516      +/-   ##
==========================================
- Coverage   95.29%   95.29%   -0.01%     
==========================================
  Files          97       97              
  Lines       21470    21468       -2     
==========================================
- Hits        20460    20458       -2     
  Misses       1010     1010

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Merged via the queue into main with commit 6cc7a45 Jun 23, 2025
33 checks passed
@djc djc deleted the client-tweaks branch June 23, 2025 16:01
@djc djc mentioned this pull request Jun 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djc @cpu @ctz