Skip to content

Reduce small Vec<Enum> uses in extensions #2509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 23, 2025
Merged

Reduce small Vec<Enum> uses in extensions #2509

merged 4 commits into from
Jun 23, 2025

Conversation

ctz
Copy link
Member

@ctz ctz commented Jun 20, 2025

Instead, where possible, extract just the information we need during encoding.

"Where possible" -- specifically where the vector only encodes a peers capabilities rather than its preferences. This is true for both of these extensions, but for things like signature_schemes a different approach (that also retains the preference) would be needed.

This reduces some complexity, but the main goal is reducing the size of the extensions struct: sizeof(Option<Vec<PskKeyExchangeMode>>) is 24 bytes, but sizeof(Option<PskKeyExchangeModes>) is 2 bytes.

This follows on from #2508 and #2502.

@ctz ctz mentioned this pull request Jun 20, 2025
Merged
@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Jun 20, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1762494 1787292 ⚠️ 24798 (1.41%) 1.22%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4279250 4325762 ⚠️ 46512 (1.09%) 1.01%
handshake_session_id_1.3_no_crypto_client 2248948 2224952 ✅ -23996 (-1.07%) 0.20%
handshake_tickets_1.3_no_crypto_client 2267498 2243498 ✅ -24000 (-1.06%) 0.20%
handshake_tickets_1.3_no_crypto_server 2104505 2092524 ✅ -11981 (-0.57%) 0.20%
handshake_session_id_1.3_no_crypto_server 2140584 2128494 ✅ -12090 (-0.56%) 0.20%
handshake_session_id_1.2_no_crypto_client 1153890 1147882 ✅ -6008 (-0.52%) 0.20%
handshake_tickets_1.2_no_crypto_client 1241534 1235564 ✅ -5970 (-0.48%) 0.20%
handshake_no_resume_1.3_no_crypto_server 99200 98815 ✅ -385 (-0.39%) 0.20%
handshake_no_resume_1.2_no_crypto_server 75160 74869 ✅ -291 (-0.39%) 0.20%
handshake_no_resume_1.3_no_crypto_client 112144 111800 ✅ -344 (-0.31%) 0.20%
handshake_no_resume_1.2_no_crypto_client 98616 98372 ✅ -244 (-0.25%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 64825436 64550485 -274951 (-0.42%) 0.64%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11289168 11333568 44400 (0.39%) 1.45%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10427885 10468613 40728 (0.39%) 0.95%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 49530008 49395146 -134862 (-0.27%) 0.42%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 64510315 64337661 -172654 (-0.27%) 0.32%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 64479129 64336733 -142396 (-0.22%) 0.59%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 64433550 64296800 -136750 (-0.21%) 0.32%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9515572 9498117 -17455 (-0.18%) 0.71%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 48127410 48043447 -83963 (-0.17%) 0.52%
handshake_tickets_1.2_no_crypto_server 1214171 1212191 -1980 (-0.16%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4240866 4234236 -6630 (-0.16%) 0.20%
handshake_session_id_1.2_no_crypto_server 1052991 1051371 -1620 (-0.15%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4494161 4487561 -6600 (-0.15%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 48163651 48095081 -68570 (-0.14%) 0.52%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3833117 3827837 -5280 (-0.14%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 48081977 48015927 -66050 (-0.14%) 0.22%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4165411 4160161 -5250 (-0.13%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9481561 9493218 11657 (0.12%) 0.92%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 64469561 64396089 -73472 (-0.11%) 0.60%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 64382136 64453326 71190 (0.11%) 0.63%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 48106403 48144199 37796 (0.08%) 0.42%
handshake_session_id_ring_1.3_rsa_chacha_client 30802804 30778738 -24066 (-0.08%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30795821 30771821 -24000 (-0.08%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30798910 30774910 -24000 (-0.08%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30894484 30870418 -24066 (-0.08%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30887471 30863471 -24000 (-0.08%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30890590 30866590 -24000 (-0.08%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31115551 31091551 -24000 (-0.08%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31118464 31094464 -24000 (-0.08%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31122537 31098537 -24000 (-0.08%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31187161 31163161 -24000 (-0.08%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31190119 31166119 -24000 (-0.08%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31194192 31170192 -24000 (-0.08%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 48155979 48121295 -34684 (-0.07%) 0.50%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 64626405 64664559 38154 (0.06%) 0.70%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3107453 3105833 -1620 (-0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 49428837 49450680 21843 (0.04%) 0.38%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 64695642 64723019 27377 (0.04%) 0.52%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 64646380 64671295 24915 (0.04%) 0.50%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 64590205 64565493 -24712 (-0.04%) 0.57%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 64370964 64393158 22194 (0.03%) 0.31%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31772692 31761742 -10950 (-0.03%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31772926 31761976 -10950 (-0.03%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31771233 31760287 -10946 (-0.03%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 31894672 31883722 -10950 (-0.03%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 31894906 31883956 -10950 (-0.03%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 31893213 31882267 -10946 (-0.03%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32229147 32218197 -10950 (-0.03%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32230316 32219366 -10950 (-0.03%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32230331 32219381 -10950 (-0.03%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32331387 32320437 -10950 (-0.03%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32332556 32321606 -10950 (-0.03%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32332571 32321621 -10950 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 49435762 49452179 16417 (0.03%) 0.38%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 49412557 49427814 15257 (0.03%) 0.28%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4280662 4279425 -1237 (-0.03%) 0.26%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 48060976 48074669 13693 (0.03%) 0.40%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 64712217 64693827 -18390 (-0.03%) 0.29%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1292290 1291931 -359 (-0.03%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1291106 1290759 -347 (-0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1764785 1764331 -454 (-0.03%) 0.29%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11315698 11312914 -2784 (-0.02%) 0.95%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 49402176 49391054 -11122 (-0.02%) 0.55%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3750291 3751041 750 (0.02%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 45926891 45917932 -8959 (-0.02%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46022129 46013167 -8962 (-0.02%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46012257 46003298 -8959 (-0.02%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46019550 46010591 -8959 (-0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46133435 46124479 -8956 (-0.02%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3303887 3303281 -606 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2667607 2667118 -489 (-0.02%) 0.33%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3113858 3113327 -531 (-0.02%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4158980 4159670 690 (0.02%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2330971 2330631 -340 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2336622 2336282 -340 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 49433943 49427306 -6637 (-0.01%) 0.34%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305061 3304629 -432 (-0.01%) 0.50%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717612 1717397 -215 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80247136 80238176 -8960 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80254437 80245480 -8957 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80258934 80249977 -8957 (-0.01%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2243163 2242922 -241 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2670163 2670415 252 (0.01%) 0.23%
handshake_tickets_ring_1.2_rsa_aes_server 4613938 4614334 396 (0.01%) 0.20%
transfer_no_resume_1.2_no_crypto_server 104993995 104985032 -8963 (-0.01%) 0.20%
transfer_no_resume_1.3_no_crypto_server 105041207 105032248 -8959 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4885348 4885738 390 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7214769 7214422 -347 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7216721 7216374 -347 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11114687 11114340 -347 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11120450 11120103 -347 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46185145 46186426 1281 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46195519 46196800 1281 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46185421 46186699 1278 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10987799 10987561 -238 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80364979 80366265 1286 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80376008 80377288 1280 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80365909 80367184 1275 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34733689 34733345 -344 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34735388 34735048 -340 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58005573 58005583 10 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92569831 92569842 11 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92520827 92520835 8 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92531654 92531662 8 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57900724 57900720 -4 (-0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_client 117294665 117294658 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 57994747 57994749 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58002600 58002598 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92529964 92529967 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92579798 92579801 3 (0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_client 117341866 117341863 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58056746 58056745 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58114379 58114378 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58119645 58119645 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58109675 58109675 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92575823 92575823 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_1.2_no_crypto 80.68 µs 77.80 µs -2.87 µs (-3.56%) 5.00%
handshake_no_resume_1.3_no_crypto 90.07 µs 87.36 µs -2.71 µs (-3.00%) 5.00%
handshake_session_id_1.2_no_crypto 353.63 µs 360.49 µs 6.86 µs (1.94%) 5.00%
transfer_no_resume_1.3_no_crypto 11.97 ms 11.75 ms -0.23 ms (-1.89%) 5.00%
handshake_no_resume_ring_1.3_ecdsap256_chacha 462.20 µs 455.20 µs -7.00 µs (-1.51%) 3.94%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.10 ms 5.02 ms -0.07 ms (-1.45%) 6.99%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.65 ms 4.58 ms -0.07 ms (-1.42%) 8.72%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 588.93 µs 581.16 µs -7.78 µs (-1.32%) 3.60%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.33 ms 5.27 ms -0.07 ms (-1.27%) 7.33%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 585.32 µs 578.24 µs -7.08 µs (-1.21%) 3.24%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.30 ms 5.24 ms -0.06 ms (-1.14%) 7.18%
transfer_no_resume_ring_1.2_rsa_aes 5.83 ms 5.77 ms -0.06 ms (-1.11%) 5.84%
handshake_tickets_1.2_no_crypto 383.00 µs 387.15 µs 4.14 µs (1.08%) 5.00%
handshake_no_resume_ring_1.3_ecdsap256_aes 465.34 µs 460.88 µs -4.45 µs (-0.96%) 3.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.60 ms 1.61 ms 0.01 ms (0.90%) 4.59%
transfer_no_resume_ring_1.3_rsa_aes 5.90 ms 5.85 ms -0.05 ms (-0.84%) 6.20%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.41 ms 5.37 ms -0.04 ms (-0.81%) 6.87%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 8.52 ms 8.46 ms -0.06 ms (-0.74%) 3.48%
handshake_session_id_ring_1.2_rsa_aes 1.48 ms 1.49 ms 0.01 ms (0.70%) 1.17%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 9.20 ms 9.13 ms -0.06 ms (-0.68%) 3.28%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 8.48 ms 8.42 ms -0.05 ms (-0.62%) 3.12%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 8.69 ms 8.64 ms -0.05 ms (-0.60%) 3.28%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.25 ms 1.25 ms 0.01 ms (0.59%) 9.08%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 9.38 ms 9.33 ms -0.05 ms (-0.58%) 2.98%
handshake_no_resume_ring_1.3_rsa_chacha 952.94 µs 947.52 µs -5.42 µs (-0.57%) 1.88%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 9.20 ms 9.15 ms -0.05 ms (-0.56%) 3.15%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.51 ms 8.46 ms -0.05 ms (-0.56%) 4.56%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 8.66 ms 8.62 ms -0.04 ms (-0.52%) 2.98%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.80 ms 13.73 ms -0.07 ms (-0.51%) 2.85%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.07 ms 1.08 ms 0.01 ms (0.50%) 7.52%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 9.36 ms 9.32 ms -0.05 ms (-0.50%) 3.17%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 9.15 ms 9.10 ms -0.05 ms (-0.49%) 2.77%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 9.16 ms 9.11 ms -0.05 ms (-0.49%) 3.32%
transfer_no_resume_1.2_no_crypto 11.78 ms 11.72 ms -0.06 ms (-0.49%) 5.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.26 ms 1.26 ms -0.01 ms (-0.48%) 1.40%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.12 ms 13.06 ms -0.06 ms (-0.46%) 2.87%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.27 ms 1.27 ms -0.01 ms (-0.43%) 1.77%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.78 ms 13.72 ms -0.06 ms (-0.43%) 2.73%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 9.34 ms 9.30 ms -0.04 ms (-0.42%) 2.64%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.76 ms 1.77 ms 0.01 ms (0.41%) 4.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 9.34 ms 9.30 ms -0.04 ms (-0.40%) 2.84%
handshake_no_resume_ring_1.2_rsa_aes 945.79 µs 942.03 µs -3.76 µs (-0.40%) 1.17%
handshake_no_resume_ring_1.3_rsa_aes 952.62 µs 949.17 µs -3.45 µs (-0.36%) 1.65%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.24 ms 1.24 ms 0.00 ms (0.35%) 6.40%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.97 ms 12.92 ms -0.04 ms (-0.35%) 2.68%
transfer_no_resume_ring_1.3_rsa_chacha 13.45 ms 13.41 ms -0.04 ms (-0.33%) 2.74%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.43 ms 5.42 ms -0.02 ms (-0.33%) 1.84%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.49 ms 5.48 ms -0.02 ms (-0.31%) 1.59%
handshake_tickets_ring_1.3_rsa_chacha 5.98 ms 5.96 ms -0.02 ms (-0.30%) 1.29%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.06 ms 16.02 ms -0.05 ms (-0.29%) 2.29%
handshake_tickets_ring_1.3_ecdsap256_aes 5.52 ms 5.51 ms -0.01 ms (-0.26%) 1.27%
handshake_tickets_ring_1.3_rsa_aes 6.01 ms 6.00 ms -0.01 ms (-0.25%) 1.02%
handshake_session_id_1.3_no_crypto 662.43 µs 664.00 µs 1.57 µs (0.24%) 5.00%
handshake_tickets_ring_1.2_rsa_aes 1.56 ms 1.56 ms 0.00 ms (0.23%) 1.13%
handshake_session_id_ring_1.3_rsa_chacha 5.92 ms 5.91 ms -0.01 ms (-0.22%) 1.57%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.59 ms 8.57 ms -0.02 ms (-0.20%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 8.62 ms 8.60 ms -0.02 ms (-0.18%) 1.00%
handshake_tickets_1.3_no_crypto 644.65 µs 643.72 µs -0.92 µs (-0.14%) 5.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.52 ms 8.51 ms -0.01 ms (-0.14%) 1.29%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.56 ms 3.55 ms -0.00 ms (-0.13%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 5.95 ms 5.94 ms -0.01 ms (-0.11%) 1.08%
handshake_session_id_ring_1.3_ecdsap256_aes 5.45 ms 5.45 ms -0.00 ms (-0.08%) 1.48%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.56 ms 3.56 ms -0.00 ms (-0.08%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.54 ms 8.54 ms -0.00 ms (-0.00%) 1.00%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented Jun 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.18310% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.31%. Comparing base (692f981) to head (8410541).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
rustls/src/msgs/handshake.rs 94.73% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2509      +/-   ##
==========================================
+ Coverage   95.29%   95.31%   +0.01%     
==========================================
  Files          97       97              
  Lines       21470    21509      +39     
==========================================
+ Hits        20460    20501      +41     
+ Misses       1010     1008       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

djc
djc approved these changes Jun 20, 2025
View reviewed changes
@ctz ctz force-pushed the jbp-extension-repr-2 branch 2 times, most recently from caa112f to b5eb9ed Compare June 20, 2025 11:51
djc
djc approved these changes Jun 20, 2025
View reviewed changes
@ctz ctz force-pushed the jbp-extension-repr-2 branch from b5eb9ed to d0b3433 Compare June 20, 2025 11:56
@ctz ctz force-pushed the jbp-server-exts branch 4 times, most recently from a63cb5d to a0523f1 Compare June 23, 2025 14:29
Base automatically changed from jbp-server-exts to main June 23, 2025 15:09
@ctz ctz force-pushed the jbp-extension-repr-2 branch from d0b3433 to 8410541 Compare June 23, 2025 15:12
@ctz ctz enabled auto-merge June 23, 2025 15:25
@ctz ctz added this pull request to the merge queue Jun 23, 2025
@ctz ctz mentioned this pull request Jun 23, 2025
Closed
Merged via the queue into main with commit 4f362ca Jun 23, 2025
34 checks passed
@ctz ctz deleted the jbp-extension-repr-2 branch June 23, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu