Skip to content

Rework representation of extensions in server messages #2508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 23, 2025
Merged

Rework representation of extensions in server messages #2508

merged 6 commits into from
Jun 23, 2025

Conversation

ctz
Copy link
Member

@ctz ctz commented Jun 20, 2025

This follows on from #2502, and applies similar changes to messages sent by TLS servers.

See #1475 for more background and prior discussion.

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Jun 20, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_1.3_no_crypto_server 2061209 2104505 ⚠️ 43296 (2.10%) 0.20%
handshake_session_id_1.3_no_crypto_server 2097085 2140584 ⚠️ 43499 (2.07%) 0.20%
handshake_session_id_1.3_no_crypto_client 2215651 2248948 ⚠️ 33297 (1.50%) 0.20%
handshake_tickets_1.3_no_crypto_client 2234146 2267498 ⚠️ 33352 (1.49%) 0.20%
handshake_no_resume_1.3_no_crypto_server 98086 99200 ⚠️ 1114 (1.14%) 0.20%
handshake_session_id_1.2_no_crypto_server 1043395 1052991 ⚠️ 9596 (0.92%) 0.20%
handshake_tickets_1.2_no_crypto_client 1250090 1241534 ✅ -8556 (-0.68%) 0.20%
handshake_tickets_1.2_no_crypto_server 1206195 1214171 ⚠️ 7976 (0.66%) 0.20%
handshake_no_resume_1.3_no_crypto_client 111550 112144 ⚠️ 594 (0.53%) 0.20%
handshake_no_resume_1.2_no_crypto_client 99076 98616 ✅ -460 (-0.46%) 0.20%
handshake_no_resume_1.2_no_crypto_server 74910 75160 ⚠️ 250 (0.33%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3740404 3750291 ⚠️ 9887 (0.26%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4148510 4158980 ⚠️ 10470 (0.25%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4174698 4165411 ✅ -9287 (-0.22%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11301116 11374739 73623 (0.65%) 0.83%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10459809 10421638 -38171 (-0.36%) 0.81%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 64592071 64728233 136162 (0.21%) 0.57%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 64443790 64313079 -130711 (-0.20%) 0.26%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 64725321 64597421 -127900 (-0.20%) 0.52%
handshake_tickets_ring_1.2_rsa_aes_client 4502931 4494161 -8770 (-0.19%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 49384206 49479557 95351 (0.19%) 0.38%
handshake_tickets_ring_1.2_rsa_aes_server 4605091 4613938 8847 (0.19%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 64559895 64669562 109667 (0.17%) 0.50%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4877124 4885348 8224 (0.17%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 48031540 48108452 76912 (0.16%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 64389527 64486541 97014 (0.15%) 0.22%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 48085063 48156124 71061 (0.15%) 0.52%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 48136369 48206462 70093 (0.15%) 0.50%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 49341917 49411839 69922 (0.14%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31726411 31771233 44822 (0.14%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31727893 31772692 44799 (0.14%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 31848391 31893213 44822 (0.14%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31728295 31772926 44631 (0.14%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 31849873 31894672 44799 (0.14%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 31850275 31894906 44631 (0.14%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32184337 32229147 44810 (0.14%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32286577 32331387 44810 (0.14%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32185696 32230331 44635 (0.14%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32185756 32230316 44560 (0.14%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32287936 32332571 44635 (0.14%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32287996 32332556 44560 (0.14%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 49412916 49480658 67742 (0.14%) 0.42%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 64377008 64463716 86708 (0.13%) 0.59%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 64486307 64571071 84764 (0.13%) 0.60%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9525296 9513301 -11995 (-0.13%) 0.92%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 64646389 64726230 79841 (0.12%) 0.64%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 64694494 64616531 -77963 (-0.12%) 0.26%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9517508 9506765 -10743 (-0.11%) 0.61%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30765296 30798910 33614 (0.11%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30856976 30890590 33614 (0.11%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30769504 30802804 33300 (0.11%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30762546 30795821 33275 (0.11%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30861184 30894484 33300 (0.11%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30854196 30887471 33275 (0.11%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31082137 31115551 33414 (0.11%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31153747 31187161 33414 (0.11%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31089225 31122537 33312 (0.11%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31085194 31118464 33270 (0.11%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31160873 31194192 33319 (0.11%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31156842 31190119 33277 (0.11%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4275465 4279910 4445 (0.10%) 0.26%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 48087801 48134585 46784 (0.10%) 0.42%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1763082 1764746 1664 (0.09%) 0.20%
handshake_session_id_1.2_no_crypto_client 1154958 1153890 -1068 (-0.09%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11323870 11333958 10088 (0.09%) 1.45%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1289976 1291106 1130 (0.09%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1291148 1292278 1130 (0.09%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 48066616 48028963 -37653 (-0.08%) 0.21%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3302438 3304969 2531 (0.08%) 0.50%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1761268 1762577 1309 (0.07%) 1.22%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 49422916 49386531 -36385 (-0.07%) 0.36%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 64404843 64441653 36810 (0.06%) 0.63%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3835009 3833117 -1892 (-0.05%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2666538 2667777 1239 (0.05%) 0.33%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2669317 2670552 1235 (0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 48034051 48054634 20583 (0.04%) 0.33%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 49459165 49479639 20474 (0.04%) 0.55%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3113177 3114189 1012 (0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1718105 1717608 -497 (-0.03%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4242069 4240866 -1203 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 49399248 49387392 -11856 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 64372386 64358123 -14263 (-0.02%) 0.29%
handshake_no_resume_ring_1.2_rsa_aes_client 2243626 2243163 -463 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 64761185 64748417 -12768 (-0.02%) 0.57%
transfer_no_resume_ring_1.2_rsa_aes_server 45917925 45926894 8969 (0.02%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46013170 46022132 8962 (0.02%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46003292 46012252 8960 (0.02%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46010599 46019559 8960 (0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46124480 46133441 8961 (0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46176180 46185140 8960 (0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46176464 46185423 8959 (0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46186560 46195520 8960 (0.02%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2330559 2330971 412 (0.02%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2336210 2336622 412 (0.02%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7215591 7216740 1149 (0.02%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7213639 7214769 1130 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4277132 4277714 582 (0.01%) 1.01%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3303461 3303849 388 (0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80238173 80247135 8962 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80245478 80254439 8961 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80249967 80258928 8961 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80356945 80365908 8963 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80356017 80364977 8960 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80367047 80375997 8950 (0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11113557 11114687 1130 (0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11119320 11120450 1130 (0.01%) 0.20%
transfer_no_resume_1.2_no_crypto_server 104985039 104993999 8960 (0.01%) 0.20%
transfer_no_resume_1.3_no_crypto_server 105032245 105041202 8957 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 57997360 57994746 -2614 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58008180 58005574 -2606 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58005207 58002606 -2601 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58112279 58109674 -2605 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58122245 58119641 -2604 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58116983 58114382 -2601 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92523440 92520825 -2615 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92532572 92529958 -2614 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92572446 92569832 -2614 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92582401 92579796 -2605 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92534263 92531663 -2600 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92578427 92575832 -2595 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10987522 10987799 277 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3107450 3107377 -73 (-0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_client 117344465 117341865 -2600 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58058028 58056747 -1281 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57901998 57900726 -1272 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34734974 34735415 441 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34733270 34733685 415 (0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_client 117295948 117294665 -1283 (-0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_1.2_no_crypto 79.21 µs 76.47 µs -2.74 µs (-3.46%) 5.00%
handshake_session_id_1.3_no_crypto 644.82 µs 660.85 µs 16.03 µs (2.49%) 5.00%
handshake_no_resume_1.3_no_crypto 87.67 µs 85.51 µs -2.16 µs (-2.46%) 5.00%
handshake_tickets_1.3_no_crypto 628.09 µs 643.28 µs 15.18 µs (2.42%) 5.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.60 ms 4.54 ms -0.05 ms (-1.15%) 8.72%
transfer_no_resume_ring_1.3_rsa_aes 5.85 ms 5.79 ms -0.06 ms (-0.99%) 6.20%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.35 ms 5.30 ms -0.05 ms (-0.99%) 6.87%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.28 ms 5.23 ms -0.05 ms (-0.95%) 7.33%
transfer_no_resume_1.3_no_crypto 11.76 ms 11.87 ms 0.11 ms (0.90%) 5.00%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.03 ms 4.99 ms -0.04 ms (-0.87%) 6.99%
handshake_tickets_1.2_no_crypto 378.44 µs 381.69 µs 3.25 µs (0.86%) 5.00%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.74 ms 1.76 ms 0.01 ms (0.83%) 4.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.24 ms 5.20 ms -0.04 ms (-0.81%) 7.18%
transfer_no_resume_ring_1.2_rsa_aes 5.77 ms 5.72 ms -0.05 ms (-0.81%) 5.84%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.45 ms 8.40 ms -0.05 ms (-0.65%) 4.56%
handshake_tickets_ring_1.2_rsa_aes 1.55 ms 1.56 ms 0.01 ms (0.64%) 1.13%
handshake_no_resume_ring_1.3_ecdsap256_chacha 457.80 µs 454.92 µs -2.88 µs (-0.63%) 3.94%
handshake_no_resume_ring_1.3_ecdsap256_aes 461.60 µs 458.70 µs -2.89 µs (-0.63%) 3.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 9.10 ms 9.16 ms 0.05 ms (0.59%) 3.15%
transfer_no_resume_1.2_no_crypto 11.73 ms 11.67 ms -0.07 ms (-0.57%) 5.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 8.43 ms 8.48 ms 0.05 ms (0.57%) 3.48%
handshake_tickets_ring_1.3_rsa_aes 5.98 ms 6.02 ms 0.03 ms (0.56%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.46 ms 5.49 ms 0.03 ms (0.54%) 1.41%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 9.06 ms 9.11 ms 0.05 ms (0.53%) 2.77%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 9.07 ms 9.11 ms 0.05 ms (0.53%) 3.32%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 8.39 ms 8.43 ms 0.04 ms (0.52%) 3.12%
handshake_tickets_ring_1.3_ecdsap256_aes 5.50 ms 5.52 ms 0.03 ms (0.51%) 1.19%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 9.24 ms 9.29 ms 0.05 ms (0.50%) 2.84%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.23 ms 1.24 ms 0.01 ms (0.49%) 9.08%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.06 ms 1.06 ms 0.00 ms (0.47%) 7.52%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 579.96 µs 577.25 µs -2.71 µs (-0.47%) 3.24%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.22 ms 1.23 ms 0.01 ms (0.46%) 6.40%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.07 ms 13.01 ms -0.06 ms (-0.45%) 2.87%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 9.27 ms 9.31 ms 0.04 ms (0.45%) 3.17%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.91 ms 12.86 ms -0.06 ms (-0.45%) 2.68%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 9.25 ms 9.29 ms 0.04 ms (0.45%) 2.64%
handshake_no_resume_ring_1.2_rsa_aes 944.47 µs 940.37 µs -4.09 µs (-0.43%) 1.17%
handshake_tickets_ring_1.3_rsa_chacha 5.95 ms 5.98 ms 0.03 ms (0.42%) 1.26%
transfer_no_resume_ring_1.3_rsa_chacha 13.40 ms 13.35 ms -0.06 ms (-0.42%) 2.74%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.59 ms 1.59 ms 0.01 ms (0.41%) 4.59%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 9.12 ms 9.16 ms 0.04 ms (0.41%) 3.28%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 8.58 ms 8.61 ms 0.03 ms (0.40%) 2.98%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.41 ms 5.43 ms 0.02 ms (0.39%) 1.79%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.55 ms 8.59 ms 0.03 ms (0.36%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 8.61 ms 8.64 ms 0.03 ms (0.36%) 3.28%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.01 ms 15.95 ms -0.06 ms (-0.36%) 2.29%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.74 ms 13.69 ms -0.05 ms (-0.35%) 2.85%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 581.77 µs 579.71 µs -2.06 µs (-0.35%) 3.60%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.72 ms 13.67 ms -0.04 ms (-0.32%) 2.73%
handshake_tickets_ring_1.3_ecdsap384_aes 8.59 ms 8.62 ms 0.03 ms (0.32%) 1.00%
handshake_session_id_1.2_no_crypto 349.30 µs 350.41 µs 1.11 µs (0.32%) 5.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 9.30 ms 9.33 ms 0.03 ms (0.29%) 2.98%
handshake_no_resume_ring_1.3_rsa_chacha 949.06 µs 946.61 µs -2.45 µs (-0.26%) 1.82%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.50 ms 8.52 ms 0.02 ms (0.24%) 1.29%
handshake_no_resume_ring_1.3_rsa_aes 949.27 µs 947.27 µs -2.00 µs (-0.21%) 1.65%
handshake_session_id_ring_1.3_rsa_chacha 5.90 ms 5.91 ms 0.01 ms (0.20%) 1.49%
handshake_session_id_ring_1.3_rsa_aes 5.94 ms 5.95 ms 0.01 ms (0.17%) 1.06%
handshake_session_id_ring_1.3_ecdsap256_aes 5.44 ms 5.45 ms 0.01 ms (0.17%) 1.29%
handshake_session_id_ring_1.3_ecdsap384_aes 8.53 ms 8.55 ms 0.01 ms (0.15%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.26 ms 1.26 ms 0.00 ms (0.09%) 1.77%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.25 ms 1.25 ms -0.00 ms (-0.06%) 1.39%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.55 ms 3.55 ms 0.00 ms (0.01%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.48 ms 1.48 ms -0.00 ms (-0.00%) 1.17%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.55 ms 3.55 ms 0.00 ms (0.00%) 1.00%

Additional information

Historical results

Checkout details:

@ctz ctz force-pushed the jbp-server-exts branch from 4b4c296 to 5d187de Compare June 20, 2025 08:43
@codecov Codecov
Copy link

codecov bot commented Jun 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.25490% with 14 lines in your changes missing coverage. Please review.

Project coverage is 95.29%. Comparing base (54100be) to head (a0523f1).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
rustls/src/msgs/handshake.rs 96.80% 6 Missing ⚠️
rustls/src/msgs/macros.rs 85.00% 3 Missing ⚠️
rustls/src/server/hs.rs 93.54% 2 Missing ⚠️
rustls/src/client/tls13.rs 98.36% 1 Missing ⚠️
rustls/src/quic.rs 80.00% 1 Missing ⚠️
rustls/src/server/server_conn.rs 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2508      +/-   ##
==========================================
- Coverage   95.33%   95.29%   -0.04%     
==========================================
  Files          97       97              
  Lines       21768    21470     -298     
==========================================
- Hits        20752    20460     -292     
+ Misses       1016     1010       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This was referenced Jun 20, 2025
Merged
Merged
cpu
cpu reviewed Jun 20, 2025
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lost steam before making it through to the end of this but here's a couple initial comments.

@ctz ctz force-pushed the jbp-server-exts branch from 5d187de to 93c6c61 Compare June 23, 2025 08:18
@ctz ctz force-pushed the jbp-client-hello-exts branch from 6130e46 to f04d7b5 Compare June 23, 2025 11:22
Base automatically changed from jbp-client-hello-exts to main June 23, 2025 11:54
@ctz ctz force-pushed the jbp-server-exts branch from 93c6c61 to 1bd5dbe Compare June 23, 2025 12:00
djc
djc approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

How are you feeling about the Deref/DerefMut impls?

ctz added 2 commits June 23, 2025 14:02
@ctz
Move to new extensions repr for HRR
4214fb0 
Annoyingly, ECH server confirmation requires that this can be
round tripped.  Record the decoded order and prefer to encode
in that order.
@ctz
Move to new extensions repr for TLS1.3 certs
c461e1f
@ctz ctz force-pushed the jbp-server-exts branch from 1bd5dbe to a63cb5d Compare June 23, 2025 13:05
cpu
cpu approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@ctz ctz force-pushed the jbp-server-exts branch from a63cb5d to a0523f1 Compare June 23, 2025 14:29
@ctz ctz added this pull request to the merge queue Jun 23, 2025
Merged via the queue into main with commit 692f981 Jun 23, 2025
34 checks passed
@ctz ctz deleted the jbp-server-exts branch June 23, 2025 15:09
@ctz ctz mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu