Skip to content

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Nov 30, 2021

6 commits in 7f08ace4f1305de7f3b1b0e2f765911957226bd4..294967c53f0c70d598fc54ca189313c86c576ea7
2021-11-24 17:54:39 +0000 to 2021-11-29 19:04:22 +0000

@ehuss ehuss self-assigned this Nov 30, 2021
@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 30, 2021
@ehuss
Copy link
Contributor Author

ehuss commented Nov 30, 2021

@bors r+ p=5

@bors
Copy link
Collaborator

bors commented Nov 30, 2021

📌 Commit 05461d3 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2021
@bors
Copy link
Collaborator

bors commented Nov 30, 2021

⌛ Testing commit 05461d3 with merge 4c94896...

@bors
Copy link
Collaborator

bors commented Nov 30, 2021

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 4c94896 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 30, 2021
@bors bors merged commit 4c94896 into rust-lang:master Nov 30, 2021
@rustbot rustbot added this to the 1.59.0 milestone Nov 30, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4c94896): comparison url.

Summary: This change led to very large relevant improvements 🎉 in compiler performance.

  • Very large improvement in instruction counts (up to -5.8% on incr-unchanged builds of inflate)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants