Skip to content

Conversation

matklad
Copy link
Contributor

@matklad matklad commented Nov 26, 2021

No description provided.

@@ -4,3 +4,4 @@ author = "Alex Crichton, Steve Klabnik and Carol Nichols, with Contributions fro

[output.html]
git-repository-url = "https://github.com/rust-lang/cargo/tree/master/src/doc/src"
edit-url-template = "https://github.com/rust-lang/cargo/tree/master/src/doc/src/{path}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the path is relative to the book root.

Suggested change
edit-url-template = "https://github.com/rust-lang/cargo/tree/master/src/doc/src/{path}"
edit-url-template = "https://github.com/rust-lang/cargo/tree/master/src/doc/{path}"

Also, is there a particular reason you chose to not go to the edit link? (Not that I have a strong preference, but that was the intended way to use this.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, just missed that!

@ehuss
Copy link
Contributor

ehuss commented Nov 28, 2021

Thanks! I'm slightly concerned about receiving low-quality PRs with this, but hopefully it will result in more fixes instead.

@bors r+

@bors
Copy link
Contributor

bors commented Nov 28, 2021

📌 Commit 3028bba has been approved by ehuss

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 28, 2021
@bors
Copy link
Contributor

bors commented Nov 28, 2021

⌛ Testing commit 3028bba with merge 8032ac5...

@bors
Copy link
Contributor

bors commented Nov 28, 2021

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 8032ac5 to master...

@bors bors merged commit 8032ac5 into rust-lang:master Nov 28, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 30, 2021
Update cargo

6 commits in 7f08ace4f1305de7f3b1b0e2f765911957226bd4..294967c53f0c70d598fc54ca189313c86c576ea7
2021-11-24 17:54:39 +0000 to 2021-11-29 19:04:22 +0000
- Fix some tests with output collisions. (rust-lang/cargo#10137)
- Description of the targets that can be applied (rust-lang/cargo#10109)
- Improve unused patch message when source URLs mismatched (rust-lang/cargo#10130)
- Add a note about doctest xcompile. (rust-lang/cargo#10132)
- book: add edit links to specific pages (rust-lang/cargo#10124)
- Add crate type flag to rustc command (rust-lang/cargo#10093)
@ehuss ehuss added this to the 1.59.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants