Skip to content

Conversation

bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented Jul 5, 2025

Fixes #140796

r? compiler

cc @Zoxc

@rustbot
Copy link
Collaborator

rustbot commented Jul 5, 2025

Failed to set assignee to Zoxc: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 5, 2025
@Zoxc
Copy link
Contributor

Zoxc commented Jul 5, 2025

That looks reasonable. I'd check if a similar issue can occur with impl too.

@compiler-errors
Copy link
Member

r? compiler-errors

Yeah, could you please check if this can be reproduced with impls too. Otherwise r=me

@bors delegate+

@bors
Copy link
Collaborator

bors commented Jul 5, 2025

✌️ @bvanjoi, you can now approve this pull request!

If @compiler-errors told you to "r=me" after making some further change, please make that change, then do @bors r=@compiler-errors

@rustbot rustbot unassigned lcnr Jul 5, 2025
@bvanjoi
Copy link
Contributor Author

bvanjoi commented Jul 6, 2025

I've added the corresponding test case.

@bvanjoi
Copy link
Contributor Author

bvanjoi commented Jul 6, 2025

CI is green, so @bors r=@compiler-errors

@bors
Copy link
Collaborator

bors commented Jul 6, 2025

📌 Commit 5bbab89 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2025
bors added a commit that referenced this pull request Jul 6, 2025
Rollup of 6 pull requests

Successful merges:

 - #143416 (mbe: Defer checks for `compile_error!` until reporting an unused macro rule)
 - #143470 (std: sys: net: uefi: tcp4: Implement read)
 - #143477 (use `is_multiple_of` and `div_ceil`)
 - #143484 (distinguish the duplicate item of rpitit)
 - #143493 (tidy: use --bless for tidy spellcheck instead of spellcheck:fix)
 - #143504 (compiletest: print slightly more information on fs::write failure)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 534c09a into rust-lang:master Jul 6, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 6, 2025
rust-timer added a commit that referenced this pull request Jul 6, 2025
Rollup merge of #143484 - bvanjoi:issue-140796, r=compiler-errors

distinguish the duplicate item of rpitit

Fixes #140796

r? compiler

cc `@Zoxc`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE / Hang found DefPathHash collision between DefPath
6 participants