Skip to content

Pre-install JS dependencies in tidy Dockerfile #142434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2025
Merged

Pre-install JS dependencies in tidy Dockerfile #142434

merged 1 commit into from
Jun 14, 2025

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Jun 12, 2025 •
edited by marcoieni
Loading

Also fixes passing TIDY_PRINT_DIFF to tidy, which has been passed to npm install rather than to tidy after the latest change here.

r? @GuillaumeGomez

Fixes: #142433

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 12, 2025
@Kobzol Kobzol mentioned this pull request Jun 12, 2025
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kobzol Kobzol force-pushed the preinstall-eslint branch from cc9ce82 to fff4973 Compare June 12, 2025 18:43
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@workingjubilee
Copy link
Member

hilarious.

@workingjubilee workingjubilee added A-CI Area: Our Github Actions CI CI-spurious-fail-npm we forgot to cache our installs from npm labels Jun 12, 2025
@Kobzol Kobzol force-pushed the preinstall-eslint branch from fff4973 to 0aa5535 Compare June 13, 2025 04:54
@Kobzol Kobzol changed the title Pre-install eslint in mingw-check-tidy Dockerfile Pre-install JS dependencies in Dockerfiles Jun 13, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kobzol Kobzol force-pushed the preinstall-eslint branch from 0aa5535 to 9d642fe Compare June 13, 2025 06:13
@Kobzol Kobzol changed the title Pre-install JS dependencies in Dockerfiles Pre-install JS dependencies in tidy Dockerfile Jun 13, 2025
@Kobzol
Copy link
Member Author

Kobzol commented Jun 13, 2025

r? @marcoieni

@rustbot rustbot assigned marcoieni and unassigned GuillaumeGomez Jun 13, 2025
@marcoieni
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 13, 2025

📌 Commit 9d642fe has been approved by marcoieni

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2025
@workingjubilee workingjubilee mentioned this pull request Jun 14, 2025
Merged
bors added a commit that referenced this pull request Jun 14, 2025
@bors
Auto merge of #142483 - workingjubilee:rollup-8qnhueh, r=workingjubilee
64033a4 
Rollup of 16 pull requests

Successful merges:

 - #140969 (Allow initializing logger with additional tracing Layer)
 - #141352 (builtin dyn impl no guide inference)
 - #142046 (add Vec::peek_mut)
 - #142273 (tests: Minicore `extern "gpu-kernel"` feature test)
 - #142302 (Rework how the disallowed qualifier in function type diagnostics are generated)
 - #142405 (Don't hardcode the intrinsic return types twice in the compiler)
 - #142434 ( Pre-install JS dependencies in tidy Dockerfile)
 - #142439 (doc: mention that intrinsics should not be called in user code)
 - #142441 (Delay replacing escaping bound vars in `FindParamInClause`)
 - #142449 (Require generic params for const generic params)
 - #142452 (Remove "intermittent" wording from `ReadDir`)
 - #142459 (Remove output helper bootstrap)
 - #142460 (cleanup search graph impl)
 - #142461 (compiletest: Clarify that `--no-capture` is needed with `--verbose`)
 - #142475 (Add platform support docs & maintainers for *-windows-msvc)
 - #142480 (tests: Convert two handwritten minicores to add-core-stubs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fa359f6 into rust-lang:master Jun 14, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 14, 2025
rust-timer added a commit that referenced this pull request Jun 14, 2025
@rust-timer
Unrolled build for #142434
575d232 
Rollup merge of #142434 - Kobzol:preinstall-eslint, r=marcoieni

 Pre-install JS dependencies in tidy Dockerfile

Also fixes passing `TIDY_PRINT_DIFF` to tidy, which has been passed to `npm install` rather than to tidy after the latest change here.

r? `@GuillaumeGomez`

Fixes: #142433
@Kobzol Kobzol deleted the preinstall-eslint branch June 14, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marcoieni marcoieni

Labels
A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc CI-spurious-fail-npm we forgot to cache our installs from npm S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.

npm GETs in CI can be flaky, can we cache them?
7 participants
@Kobzol @rust-log-analyzer @workingjubilee @marcoieni @bors @GuillaumeGomez @rustbot