avoid `&mut P<T>` in `visit_expr` etc methods #142371

fee1-dead · 2025-06-11T16:03:59Z

trying a different way than #141636
r? ghost

fee1-dead · 2025-06-11T16:04:57Z

@bors try @rust-timer queue

[experiment] avoid `P<T>` in `visit_expr` etc methods trying a different way than #141636 r? ghost

bors · 2025-06-11T16:06:09Z

⌛ Trying commit acf4046 with merge c2996b4...

bors · 2025-06-11T18:33:54Z

☀️ Try build successful - checks-actions
Build commit: c2996b4 (c2996b4a102c36e4be0fce51b8ef97d407a3a080)

rust-timer · 2025-06-12T09:12:49Z

Finished benchmarking commit (c2996b4): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.0%	[1.0%, 1.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.1%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.5%	[-2.5%, -2.5%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 755.487s -> 754.164s (-0.18%)
Artifact size: 372.14 MiB -> 372.12 MiB (-0.00%)

rustbot · 2025-06-12T09:40:42Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

petrochenkov · 2025-06-16T14:40:39Z

@bors r+ rollup=maybe

bors · 2025-06-16T14:40:42Z

📌 Commit 5f0dd44 has been approved by petrochenkov

It is now in the queue for this repository.

…s, r=petrochenkov avoid `&mut P<T>` in `visit_expr` etc methods trying a different way than rust-lang#141636 r? ghost

Rollup of 10 pull requests Successful merges: - #138538 (Make performance description of String::{insert,insert_str,remove} more precise) - #141946 (std: refactor explanation of `NonNull`) - #142216 (Miscellaneous RefCell cleanups) - #142371 (avoid `&mut P<T>` in `visit_expr` etc methods) - #142377 (Try unremapping compiler sources) - #142517 (Windows: Use anonymous pipes in Command) - #142542 (Manually invalidate caches in SimplifyCfg.) - #142563 (Refine run-make test ignores due to unpredictable `i686-pc-windows-gnu` unwind mechanism) - #142570 (Reject union default field values) - #142584 (Handle same-crate macro for borrowck semicolon suggestion) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 10 pull requests Successful merges: - #138538 (Make performance description of String::{insert,insert_str,remove} more precise) - #141946 (std: refactor explanation of `NonNull`) - #142216 (Miscellaneous RefCell cleanups) - #142371 (avoid `&mut P<T>` in `visit_expr` etc methods) - #142377 (Try unremapping compiler sources) - #142517 (Windows: Use anonymous pipes in Command) - #142542 (Manually invalidate caches in SimplifyCfg.) - #142563 (Refine run-make test ignores due to unpredictable `i686-pc-windows-gnu` unwind mechanism) - #142570 (Reject union default field values) - #142584 (Handle same-crate macro for borrowck semicolon suggestion) r? `@ghost` `@rustbot` modify labels: rollup  [Create a similar rollup](https://bors.rust-lang.org/queue/rust?prs=138538,141946,142216,142371,142377,142517,142542,142563,142570,142584)  try-job: dist-aarch64-apple

Rollup of 14 pull requests Successful merges: - #141574 (impl `Default` for `array::IntoIter`) - #141608 (Add support for repetition to `proc_macro::quote`) - #142100 (rustdoc: make srcIndex no longer a global variable) - #142371 (avoid `&mut P<T>` in `visit_expr` etc methods) - #142517 (Windows: Use anonymous pipes in Command) - #142520 (alloc: less static mut + some cleanup) - #142588 (Generic ctx imprv) - #142605 (Don't unwrap in enzyme builds in case of missing llvm-config) - #142608 (Refresh module-level docs for `rustc_target::spec`) - #142618 (Lint about `console` calls in rustdoc JS) - #142620 (Remove a panicking branch in `BorrowedCursor::advance`) - #142631 (Dont suggest remove semi inside macro expansion for redundant semi lint) - #142632 (Update cargo) - #142635 (Temporarily add back -Zwasm-c-abi=spec) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #142371 - fee1-dead-contrib:push-xqlkumzurkus, r=petrochenkov avoid `&mut P<T>` in `visit_expr` etc methods trying a different way than #141636 r? ghost

Rollup of 14 pull requests Successful merges: - rust-lang/rust#141574 (impl `Default` for `array::IntoIter`) - rust-lang/rust#141608 (Add support for repetition to `proc_macro::quote`) - rust-lang/rust#142100 (rustdoc: make srcIndex no longer a global variable) - rust-lang/rust#142371 (avoid `&mut P<T>` in `visit_expr` etc methods) - rust-lang/rust#142517 (Windows: Use anonymous pipes in Command) - rust-lang/rust#142520 (alloc: less static mut + some cleanup) - rust-lang/rust#142588 (Generic ctx imprv) - rust-lang/rust#142605 (Don't unwrap in enzyme builds in case of missing llvm-config) - rust-lang/rust#142608 (Refresh module-level docs for `rustc_target::spec`) - rust-lang/rust#142618 (Lint about `console` calls in rustdoc JS) - rust-lang/rust#142620 (Remove a panicking branch in `BorrowedCursor::advance`) - rust-lang/rust#142631 (Dont suggest remove semi inside macro expansion for redundant semi lint) - rust-lang/rust#142632 (Update cargo) - rust-lang/rust#142635 (Temporarily add back -Zwasm-c-abi=spec) r? `@ghost` `@rustbot` modify labels: rollup

…s, r=petrochenkov avoid `&mut P<T>` in `visit_expr` etc methods trying a different way than rust-lang#141636 r? ghost

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 11, 2025

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 11, 2025

bors added a commit that referenced this pull request Jun 11, 2025

Auto merge of #142371 - fee1-dead-contrib:push-xqlkumzurkus, r=<try>

c2996b4

[experiment] avoid `P<T>` in `visit_expr` etc methods trying a different way than #141636 r? ghost

petrochenkov self-assigned this Jun 11, 2025

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 12, 2025

petrochenkov added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 12, 2025

avoid &mut P<T> in visit_expr etc methods

5f0dd44

fee1-dead force-pushed the push-xqlkumzurkus branch from acf4046 to 5f0dd44 Compare June 12, 2025 09:36

fee1-dead changed the title ~~[experiment] avoid P<T> in visit_expr etc methods~~ avoid &mut P<T> in visit_expr etc methods Jun 12, 2025

fee1-dead marked this pull request as ready for review June 12, 2025 09:40

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 12, 2025

fee1-dead removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 12, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2025

workingjubilee mentioned this pull request Jun 17, 2025

Rollup of 10 pull requests #142614

Closed

jhpratt mentioned this pull request Jun 17, 2025

Rollup of 14 pull requests #142644

Merged

bors merged commit e95fb09 into rust-lang:master Jun 18, 2025
10 checks passed

rustbot added this to the 1.89.0 milestone Jun 18, 2025

rust-timer added a commit that referenced this pull request Jun 18, 2025

Unrolled build for #142371

3f9068f

Rollup merge of #142371 - fee1-dead-contrib:push-xqlkumzurkus, r=petrochenkov avoid `&mut P<T>` in `visit_expr` etc methods trying a different way than #141636 r? ghost

fee1-dead deleted the push-xqlkumzurkus branch June 18, 2025 04:37

fee1-dead mentioned this pull request Jun 19, 2025

ast::mut_visit::MutVisitor and ast::visit::Visitor do not have corresponding methods for all their methods #127615

Closed

5 tasks

flip1995 pushed a commit to flip1995/rust that referenced this pull request Jun 26, 2025

Rollup merge of rust-lang#142371 - fee1-dead-contrib:push-xqlkumzurku…

4b60d49

…s, r=petrochenkov avoid `&mut P<T>` in `visit_expr` etc methods trying a different way than rust-lang#141636 r? ghost

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

avoid `&mut P<T>` in `visit_expr` etc methods #142371

avoid `&mut P<T>` in `visit_expr` etc methods #142371

Uh oh!

fee1-dead commented Jun 11, 2025 •

edited by rustbot

Loading

Uh oh!

fee1-dead commented Jun 11, 2025

Uh oh!

This comment has been minimized.

bors commented Jun 11, 2025

Uh oh!

This comment has been minimized.

bors commented Jun 11, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jun 12, 2025

Uh oh!

rustbot commented Jun 12, 2025

Uh oh!

petrochenkov commented Jun 16, 2025

Uh oh!

bors commented Jun 16, 2025

Uh oh!

Uh oh!

Uh oh!

avoid &mut P<T> in visit_expr etc methods #142371

avoid &mut P<T> in visit_expr etc methods #142371

Uh oh!

Conversation

fee1-dead commented Jun 11, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fee1-dead commented Jun 11, 2025

Uh oh!

This comment has been minimized.

bors commented Jun 11, 2025

Uh oh!

This comment has been minimized.

bors commented Jun 11, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jun 12, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

rustbot commented Jun 12, 2025

Uh oh!

petrochenkov commented Jun 16, 2025

Uh oh!

bors commented Jun 16, 2025

Uh oh!

Uh oh!

Uh oh!

avoid `&mut P<T>` in `visit_expr` etc methods #142371

avoid `&mut P<T>` in `visit_expr` etc methods #142371

fee1-dead commented Jun 11, 2025 •

edited by rustbot

Loading