Skip to content

Conversation

psumbera
Copy link
Contributor

@psumbera psumbera commented Jun 6, 2025

this is follow up for: #138699

@rustbot
Copy link
Collaborator

rustbot commented Jun 6, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 6, 2025
@psumbera
Copy link
Contributor Author

psumbera commented Jun 6, 2025

r? @marcoieni

@rustbot rustbot assigned marcoieni and unassigned Mark-Simulacrum Jun 6, 2025
@marcoieni
Copy link
Member

marcoieni commented Jun 6, 2025

I would change the commit and PR title to "add solaris targets to build-manifest".

the rest looks good, although I'm not familiar with this part of the codebase. I will approve once you make this change 👍

@psumbera psumbera force-pushed the solaris-ci-build4 branch from 9d71ae5 to 523cf12 Compare June 6, 2025 10:09
@psumbera
Copy link
Contributor Author

psumbera commented Jun 6, 2025

I would change the commit and PR title to "add solaris targets to build-manifest".

the rest looks good, although I'm not familiar with this part of the codebase. I will approve once you make this change 👍

Fixed and ready to land.

@marcoieni marcoieni changed the title Solaris targets were missing from build-manifest Add solaris targets to build-manifest Jun 6, 2025
@marcoieni
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 6, 2025

📌 Commit 523cf12 has been approved by marcoieni

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 7, 2025
…oieni

Add solaris targets to build-manifest

this is follow up for: rust-lang#138699
bors added a commit that referenced this pull request Jun 7, 2025
Rollup of 8 pull requests

Successful merges:

 - #137992 (Stabilise `os_string_pathbuf_leak`)
 - #141558 (Limit the size of cgu names when using the `-Zhuman-readable-cgu-name…)
 - #141797 (compiler: set Apple frame pointers by architecture)
 - #141857 (coretests: move float tests from num to floats module and use a more flexible macro to generate them)
 - #142045 (Make obligation cause code suggestions verbose)
 - #142076 (Check documentation of bootstrap in PR CI)
 - #142110 (Add solaris targets to build-manifest)
 - #142131 (Make cast suggestions verbose)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6b4abb9 into rust-lang:master Jun 7, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 7, 2025
rust-timer added a commit that referenced this pull request Jun 7, 2025
Rollup merge of #142110 - psumbera:solaris-ci-build4, r=marcoieni

Add solaris targets to build-manifest

this is follow up for: #138699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants