Skip to content

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jun 2, 2025

This allows for testing these tests on editions other than 2015

@rustbot
Copy link
Collaborator

rustbot commented Jun 2, 2025

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 2, 2025
@rust-log-analyzer

This comment has been minimized.

Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after fixing CI

}

mod e {
pub use d::*; // n.b. Since `e::f` is not used, this is not considered to be a use of `d::f`.
pub use crate::d::*; // n.b. Since `e::f` is not used, this is not considered to be a use of `d::f`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrap this line pls

@Veykril Veykril force-pushed the lw/decouple-tests-from-2015 branch from 55c32c9 to ed4a781 Compare June 3, 2025 07:12
@Veykril
Copy link
Member Author

Veykril commented Jun 3, 2025

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Jun 3, 2025

📌 Commit ed4a781 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2025
@Veykril Veykril closed this Jun 3, 2025
@Veykril Veykril deleted the lw/decouple-tests-from-2015 branch June 3, 2025 07:45
@Veykril Veykril restored the lw/decouple-tests-from-2015 branch June 3, 2025 07:52
@Veykril
Copy link
Member Author

Veykril commented Jun 3, 2025

Whoops, deleted a wrong branch, sorry

@rust-log-analyzer

This comment has been minimized.

@Veykril Veykril reopened this Jun 3, 2025
…tion

This allows for testing these tests on editions other than 2015
@Veykril Veykril force-pushed the lw/decouple-tests-from-2015 branch from ed4a781 to 23d5231 Compare June 3, 2025 08:14
@Veykril
Copy link
Member Author

Veykril commented Jun 3, 2025

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Jun 3, 2025

📌 Commit 23d5231 has been approved by compiler-errors

It is now in the queue for this repository.

@lcnr lcnr assigned compiler-errors and unassigned lcnr Jun 3, 2025
chenyukang added a commit to chenyukang/rust that referenced this pull request Jun 4, 2025
…er-errors

Use non-2015 edition paths in tests that do not test for their resolution

This allows for testing these tests on editions other than 2015

Follow up to rust-lang#141888
rust-bors bot added a commit that referenced this pull request Jun 4, 2025
Use non-2015 edition paths in tests that do not test for their resolution

This allows for testing these tests on editions other than 2015

Follow up to #141888

try-job: i686-msvc-1
bors added a commit that referenced this pull request Jun 4, 2025
Rollup of 8 pull requests

Successful merges:

 - #136687 (Improve the documentation of `Display` and `FromStr`, and their interactions)
 - #137306 (Remove `i128` and `u128` from `improper_ctypes_definitions`)
 - #138699 (build dist for x86_64-pc-solaris and sparcv9-sun-solaris)
 - #141250 (add s390x z17 target features)
 - #141467 (make `OsString::new` and `PathBuf::new` unstably const)
 - #141871 (index: add method for checking range on DenseBitSet)
 - #141888 (Use non-2015 edition paths in tests that do not test for their resolution)
 - #142000 (bootstrap: don't symlink source dir into stage0 sysroot)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit add4bde into rust-lang:master Jun 4, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 4, 2025
rust-timer added a commit that referenced this pull request Jun 4, 2025
Rollup merge of #141888 - ferrocene:lw/decouple-tests-from-2015, r=compiler-errors

Use non-2015 edition paths in tests that do not test for their resolution

This allows for testing these tests on editions other than 2015
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 4, 2025
…er-errors

Use non-2015 edition paths in tests that do not test for their resolution

This allows for testing these tests on editions other than 2015

Follow up to rust-lang#141888
rust-timer added a commit that referenced this pull request Jun 5, 2025
Rollup merge of #141960 - ferrocene:lw/2015-paths2, r=compiler-errors

Use non-2015 edition paths in tests that do not test for their resolution

This allows for testing these tests on editions other than 2015

Follow up to #141888
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jun 5, 2025
Rollup of 8 pull requests

Successful merges:

 - rust-lang/rust#136687 (Improve the documentation of `Display` and `FromStr`, and their interactions)
 - rust-lang/rust#137306 (Remove `i128` and `u128` from `improper_ctypes_definitions`)
 - rust-lang/rust#138699 (build dist for x86_64-pc-solaris and sparcv9-sun-solaris)
 - rust-lang/rust#141250 (add s390x z17 target features)
 - rust-lang/rust#141467 (make `OsString::new` and `PathBuf::new` unstably const)
 - rust-lang/rust#141871 (index: add method for checking range on DenseBitSet)
 - rust-lang/rust#141888 (Use non-2015 edition paths in tests that do not test for their resolution)
 - rust-lang/rust#142000 (bootstrap: don't symlink source dir into stage0 sysroot)

r? `@ghost`
`@rustbot` modify labels: rollup
@Veykril Veykril deleted the lw/decouple-tests-from-2015 branch June 11, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants