Skip to content

Conversation

joshtriplett
Copy link
Member

We didn't previously have a blanket prohibition on trailing whitespace. Adding
one, inspired by discussion in #145617 .

@rustbot
Copy link
Collaborator

rustbot commented Aug 22, 2025

r? @yaahc

rustbot has assigned @yaahc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Aug 22, 2025

Some changes occurred in src/doc/style-guide

cc @rust-lang/style

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-style Relevant to the style team, which will review and decide on the PR/issue. labels Aug 22, 2025
@traviscross
Copy link
Contributor

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Aug 22, 2025

Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Aug 22, 2025
@rfcbot
Copy link

rfcbot commented Aug 22, 2025

🔔 This is now entering its final comment period, as per the review above. 🔔

@rust-rfcbot rust-rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Sep 1, 2025
@rust-rfcbot
Copy link
Collaborator

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@joshtriplett joshtriplett removed the to-announce Announce this issue on triage meeting label Sep 3, 2025
@joshtriplett
Copy link
Member Author

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 5, 2025

📌 Commit df324fa has been approved by joshtriplett

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2025
bors added a commit that referenced this pull request Sep 5, 2025
Rollup of 11 pull requests

Successful merges:

 - #138944 (Add `__isPlatformVersionAtLeast` and `__isOSVersionAtLeast` symbols)
 - #139113 (unstable book: in a sanitizer example, check the code)
 - #145735 (style-guide: Document absence of trailing whitespace)
 - #146041 (tidy: --bless now makes escheck run with --fix)
 - #146144 (compiler: Apply target features to the entry function)
 - #146225 (Simplify `{f16, f32, f64, f128}::midpoint()`)
 - #146234 (change file-is-generated doc comment to inner)
 - #146241 (rustc_infer: change top-level doc comment to inner)
 - #146242 (Ensure that `--html-after-content` option is used to check `scrape_examples_ice` rustdoc GUI test)
 - #146243 (remove couple of redundant clones)
 - #146250 (Bump stage0 rustfmt)

Failed merges:

 - #146200 (Simplify rustdoc-gui tester by calling directly browser-ui-test)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9edce86 into rust-lang:master Sep 5, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 5, 2025
rust-timer added a commit that referenced this pull request Sep 6, 2025
Rollup merge of #145735 - joshtriplett:style-guide-trailing-whitespace, r=joshtriplett

style-guide: Document absence of trailing whitespace

We didn't previously have a blanket prohibition on trailing whitespace. Adding
one, inspired by discussion in #145617 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-style Relevant to the style team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants