-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Rehome 30 tests/ui/issues/
tests to other subdirectories under tests/ui/
[#2 of Batch #2]
#145676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR modifies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, a few things
980eb71
to
ab08d6e
Compare
This comment has been minimized.
This comment has been minimized.
ab08d6e
to
ad63714
Compare
@rustbot ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the macro thing
@rustbot author |
Reminder, once the PR becomes ready for a review, use |
ad63714
to
8ed4050
Compare
@rustbot ready |
This comment has been minimized.
This comment has been minimized.
8ed4050
to
2dc4638
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bors r+ rollup |
Rollup of 4 pull requests Successful merges: - #145675 (Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#1 of Batch #2]) - #145676 (Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#2 of Batch #2]) - #145982 (compiletest: Reduce the number of `println!` calls that don't have access to `TestCx`) - #145984 (`TokenStream` cleanups) r? `@ghost` `@rustbot` modify labels: rollup
Rollup of 4 pull requests Successful merges: - #145675 (Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#1 of Batch #2]) - #145676 (Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#2 of Batch #2]) - #145982 (compiletest: Reduce the number of `println!` calls that don't have access to `TestCx`) - #145984 (`TokenStream` cleanups) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #145676 - Oneirical:uncountable-integer-9, r=jieyouxu Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#2 of Batch #2] Part of #133895 Methodology: 1. Refer to the previously written `tests/ui/SUMMARY.md` 2. Find an appropriate category for the test, using the original issue thread and the test contents. 3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers) 4. Rename the tests to make their purpose clearer Inspired by the methodology that `@Kivooeo` was using. r? `@jieyouxu`
Part of #133895
Methodology:
tests/ui/SUMMARY.md
Inspired by the methodology that @Kivooeo was using.
r? @jieyouxu