Skip to content

Conversation

Oneirical
Copy link
Contributor

Part of #133895

Methodology:

  1. Refer to the previously written tests/ui/SUMMARY.md
  2. Find an appropriate category for the test, using the original issue thread and the test contents.
  3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
  4. Rename the tests to make their purpose clearer

Inspired by the methodology that @Kivooeo was using.

r? @jieyouxu

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 20, 2025

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a few things

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2025
@Oneirical Oneirical force-pushed the uncountable-integer-9 branch from 980eb71 to ab08d6e Compare August 26, 2025 16:52
@rust-log-analyzer

This comment has been minimized.

@Oneirical Oneirical force-pushed the uncountable-integer-9 branch from ab08d6e to ad63714 Compare August 26, 2025 18:06
@Oneirical
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 26, 2025
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the macro thing

View changes since this review

@jieyouxu
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 27, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@Oneirical Oneirical force-pushed the uncountable-integer-9 branch from ad63714 to 8ed4050 Compare August 27, 2025 04:14
@Oneirical
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 27, 2025
@rust-log-analyzer

This comment has been minimized.

@Oneirical Oneirical force-pushed the uncountable-integer-9 branch from 8ed4050 to 2dc4638 Compare August 27, 2025 19:06
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 29, 2025

📌 Commit 2dc4638 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 29, 2025
bors added a commit that referenced this pull request Aug 29, 2025
Rollup of 4 pull requests

Successful merges:

 - #145675 (Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#1 of Batch #2])
 - #145676 (Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#2 of Batch #2])
 - #145982 (compiletest: Reduce the number of `println!` calls that don't have access to `TestCx`)
 - #145984 (`TokenStream` cleanups)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Aug 29, 2025
Rollup of 4 pull requests

Successful merges:

 - #145675 (Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#1 of Batch #2])
 - #145676 (Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#2 of Batch #2])
 - #145982 (compiletest: Reduce the number of `println!` calls that don't have access to `TestCx`)
 - #145984 (`TokenStream` cleanups)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 47f1df5 into rust-lang:master Aug 29, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 29, 2025
rust-timer added a commit that referenced this pull request Aug 29, 2025
Rollup merge of #145676 - Oneirical:uncountable-integer-9, r=jieyouxu

Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#2 of Batch #2]

Part of #133895

Methodology:

1. Refer to the previously written `tests/ui/SUMMARY.md`
2. Find an appropriate category for the test, using the original issue thread and the test contents.
3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
4. Rename the tests to make their purpose clearer

Inspired by the methodology that `@Kivooeo` was using.

r? `@jieyouxu`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants