Skip to content

NllRegionVariableOrigin remove from_forall #145091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2025
Merged

NllRegionVariableOrigin remove from_forall #145091

merged 1 commit into from
Aug 11, 2025
+15 −29

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Aug 8, 2025 •
edited by rustbot
Loading

See added comment in the only place it was used.

cc #144988 @amandasystems, going to merge that PR first.

@rustbot
Copy link
Collaborator

rustbot commented Aug 8, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 8, 2025
@lcnr lcnr mentioned this pull request Aug 8, 2025
Merged
@petrochenkov
Copy link
Contributor

r=me after landing #144988 and rebase.
@rustbot blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2025
@lcnr lcnr force-pushed the remove-from_forall branch from bb1c365 to e1e1385 Compare August 11, 2025 07:18
@lcnr
Copy link
Contributor Author

lcnr commented Aug 11, 2025

@bors r=petrochenkov rollup

@bors
Copy link
Collaborator

bors commented Aug 11, 2025

📌 Commit e1e1385 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Aug 11, 2025
@Zalathar Zalathar mentioned this pull request Aug 11, 2025
Merged
bors added a commit that referenced this pull request Aug 11, 2025
@bors
Auto merge of #145240 - Zalathar:rollup-7r97lia, r=Zalathar
5771665 
Rollup of 5 pull requests

Successful merges:

 - #135331 (Reject relaxed bounds inside associated type bounds (ATB))
 - #144156 (Check coroutine upvars in dtorck constraint)
 - #145091 (`NllRegionVariableOrigin` remove `from_forall`)
 - #145194 (Ignore coroutine witness type region args in auto trait confirmation)
 - #145225 (Fix macro infinite recursion test to not trigger warning about semicolon in expr)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit dbfded4 into rust-lang:master Aug 11, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 11, 2025
rust-timer added a commit that referenced this pull request Aug 11, 2025
@rust-timer
Unrolled build for #145091
b9e5ff5 
Rollup merge of #145091 - lcnr:remove-from_forall, r=petrochenkov

`NllRegionVariableOrigin` remove `from_forall`

See added comment in the only place it was used.

cc #144988 `@amandasystems,` going to merge that PR first.
@lcnr lcnr deleted the remove-from_forall branch August 11, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.91.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lcnr @rustbot @petrochenkov @bors