Skip to content

rename fn member_constraint to fn add_member_constraint #133909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

rename fn member_constraint to fn add_member_constraint #133909

wants to merge 1 commit into from

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Dec 5, 2024

also assert that we're not in a snapshot, closing #109654

r? types

@lcnr
fn member_constraint to add_member_constraint
82e1c2d 
also assert that we're not in a snapshot
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 5, 2024
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
   Compiling std v0.0.0 (/checkout/library/std)
   Compiling cc v1.2.0
   Compiling compiler_builtins v0.1.138
thread 'rustc' panicked at compiler/rustc_infer/src/infer/mod.rs:701:9:
assertion failed: !self.in_snapshot()
   0:     0x7f680ca256c1 - <<std[f727eb1ed3cbfa49]::sys::backtrace::BacktraceLock>::print::DisplayBacktrace as core[8e2c8c99b037a10c]::fmt::Display>::fmt
   1:     0x7f680ca825a3 - core[8e2c8c99b037a10c]::fmt::write
   2:     0x7f680ca19089 - <std[f727eb1ed3cbfa49]::sys::pal::unix::stdio::Stderr as std[f727eb1ed3cbfa49]::io::Write>::write_fmt
   3:     0x7f680ca25562 - <std[f727eb1ed3cbfa49]::sys::backtrace::BacktraceLock>::print
   3:     0x7f680ca25562 - <std[f727eb1ed3cbfa49]::sys::backtrace::BacktraceLock>::print
   4:     0x7f680ca27fe0 - std[f727eb1ed3cbfa49]::panicking::default_hook::{closure#1}
   5:     0x7f680ca27d5f - std[f727eb1ed3cbfa49]::panicking::default_hook
   6:     0x7f6808167048 - <alloc[9ba8a48ea8c59ee]::boxed::Box<rustc_driver_impl[f3449109808903f2]::install_ice_hook::{closure#0}> as core[8e2c8c99b037a10c]::ops::function::Fn<(&dyn for<'a, 'b> core[8e2c8c99b037a10c]::ops::function::Fn<(&'a std[f727eb1ed3cbfa49]::panic::PanicHookInfo<'b>,), Output = ()> + core[8e2c8c99b037a10c]::marker::Sync + core[8e2c8c99b037a10c]::marker::Send, &std[f727eb1ed3cbfa49]::panic::PanicHookInfo)>>::call
   7:     0x7f680ca28958 - std[f727eb1ed3cbfa49]::panicking::rust_panic_with_hook
   8:     0x7f680ca2853a - std[f727eb1ed3cbfa49]::panicking::begin_panic_handler::{closure#0}
   9:     0x7f680ca25cf9 - std[f727eb1ed3cbfa49]::sys::backtrace::__rust_end_short_backtrace::<std[f727eb1ed3cbfa49]::panicking::begin_panic_handler::{closure#0}, !>
  11:     0x7f68080c9370 - core[8e2c8c99b037a10c]::panicking::panic_fmt
  12:     0x7f68080c93fc - core[8e2c8c99b037a10c]::panicking::panic
  13:     0x7f680b74b8b0 - <rustc_infer[75aa6ec9f9361b58]::infer::InferCtxt>::add_member_constraint
  13:     0x7f680b74b8b0 - <rustc_infer[75aa6ec9f9361b58]::infer::InferCtxt>::add_member_constraint
  14:     0x7f680b785d5b - <rustc_middle[3691cc9329e1fa17]::ty::Ty as rustc_type_ir[7b370e1195c185]::visit::TypeSuperVisitable<rustc_middle[3691cc9329e1fa17]::ty::context::TyCtxt>>::super_visit_with::<rustc_infer[75aa6ec9f9361b58]::infer::opaque_types::ConstrainOpaqueTypeRegionVisitor<<rustc_infer[75aa6ec9f9361b58]::infer::InferCtxt>::register_member_constraints::{closure#2}>>
  15:     0x7f680b7b0326 - <rustc_infer[75aa6ec9f9361b58]::infer::opaque_types::ConstrainOpaqueTypeRegionVisitor<<rustc_infer[75aa6ec9f9361b58]::infer::InferCtxt>::register_member_constraints::{closure#2}> as rustc_type_ir[7b370e1195c185]::visit::TypeVisitor<rustc_middle[3691cc9329e1fa17]::ty::context::TyCtxt>>::visit_ty
  16:     0x7f680b7b018c - <rustc_infer[75aa6ec9f9361b58]::infer::opaque_types::ConstrainOpaqueTypeRegionVisitor<<rustc_infer[75aa6ec9f9361b58]::infer::InferCtxt>::register_member_constraints::{closure#2}> as rustc_type_ir[7b370e1195c185]::visit::TypeVisitor<rustc_middle[3691cc9329e1fa17]::ty::context::TyCtxt>>::visit_ty
  17:     0x7f680b744a65 - <rustc_infer[75aa6ec9f9361b58]::infer::InferCtxt>::register_member_constraints
  18:     0x7f6809b50975 - <rustc_infer[75aa6ec9f9361b58]::infer::InferCtxt>::commit_if_ok::<(), rustc_span[25f45c78e1a8ee13]::ErrorGuaranteed, rustc_trait_selection[a908506f93b7df4c]::traits::query::type_op::custom::scrape_region_constraints<rustc_trait_selection[a908506f93b7df4c]::traits::query::type_op::custom::CustomTypeOp<rustc_borrowck[ce9fd3fc5d01585c]::type_check::type_check::{closure#0}::{closure#0}>, (), rustc_borrowck[ce9fd3fc5d01585c]::type_check::type_check::{closure#0}::{closure#0}>::{closure#0}>
  19:     0x7f6809b22aa0 - <rustc_trait_selection[a908506f93b7df4c]::traits::query::type_op::custom::CustomTypeOp<rustc_borrowck[ce9fd3fc5d01585c]::type_check::type_check::{closure#0}::{closure#0}> as rustc_trait_selection[a908506f93b7df4c]::traits::query::type_op::TypeOp>::fully_perform
  20:     0x7f6809976bc8 - <rustc_borrowck[ce9fd3fc5d01585c]::type_check::TypeChecker>::fully_perform_op::<(), rustc_trait_selection[a908506f93b7df4c]::traits::query::type_op::custom::CustomTypeOp<rustc_borrowck[ce9fd3fc5d01585c]::type_check::type_check::{closure#0}::{closure#0}>>
  21:     0x7f6809a2b870 - <core[8e2c8c99b037a10c]::iter::adapters::map::Map<indexmap[bc652d40dfcb7388]::map::iter::IntoIter<rustc_type_ir[7b370e1195c185]::opaque_ty::OpaqueTypeKey<rustc_middle[3691cc9329e1fa17]::ty::context::TyCtxt>, rustc_infer[75aa6ec9f9361b58]::infer::opaque_types::OpaqueTypeDecl>, rustc_borrowck[ce9fd3fc5d01585c]::type_check::type_check::{closure#0}> as core[8e2c8c99b037a10c]::iter::traits::iterator::Iterator>::fold::<(), core[8e2c8c99b037a10c]::iter::traits::iterator::Iterator::for_each::call<(rustc_type_ir[7b370e1195c185]::opaque_ty::OpaqueTypeKey<rustc_middle[3691cc9329e1fa17]::ty::context::TyCtxt>, rustc_middle[3691cc9329e1fa17]::ty::OpaqueHiddenType), <indexmap[bc652d40dfcb7388]::map::IndexMap<rustc_type_ir[7b370e1195c185]::opaque_ty::OpaqueTypeKey<rustc_middle[3691cc9329e1fa17]::ty::context::TyCtxt>, rustc_middle[3691cc9329e1fa17]::ty::OpaqueHiddenType, core[8e2c8c99b037a10c]::hash::BuildHasherDefault<rustc_hash[64ad68db49919b29]::FxHasher>> as core[8e2c8c99b037a10c]::iter::traits::collect::Extend<(rustc_type_ir[7b370e1195c185]::opaque_ty::OpaqueTypeKey<rustc_middle[3691cc9329e1fa17]::ty::context::TyCtxt>, rustc_middle[3691cc9329e1fa17]::ty::OpaqueHiddenType)>>::extend<core[8e2c8c99b037a10c]::iter::adapters::map::Map<indexmap[bc652d40dfcb7388]::map::iter::IntoIter<rustc_type_ir[7b370e1195c185]::opaque_ty::OpaqueTypeKey<rustc_middle[3691cc9329e1fa17]::ty::context::TyCtxt>, rustc_infer[75aa6ec9f9361b58]::infer::opaque_types::OpaqueTypeDecl>, rustc_borrowck[ce9fd3fc5d01585c]::type_check::type_check::{closure#0}>>::{closure#0}>::{closure#0}>
  22:     0x7f68099f6606 - <indexmap[bc652d40dfcb7388]::map::IndexMap<rustc_type_ir[7b370e1195c185]::opaque_ty::OpaqueTypeKey<rustc_middle[3691cc9329e1fa17]::ty::context::TyCtxt>, rustc_middle[3691cc9329e1fa17]::ty::OpaqueHiddenType, core[8e2c8c99b037a10c]::hash::BuildHasherDefault<rustc_hash[64ad68db49919b29]::FxHasher>> as core[8e2c8c99b037a10c]::iter::traits::collect::FromIterator<(rustc_type_ir[7b370e1195c185]::opaque_ty::OpaqueTypeKey<rustc_middle[3691cc9329e1fa17]::ty::context::TyCtxt>, rustc_middle[3691cc9329e1fa17]::ty::OpaqueHiddenType)>>::from_iter::<core[8e2c8c99b037a10c]::iter::adapters::map::Map<indexmap[bc652d40dfcb7388]::map::iter::IntoIter<rustc_type_ir[7b370e1195c185]::opaque_ty::OpaqueTypeKey<rustc_middle[3691cc9329e1fa17]::ty::context::TyCtxt>, rustc_infer[75aa6ec9f9361b58]::infer::opaque_types::OpaqueTypeDecl>, rustc_borrowck[ce9fd3fc5d01585c]::type_check::type_check::{closure#0}>>
  23:     0x7f6809964a63 - rustc_borrowck[ce9fd3fc5d01585c]::type_check::type_check
  24:     0x7f6809bb3b5f - rustc_borrowck[ce9fd3fc5d01585c]::nll::compute_regions
  25:     0x7f68097ec47a - rustc_borrowck[ce9fd3fc5d01585c]::do_mir_borrowck
  26:     0x7f68097d3ce3 - rustc_borrowck[ce9fd3fc5d01585c]::mir_borrowck
  27:     0x7f680a8706a5 - rustc_query_impl[270f4b2c65e6133a]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[270f4b2c65e6133a]::query_impl::mir_borrowck::dynamic_query::{closure#2}::{closure#0}, rustc_middle[3691cc9329e1fa17]::query::erase::Erased<[u8; 8usize]>>
  28:     0x7f680a91fea5 - <rustc_query_impl[270f4b2c65e6133a]::query_impl::mir_borrowck::dynamic_query::{closure#2} as core[8e2c8c99b037a10c]::ops::function::FnOnce<(rustc_middle[3691cc9329e1fa17]::ty::context::TyCtxt, rustc_span[25f45c78e1a8ee13]::def_id::LocalDefId)>>::call_once
  29:     0x7f680ad470cb - rustc_query_system[3f50cdd480b69c52]::query::plumbing::try_execute_query::<rustc_query_impl[270f4b2c65e6133a]::DynamicConfig<rustc_data_structures[1001a7d7a7d430a]::vec_cache::VecCache<rustc_span[25f45c78e1a8ee13]::def_id::LocalDefId, rustc_middle[3691cc9329e1fa17]::query::erase::Erased<[u8; 8usize]>, rustc_query_system[3f50cdd480b69c52]::dep_graph::graph::DepNodeIndex>, false, false, false>, rustc_query_impl[270f4b2c65e6133a]::plumbing::QueryCtxt, false>
  30:     0x7f680aa5321a - rustc_query_impl[270f4b2c65e6133a]::query_impl::mir_borrowck::get_query_non_incr::__rust_end_short_backtrace
  31:     0x7f680905c912 - rustc_middle[3691cc9329e1fa17]::query::plumbing::query_get_at::<rustc_data_structures[1001a7d7a7d430a]::vec_cache::VecCache<rustc_span[25f45c78e1a8ee13]::def_id::LocalDefId, rustc_middle[3691cc9329e1fa17]::query::erase::Erased<[u8; 8usize]>, rustc_query_system[3f50cdd480b69c52]::dep_graph::graph::DepNodeIndex>>
  32:     0x7f6809095395 - rustc_hir_analysis[6414e908fb1d68fc]::collect::type_of::type_of_opaque
  33:     0x7f680a874d4a - rustc_query_impl[270f4b2c65e6133a]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[270f4b2c65e6133a]::query_impl::type_of_opaque::dynamic_query::{closure#2}::{closure#0}, rustc_middle[3691cc9329e1fa17]::query::erase::Erased<[u8; 8usize]>>
  34:     0x7f680a921d19 - <rustc_query_impl[270f4b2c65e6133a]::query_impl::type_of_opaque::dynamic_query::{closure#2} as core[8e2c8c99b037a10c]::ops::function::FnOnce<(rustc_middle[3691cc9329e1fa17]::ty::context::TyCtxt, rustc_span[25f45c78e1a8ee13]::def_id::DefId)>>::call_once
  35:     0x7f680ac86f19 - rustc_query_system[3f50cdd480b69c52]::query::plumbing::try_execute_query::<rustc_query_impl[270f4b2c65e6133a]::DynamicConfig<rustc_query_system[3f50cdd480b69c52]::query::caches::DefIdCache<rustc_middle[3691cc9329e1fa17]::query::erase::Erased<[u8; 8usize]>>, false, false, false>, rustc_query_impl[270f4b2c65e6133a]::plumbing::QueryCtxt, false>
  36:     0x7f680ab6a1bd - rustc_query_impl[270f4b2c65e6133a]::query_impl::type_of_opaque::get_query_non_incr::__rust_end_short_backtrace
  37:     0x7f680905dc02 - rustc_middle[3691cc9329e1fa17]::query::plumbing::query_get_at::<rustc_query_system[3f50cdd480b69c52]::query::caches::DefIdCache<rustc_middle[3691cc9329e1fa17]::query::erase::Erased<[u8; 8usize]>>>
  38:     0x7f6809093ef5 - rustc_hir_analysis[6414e908fb1d68fc]::collect::type_of::type_of
  39:     0x7f680a896627 - rustc_query_impl[270f4b2c65e6133a]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[270f4b2c65e6133a]::query_impl::type_of::dynamic_query::{closure#2}::{closure#0}, rustc_middle[3691cc9329e1fa17]::query::erase::Erased<[u8; 8usize]>>
  40:     0x7f680a930319 - <rustc_query_impl[270f4b2c65e6133a]::query_impl::type_of::dynamic_query::{closure#2} as core[8e2c8c99b037a10c]::ops::function::FnOnce<(rustc_middle[3691cc9329e1fa17]::ty::context::TyCtxt, rustc_span[25f45c78e1a8ee13]::def_id::DefId)>>::call_once
  41:     0x7f680ac86f19 - rustc_query_system[3f50cdd480b69c52]::query::plumbing::try_execute_query::<rustc_query_impl[270f4b2c65e6133a]::DynamicConfig<rustc_query_system[3f50cdd480b69c52]::query::caches::DefIdCache<rustc_middle[3691cc9329e1fa17]::query::erase::Erased<[u8; 8usize]>>, false, false, false>, rustc_query_impl[270f4b2c65e6133a]::plumbing::QueryCtxt, false>
  42:     0x7f680ab6a06d - rustc_query_impl[270f4b2c65e6133a]::query_impl::type_of::get_query_non_incr::__rust_end_short_backtrace
  43:     0x7f680a6c0102 - rustc_middle[3691cc9329e1fa17]::query::plumbing::query_get_at::<rustc_query_system[3f50cdd480b69c52]::query::caches::DefIdCache<rustc_middle[3691cc9329e1fa17]::query::erase::Erased<[u8; 8usize]>>>
  44:     0x7f680a6cb50b - <rustc_privacy[44770133e16348fd]::ReachEverythingInTheInterfaceVisitor>::ty
  45:     0x7f680a6cf88a - rustc_privacy[44770133e16348fd]::effective_visibilities
  46:     0x7f680a886643 - rustc_query_impl[270f4b2c65e6133a]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[270f4b2c65e6133a]::query_impl::effective_visibilities::dynamic_query::{closure#2}::{closure#0}, rustc_middle[3691cc9329e1fa17]::query::erase::Erased<[u8; 8usize]>>
  47:     0x7f680aad9391 - <rustc_query_impl[270f4b2c65e6133a]::query_impl::effective_visibilities::dynamic_query::{closure#2} as core[8e2c8c99b037a10c]::ops::function::FnOnce<(rustc_middle[3691cc9329e1fa17]::ty::context::TyCtxt, ())>>::call_once
  48:     0x7f680ac96cd6 - rustc_query_system[3f50cdd480b69c52]::query::plumbing::try_execute_query::<rustc_query_impl[270f4b2c65e6133a]::DynamicConfig<rustc_query_system[3f50cdd480b69c52]::query::caches::SingleCache<rustc_middle[3691cc9329e1fa17]::query::erase::Erased<[u8; 8usize]>>, false, false, false>, rustc_query_impl[270f4b2c65e6133a]::plumbing::QueryCtxt, false>
  49:     0x7f680aaa8211 - rustc_query_impl[270f4b2c65e6133a]::query_impl::effective_visibilities::get_query_non_incr::__rust_end_short_backtrace
  50:     0x7f680a546c25 - rustc_passes[d29e89d1508a19b7]::stability::check_unused_or_stable_features
  51:     0x7f680856e3b3 - <rustc_session[93824302d5dfbf5f]::session::Session>::time::<(), rustc_interface[748fabb4fdf43cb5]::passes::run_required_analyses::{closure#0}>
  52:     0x7f68085ad646 - rustc_interface[748fabb4fdf43cb5]::passes::analysis
  53:     0x7f680a896823 - rustc_query_impl[270f4b2c65e6133a]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[270f4b2c65e6133a]::query_impl::analysis::dynamic_query::{closure#2}::{closure#0}, rustc_middle[3691cc9329e1fa17]::query::erase::Erased<[u8; 1usize]>>
  54:     0x7f680ab68111 - <rustc_query_impl[270f4b2c65e6133a]::query_impl::analysis::dynamic_query::{closure#2} as core[8e2c8c99b037a10c]::ops::function::FnOnce<(rustc_middle[3691cc9329e1fa17]::ty::context::TyCtxt, ())>>::call_once
  55:     0x7f680ac92b28 - rustc_query_system[3f50cdd480b69c52]::query::plumbing::try_execute_query::<rustc_query_impl[270f4b2c65e6133a]::DynamicConfig<rustc_query_system[3f50cdd480b69c52]::query::caches::SingleCache<rustc_middle[3691cc9329e1fa17]::query::erase::Erased<[u8; 1usize]>>, false, false, false>, rustc_query_impl[270f4b2c65e6133a]::plumbing::QueryCtxt, false>
  56:     0x7f680aadf8a7 - rustc_query_impl[270f4b2c65e6133a]::query_impl::analysis::get_query_non_incr::__rust_end_short_backtrace
  57:     0x7f68080cb94b - <rustc_middle[3691cc9329e1fa17]::ty::context::GlobalCtxt>::enter::<rustc_driver_impl[f3449109808903f2]::run_compiler::{closure#0}::{closure#1}::{closure#4}, core[8e2c8c99b037a10c]::result::Result<core[8e2c8c99b037a10c]::option::Option<rustc_interface[748fabb4fdf43cb5]::queries::Linker>, rustc_span[25f45c78e1a8ee13]::ErrorGuaranteed>>
  58:     0x7f6808176363 - <rustc_interface[748fabb4fdf43cb5]::queries::QueryResult<&rustc_middle[3691cc9329e1fa17]::ty::context::GlobalCtxt>>::enter::<core[8e2c8c99b037a10c]::result::Result<core[8e2c8c99b037a10c]::option::Option<rustc_interface[748fabb4fdf43cb5]::queries::Linker>, rustc_span[25f45c78e1a8ee13]::ErrorGuaranteed>, rustc_driver_impl[f3449109808903f2]::run_compiler::{closure#0}::{closure#1}::{closure#4}>
  59:     0x7f68080d9272 - <rustc_interface[748fabb4fdf43cb5]::interface::Compiler>::enter::<rustc_driver_impl[f3449109808903f2]::run_compiler::{closure#0}::{closure#1}, core[8e2c8c99b037a10c]::result::Result<core[8e2c8c99b037a10c]::option::Option<rustc_interface[748fabb4fdf43cb5]::queries::Linker>, rustc_span[25f45c78e1a8ee13]::ErrorGuaranteed>>
  60:     0x7f680815271e - rustc_span[25f45c78e1a8ee13]::create_session_globals_then::<core[8e2c8c99b037a10c]::result::Result<(), rustc_span[25f45c78e1a8ee13]::ErrorGuaranteed>, rustc_interface[748fabb4fdf43cb5]::util::run_in_thread_with_globals<rustc_interface[748fabb4fdf43cb5]::util::run_in_thread_pool_with_globals<rustc_interface[748fabb4fdf43cb5]::interface::run_compiler<core[8e2c8c99b037a10c]::result::Result<(), rustc_span[25f45c78e1a8ee13]::ErrorGuaranteed>, rustc_driver_impl[f3449109808903f2]::run_compiler::{closure#0}>::{closure#1}, core[8e2c8c99b037a10c]::result::Result<(), rustc_span[25f45c78e1a8ee13]::ErrorGuaranteed>>::{closure#0}, core[8e2c8c99b037a10c]::result::Result<(), rustc_span[25f45c78e1a8ee13]::ErrorGuaranteed>>::{closure#0}::{closure#0}::{closure#0}>
  61:     0x7f68081eecb2 - std[f727eb1ed3cbfa49]::sys::backtrace::__rust_begin_short_backtrace::<rustc_interface[748fabb4fdf43cb5]::util::run_in_thread_with_globals<rustc_interface[748fabb4fdf43cb5]::util::run_in_thread_pool_with_globals<rustc_interface[748fabb4fdf43cb5]::interface::run_compiler<core[8e2c8c99b037a10c]::result::Result<(), rustc_span[25f45c78e1a8ee13]::ErrorGuaranteed>, rustc_driver_impl[f3449109808903f2]::run_compiler::{closure#0}>::{closure#1}, core[8e2c8c99b037a10c]::result::Result<(), rustc_span[25f45c78e1a8ee13]::ErrorGuaranteed>>::{closure#0}, core[8e2c8c99b037a10c]::result::Result<(), rustc_span[25f45c78e1a8ee13]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[8e2c8c99b037a10c]::result::Result<(), rustc_span[25f45c78e1a8ee13]::ErrorGuaranteed>>
  62:     0x7f68081853e2 - <<std[f727eb1ed3cbfa49]::thread::Builder>::spawn_unchecked_<rustc_interface[748fabb4fdf43cb5]::util::run_in_thread_with_globals<rustc_interface[748fabb4fdf43cb5]::util::run_in_thread_pool_with_globals<rustc_interface[748fabb4fdf43cb5]::interface::run_compiler<core[8e2c8c99b037a10c]::result::Result<(), rustc_span[25f45c78e1a8ee13]::ErrorGuaranteed>, rustc_driver_impl[f3449109808903f2]::run_compiler::{closure#0}>::{closure#1}, core[8e2c8c99b037a10c]::result::Result<(), rustc_span[25f45c78e1a8ee13]::ErrorGuaranteed>>::{closure#0}, core[8e2c8c99b037a10c]::result::Result<(), rustc_span[25f45c78e1a8ee13]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[8e2c8c99b037a10c]::result::Result<(), rustc_span[25f45c78e1a8ee13]::ErrorGuaranteed>>::{closure#1} as core[8e2c8c99b037a10c]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
  63:     0x7f680ca34545 - <std[f727eb1ed3cbfa49]::sys::pal::unix::thread::Thread>::new::thread_start
  65:     0x7f68074c1850 - <unknown>
  66:                0x0 - <unknown>

error: the compiler unexpectedly panicked. this is a bug.
---
warning: the ICE couldn't be written to `/checkout/rustc-ice-2024-12-05T11_47_25-11363.txt`: Read-only file system (os error 30)

note: rustc 1.85.0-nightly (16b7e3df1 2024-12-05) running on x86_64-unknown-linux-gnu

note: compiler flags: --crate-type lib -C opt-level=3 -C embed-bitcode=no -C codegen-units=1 -C debug-assertions=on -C symbol-mangling-version=v0 -Z unstable-options -Z macro-backtrace -C split-debuginfo=off -C prefer-dynamic -Z inline-mir -Z inline-mir-preserve-debug -C link-args=-Wl,-z,origin -C link-args=-Wl,-rpath,$ORIGIN/../lib -C embed-bitcode=yes -C force-frame-pointers=yes -Z crate-attr=doc(html_root_url="https://doc.rust-lang.org/nightly/") -Z binary-dep-depinfo -Z force-unstable-if-unmarked
note: some of the compiler flags provided by cargo are hidden

query stack during panic:
query stack during panic:
#0 [mir_borrowck] borrow-checking `iter::adapters::enumerate::<impl at library/core/src/iter/adapters/enumerate.rs:29:1: 31:17>::try_fold::enumerate`
#1 [type_of_opaque] computing type of opaque `iter::adapters::enumerate::<impl at library/core/src/iter/adapters/enumerate.rs:29:1: 31:17>::try_fold::enumerate::{opaque#0}`
error: could not compile `core` (lib)

Caused by:
Caused by:
  process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc /checkout/obj/build/bootstrap/debug/rustc --crate-name core --edition=2021 library/core/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no -C codegen-units=1 --warn=unexpected_cfgs --check-cfg 'cfg(bootstrap)' --check-cfg 'cfg(no_fp_fmt_parse)' --check-cfg 'cfg(stdarch_intel_sde)' --check-cfg 'cfg(feature, values(any()))' -C debug-assertions=on --check-cfg 'cfg(docsrs)' --check-cfg 'cfg(feature, values("debug_refcell", "optimize_for_size", "panic_immediate_abort"))' -C metadata=c9690195bf6f5d1b -C extra-filename=-c9690195bf6f5d1b --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/release/deps -Csymbol-mangling-version=v0 '--check-cfg=cfg(feature,values(any()))' -Zunstable-options '--check-cfg=cfg(bootstrap)' -Zmacro-backtrace -Csplit-debuginfo=off -Cprefer-dynamic -Zinline-mir -Zinline-mir-preserve-debug -Clink-args=-Wl,-z,origin '-Clink-args=-Wl,-rpath,$ORIGIN/../lib' -Cembed-bitcode=yes -Cforce-frame-pointers=yes '-Zcrate-attr=doc(html_root_url="https://doc.rust-lang.org/nightly/")' -Z binary-dep-depinfo` (exit status: 101)
  local time: Thu Dec  5 11:47:30 UTC 2024
  network time: Thu, 05 Dec 2024 11:47:30 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

@lcnr
Copy link
Contributor Author

lcnr commented Dec 5, 2024

the assert actually triggers because we always use commit_if_ok here 😁

@jackh726
Copy link
Member

jackh726 commented Dec 5, 2024

r=me if you want to remove the assert and stick with just the name change, otherwise will review if you make more changes

@lcnr lcnr mentioned this pull request Dec 17, 2024
Merged
@lcnr
Copy link
Contributor Author

lcnr commented Dec 17, 2024

moved to #134412 with the assert removed

@lcnr lcnr closed this Dec 17, 2024
@lcnr lcnr deleted the opaques-in-closure branch December 17, 2024 08:43
jhpratt added a commit to jhpratt/rust that referenced this pull request Dec 17, 2024
@jhpratt
Rollup merge of rust-lang#134412 - lcnr:borrowck-cleanup-trivial, r=j…
cdd71c9 
…ackh726

small borrowck cleanup

the already approved parts of rust-lang#133909 and rust-lang#133961

r? `@jackh726`
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 17, 2024
@rust-timer
Unrolled build for rust-lang#134412
f828977 
Rollup merge of rust-lang#134412 - lcnr:borrowck-cleanup-trivial, r=jackh726

small borrowck cleanup

the already approved parts of rust-lang#133909 and rust-lang#133961

r? `@jackh726`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jackh726 jackh726

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lcnr @rust-log-analyzer @jackh726 @rustbot