Clippy subtree update #132746

flip1995 · 2024-11-07T21:32:20Z

…ubtree-update

pulldown-cmark: don't pull getopts dep Don't pull getopts, as it unused. Noticed in rust-lang#131892 changelog: none

Allow to go through clippy lints page without javascript Fixes rust-lang#13536. This is the follow-up of rust-lang/rust-clippy#13269. This PR makes it possible to expand/collapse lints (individually) without JS. To achieve this result, there are two ways: 1. Use `details` and `summary` tags. Problem with this approach is that the web browser search may open the `details` tags automatically if content matching it is inside. From a previous discussion with `@Alexendoo,` it seems to not be a desired behaviour. 2. Use a little trick where you use a `label` and a checkbox where the checkbox is in fact hidden. Then it's just a matter of CSS. r? `@Alexendoo` changelog: Allow to go through clippy lints page without JS

Add internal lint to check for slow symbol comparisons See the conversation on [Zulip](https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/Checking.20a.20Symbol.20is.20equal.20to.20a.20string.20literal). changelog: none

…blyxyas Stop linting manual_bits in any macro invoke Closes rust-lang#13563. changelog: [`manual_bits`] No longer lints in macro-generated code

Before this change, adding a lint was a difficult matter because it always had some overhead involved. This was because all lints would run, no matter their default level, or if the user had #![allow]ed them. This PR changes that

workingjubilee · 2024-11-08T02:49:55Z

Need mingw-check to pass:

  error: function `validate_diag` is never used
    --> src/tools/clippy/clippy_utils/src/diagnostics.rs:41:4
     |
  41 | fn validate_diag(diag: &Diag<'_, impl EmissionGuarantee>) {
     |    ^^^^^^^^^^^^^
     |
     = note: `-D dead-code` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(dead_code)]`

flip1995 · 2024-11-08T09:05:14Z

Looks like we never build Clippy in release mode in the Clippy repo.

Should be good now.

workingjubilee · 2024-11-08T10:28:12Z

@bors r=Manishearth

bors · 2024-11-08T10:28:54Z

📌 Commit 0aafd65 has been approved by Manishearth

It is now in the queue for this repository.

bors · 2024-11-08T16:49:18Z

⌛ Testing commit 0aafd65 with merge 59cec72...

bors · 2024-11-08T19:41:09Z

☀️ Test successful - checks-actions
Approved by: Manishearth
Pushing 59cec72 to master...

rust-timer · 2024-11-08T22:02:35Z

Finished benchmarking commit (59cec72): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.4%, 0.4%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[0.4%, 0.4%]	1

Max RSS (memory usage)

Results (secondary -1.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.4%	[-1.5%, -1.3%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.6%	[3.3%, 3.9%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 780.103s -> 779.98s (-0.02%)
Artifact size: 335.34 MiB -> 335.38 MiB (0.01%)

lqd · 2024-11-08T22:14:34Z

This doesn't change the compiler, and nalgebra is being noisy.

@rustbot label: +perf-regression-triaged

flip1995 · 2024-11-09T14:49:43Z

@jdonszelmann this includes the Clippy attribute changes, you wanted.

jdonszelmann · 2024-11-09T14:50:47Z

Amazing ,thanks so much!

…nishearth Clippy subtree update r? `@Manishearth`

ROMemories and others added 30 commits September 26, 2024 10:07

Add units/unit prefixes of frequency to doc-valid-idents

62026c3

Stabilize isqrt feature

b95aa31

Add lint to check for slow symbol comparisons

6b1779b

Apply fixes from lint

dedc380

Add test

a650692

Update book

979e297

fix: remove unnecessary unfilter_map usages

11162d1

fix: simplify suggestion

40cb24f

fix: linter

ad002ea

Don't trigger const_is_empty for inline const assertions

8555922

Merge commit 'a109190d7060236e655fc75533373fa274ec5343' into clippy-s…

fea5e77

…ubtree-update

Hotfix TRAIT_METHODS static->const

91a458f

pulldown-cmark: don't pull getopts dep

2c3a34a

Allow to go through clippy lints page without javascript

82969e5

Fix lints syntax highlighting

da19d47

Auto merge of rust-lang#13562 - klensy:pc, r=flip1995

47effe4

pulldown-cmark: don't pull getopts dep Don't pull getopts, as it unused. Noticed in rust-lang#131892 changelog: none

Stop linting manual_bits in any macro invoke

a739cc3

Auto merge of rust-lang#13564 - GnomedDev:fix-manualbits-in-macro, r=…

5678531

…blyxyas Stop linting manual_bits in any macro invoke Closes rust-lang#13563. changelog: [`manual_bits`] No longer lints in macro-generated code

Do not run lints that cannot emit

6983631

Before this change, adding a lint was a difficult matter because it always had some overhead involved. This was because all lints would run, no matter their default level, or if the user had #![allow]ed them. This PR changes that

Follow review comments (optimize the filtering)

8f8aa46

Remove module passes filtering

e427a4e

Apply review comments + use shallow_lint_levels_on

e518d66

add debug assertions for overlapping spans and empty replacements

38cf3f3

fix empty suggestion ICE in from_over_into

4de65a1

Fix tests

69b0886

Fix version for ref_option

64c4cf1

docs: remove stray comma

2a5de35

make unsupported_calling_conventions a hard error

aab0eee

This comment has been minimized.

Sign in to view

Clippy: cfg out validate_diag on release builds

0aafd65

flip1995 force-pushed the clippy-subtree-update branch from 6c87427 to 0aafd65 Compare November 8, 2024 09:50

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 8, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 8, 2024

bors merged commit 59cec72 into rust-lang:master Nov 8, 2024
7 checks passed

rustbot added this to the 1.84.0 milestone Nov 8, 2024

rustbot added the perf-regression Performance regression. label Nov 8, 2024

rustbot added the perf-regression-triaged The performance regression has been triaged. label Nov 8, 2024

flip1995 deleted the clippy-subtree-update branch November 9, 2024 14:49

Mark-Simulacrum removed perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. labels Nov 11, 2024

mati865 pushed a commit to mati865/rust that referenced this pull request Nov 12, 2024

Auto merge of rust-lang#132746 - flip1995:clippy-subtree-update, r=Ma…

2d28706

…nishearth Clippy subtree update r? `@Manishearth`

2asoft mentioned this pull request Jul 21, 2025

[1.84.0 regression] #[allow(clippy::disallowed_macros)] does not work on two-argument std::panic rust-lang/rust-clippy#14017

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Clippy subtree update #132746

Clippy subtree update #132746

Uh oh!

flip1995 commented Nov 7, 2024

Uh oh!

workingjubilee commented Nov 8, 2024

Uh oh!

flip1995 commented Nov 8, 2024

Uh oh!

This comment has been minimized.

workingjubilee commented Nov 8, 2024

Uh oh!

bors commented Nov 8, 2024

Uh oh!

bors commented Nov 8, 2024

Uh oh!

bors commented Nov 8, 2024

Uh oh!

Uh oh!

rust-timer commented Nov 8, 2024

Uh oh!

lqd commented Nov 8, 2024

Uh oh!

flip1995 commented Nov 9, 2024

Uh oh!

jdonszelmann commented Nov 9, 2024

Uh oh!

Uh oh!

Clippy subtree update #132746

Clippy subtree update #132746

Uh oh!

Conversation

flip1995 commented Nov 7, 2024

Uh oh!

workingjubilee commented Nov 8, 2024

Uh oh!

flip1995 commented Nov 8, 2024

Uh oh!

This comment has been minimized.

workingjubilee commented Nov 8, 2024

Uh oh!

bors commented Nov 8, 2024

Uh oh!

bors commented Nov 8, 2024

Uh oh!

bors commented Nov 8, 2024

Uh oh!

Uh oh!

rust-timer commented Nov 8, 2024

Overall result: ❌ regressions - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

lqd commented Nov 8, 2024

Uh oh!

flip1995 commented Nov 9, 2024

Uh oh!

jdonszelmann commented Nov 9, 2024

Uh oh!

Uh oh!