Skip to content

Conversation

GuillaumeGomez
Copy link
Member

Encountered this bug randomly where code item in docblocks would look like this:

Screenshot from 2024-10-26 15-44-46

With this fix it looks like this:

image

r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 26, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 26, 2024

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha

@rust-log-analyzer

This comment has been minimized.

@notriddle
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 26, 2024

📌 Commit 88f4425 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2024
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Oct 27, 2024
…=notriddle

Fix code HTML items making big blocks if too long

Encountered this bug randomly where `code` item in docblocks would look like this:

![Screenshot from 2024-10-26 15-44-46](https://github.com/user-attachments/assets/a9c1df9d-5007-49eb-a7dd-a2c381b2511e)

With this fix it looks like this:

![image](https://github.com/user-attachments/assets/ea918595-5434-4781-b68c-6abd38689365)

r? `@notriddle`
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 27, 2024
…kingjubilee

Rollup of 5 pull requests

Successful merges:

 - rust-lang#132123 (allow type-based search on foreign functions)
 - rust-lang#132170 (Add a Few Codegen Tests)
 - rust-lang#132183 (Fix code HTML items making big blocks if too long)
 - rust-lang#132192 (expand: Stop using artificial `ast::Item` for macros loaded from metadata)
 - rust-lang#132205 (docs: Correctly link riscv32e from platform-support.md)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 27, 2024
…kingjubilee

Rollup of 4 pull requests

Successful merges:

 - rust-lang#132123 (allow type-based search on foreign functions)
 - rust-lang#132183 (Fix code HTML items making big blocks if too long)
 - rust-lang#132192 (expand: Stop using artificial `ast::Item` for macros loaded from metadata)
 - rust-lang#132205 (docs: Correctly link riscv32e from platform-support.md)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b805939 into rust-lang:master Oct 27, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Oct 27, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 27, 2024
Rollup merge of rust-lang#132183 - GuillaumeGomez:code-in-docblock, r=notriddle

Fix code HTML items making big blocks if too long

Encountered this bug randomly where `code` item in docblocks would look like this:

![Screenshot from 2024-10-26 15-44-46](https://github.com/user-attachments/assets/a9c1df9d-5007-49eb-a7dd-a2c381b2511e)

With this fix it looks like this:

![image](https://github.com/user-attachments/assets/ea918595-5434-4781-b68c-6abd38689365)

r? ``@notriddle``
@GuillaumeGomez GuillaumeGomez deleted the code-in-docblock branch October 27, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants