coverage: Make counter creation handle node/edge counters more uniformly #131918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nnethercote rustbot has assigned @nnethercote. Use |
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
|
This should have no effect on the output of coverage instrumentation, as demonstrated by the lack of changes to coverage tests. |
Swatinem
approved these changes
Oct 19, 2024
|
The new names are a clear improvement, thanks. @bors r+ |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 22, 2024
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#131918 (coverage: Make counter creation handle node/edge counters more uniformly) - rust-lang#132021 (nuttx.md: typo) - rust-lang#132029 (Subtree update of `rust-analyzer`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 22, 2024
Rollup merge of rust-lang#131918 - Zalathar:counters, r=nnethercote coverage: Make counter creation handle node/edge counters more uniformly Similar to rust-lang#130380, this is another round of small improvements informed by my ongoing attempts to overhaul coverage counter creation. One of the big benefits is getting rid of the awkward special-case that would sometimes attach an edge counter to a node instead. That was needed by the code that chooses which out-edge should be given a counter expression, but we can avoid that by making the corresponding check a little smarter. I've also renamed several things to be simpler and more consistent, which should help with future changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #130380, this is another round of small improvements informed by my ongoing attempts to overhaul coverage counter creation.
One of the big benefits is getting rid of the awkward special-case that would sometimes attach an edge counter to a node instead. That was needed by the code that chooses which out-edge should be given a counter expression, but we can avoid that by making the corresponding check a little smarter.
I've also renamed several things to be simpler and more consistent, which should help with future changes.