[llvm/PassWrapper] use size_t when building arg strings
#138117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use |
Urgau
approved these changes
Mar 6, 2025
|
r=me when CI is green |
|
@bors r=Urgau rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 7, 2025
…mpiler-errors Rollup of 17 pull requests Successful merges: - rust-lang#137827 (Add timestamp to unstable feature usage metrics) - rust-lang#138041 (bootstrap and compiletest: Use `size_of_val` from the prelude instead of imported) - rust-lang#138046 (trim channel value in `get_closest_merge_commit`) - rust-lang#138053 (Increase the max. custom try jobs requested to `20`) - rust-lang#138061 (triagebot: add a `compiler_leads` ad-hoc group) - rust-lang#138064 (Remove - from xtensa targets cpu names) - rust-lang#138075 (Use final path segment for diagnostic) - rust-lang#138078 (Reduce the noise of bootstrap changelog warnings in --dry-run mode) - rust-lang#138081 (Move `yield` expressions behind their own feature gate) - rust-lang#138090 (`librustdoc`: flatten nested ifs) - rust-lang#138092 (Re-add `DynSend` and `DynSync` impls for `TyCtxt`) - rust-lang#138094 (a small borrowck cleanup) - rust-lang#138098 (Stabilize feature `const_copy_from_slice`) - rust-lang#138103 (Git ignore citool's target directory) - rust-lang#138105 (Fix broken link to Miri intrinsics in documentation) - rust-lang#138108 (Mention me (WaffleLapkin) when changes to `rustc_codegen_ssa` occur) - rust-lang#138117 ([llvm/PassWrapper] use `size_t` when building arg strings) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 7, 2025
Rollup merge of rust-lang#138117 - cuviper:passwrapper-size_t, r=Urgau [llvm/PassWrapper] use `size_t` when building arg strings While we're unlikely to ever overflow `int` in this case, it's still more proper to use `size_t` consistently when dealing with buffer lengths. If nothing else, this fixes a few `-Wsign-compare` warnings.
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Mar 14, 2025
…mpiler-errors Rollup of 17 pull requests Successful merges: - rust-lang#137827 (Add timestamp to unstable feature usage metrics) - rust-lang#138041 (bootstrap and compiletest: Use `size_of_val` from the prelude instead of imported) - rust-lang#138046 (trim channel value in `get_closest_merge_commit`) - rust-lang#138053 (Increase the max. custom try jobs requested to `20`) - rust-lang#138061 (triagebot: add a `compiler_leads` ad-hoc group) - rust-lang#138064 (Remove - from xtensa targets cpu names) - rust-lang#138075 (Use final path segment for diagnostic) - rust-lang#138078 (Reduce the noise of bootstrap changelog warnings in --dry-run mode) - rust-lang#138081 (Move `yield` expressions behind their own feature gate) - rust-lang#138090 (`librustdoc`: flatten nested ifs) - rust-lang#138092 (Re-add `DynSend` and `DynSync` impls for `TyCtxt`) - rust-lang#138094 (a small borrowck cleanup) - rust-lang#138098 (Stabilize feature `const_copy_from_slice`) - rust-lang#138103 (Git ignore citool's target directory) - rust-lang#138105 (Fix broken link to Miri intrinsics in documentation) - rust-lang#138108 (Mention me (WaffleLapkin) when changes to `rustc_codegen_ssa` occur) - rust-lang#138117 ([llvm/PassWrapper] use `size_t` when building arg strings) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we're unlikely to ever overflow
intin this case, it's still more proper to usesize_tconsistently when dealing with buffer lengths. If nothing else, this fixes a few-Wsign-comparewarnings.