Skip to content

uefi: helpers: Add DevicePathNode abstractions #137424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2025
Merged

uefi: helpers: Add DevicePathNode abstractions #137424

merged 1 commit into from
Mar 14, 2025

Conversation

Ayush1325
Copy link
Contributor

cc @nicholasbishop

@rustbot
Copy link
Collaborator

rustbot commented Feb 22, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 22, 2025
@Ayush1325 Ayush1325 mentioned this pull request Feb 22, 2025
Merged
@Ayush1325
Copy link
Contributor Author

cc @jhpratt @joboet

@Ayush1325
uefi: helpers: Add DevicePathNode abstractions
61e550a 
- UEFI device path is a series of nodes layed out in a contiguous memory
  region. So it makes sense to use Iterator abstraction for modeling
  DevicePaths
- This PR has been split off from rust-lang#135368 for easier review. The allow
  dead_code will be removed in rust-lang#135368

Signed-off-by: Ayush Singh <ayush@beagleboard.org>
@Ayush1325
Copy link
Contributor Author

cc @Mark-Simulacrum

@Ayush1325
Copy link
Contributor Author

r? libs

@rustbot rustbot assigned cuviper and unassigned Mark-Simulacrum Mar 13, 2025
@cuviper
Copy link
Member

cuviper commented Mar 13, 2025

@bors r=nicholasbishop,cuviper

@bors
Copy link
Collaborator

bors commented Mar 13, 2025

📌 Commit 61e550a has been approved by nicholasbishop,cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 13, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 14, 2025
@jhpratt
Rollup merge of rust-lang#137424 - Ayush1325:uefi-path-node, r=nichol…
a95e9ef 
…asbishop,cuviper

uefi: helpers: Add DevicePathNode abstractions

- UEFI device path is a series of nodes layed out in a contiguous memory region. So it makes sense to use Iterator abstraction for modeling DevicePaths
- This PR has been split off from rust-lang#135368 for easier review. The allow dead_code will be removed in rust-lang#135368

cc `@nicholasbishop`
@jhpratt jhpratt mentioned this pull request Mar 14, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 14, 2025
@bors
Auto merge of rust-lang#138486 - jhpratt:rollup-765wijj, r=jhpratt
de018e3 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#134720 (Display valid crate types in error message for --crate-type flag)
 - rust-lang#137424 (uefi: helpers: Add DevicePathNode abstractions)
 - rust-lang#137736 (Don't attempt to export compiler-builtins symbols from rust dylibs)
 - rust-lang#138451 (Build GCC on CI with GCC, not Clang)
 - rust-lang#138454 (Improve post-merge workflow)
 - rust-lang#138477 (Deny impls for `BikeshedGuaranteedNoDrop`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Mar 14, 2025

⌛ Testing commit 61e550a with merge cb50d4d...

@bors
Copy link
Collaborator

bors commented Mar 14, 2025

☀️ Test successful - checks-actions
Approved by: nicholasbishop,cuviper
Pushing cb50d4d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 14, 2025
@bors bors merged commit cb50d4d into rust-lang:master Mar 14, 2025
7 checks passed
@Ayush1325 Ayush1325 deleted the uefi-path-node branch March 14, 2025 17:00
@github-actions GitHub Actions
Copy link
Contributor

Post-merge analysis result

Test differences

No test diffs found

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (cb50d4d): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)		 1.8% [1.8%, 1.8%] 1
Regressions ❌
(secondary)		 0.3% [0.3%, 0.3%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.8% [1.8%, 1.8%] 1

Max RSS (memory usage)

Results (primary 1.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.2% [1.2%, 1.2%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.2% [1.2%, 1.2%] 1

Cycles

Results (secondary 3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.1% [3.1%, 3.1%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 775.364s -> 773.132s (-0.29%)
Artifact size: 365.01 MiB -> 365.00 MiB (-0.00%)

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Mar 19, 2025
@bors
Auto merge of rust-lang#137424 - Ayush1325:uefi-path-node, r=nicholas…
54e9d10 
…bishop,cuviper

uefi: helpers: Add DevicePathNode abstractions

- UEFI device path is a series of nodes layed out in a contiguous memory region. So it makes sense to use Iterator abstraction for modeling DevicePaths
- This PR has been split off from rust-lang#135368 for easier review. The allow dead_code will be removed in rust-lang#135368

cc `@nicholasbishop`
@Ayush1325 Ayush1325 mentioned this pull request Mar 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@nicholasbishop nicholasbishop nicholasbishop approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@cuviper cuviper

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Ayush1325 @rustbot @cuviper @bors @rust-timer @nicholasbishop @Mark-Simulacrum