Skip to content

Conversation

marcoieni
Copy link
Member

@marcoieni marcoieni commented Jan 21, 2025

Split the i686-mingw job in three to move it to free runners and reduce the use of large runners in CI. Related to rust-lang/infra-team#189

  • try this for some time so that we verify it's not flaky.

r? @ghost

try-job: i686-mingw-1
try-job: i686-mingw-2
try-job: i686-mingw-3
try-job: x86_64-mingw-1

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jan 21, 2025
@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Jan 21, 2025

⌛ Trying commit 1bbdc85 with merge 384efee...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 21, 2025
…<try>

CI: split i686-mingw job to two free runners

try-job: i686-mingw-1
try-job: i686-mingw-2
@bors
Copy link
Collaborator

bors commented Jan 21, 2025

☀️ Try build successful - checks-actions
Build commit: 384efee (384efeeb8d29643ebcd89d9f6cc912bf76185594)

@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Jan 21, 2025

⌛ Trying commit 1bbdc85 with merge e9bcdbf...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 21, 2025
…<try>

CI: split i686-mingw job to two free runners

try-job: i686-mingw-1
try-job: i686-mingw-2
@bors
Copy link
Collaborator

bors commented Jan 21, 2025

☀️ Try build successful - checks-actions
Build commit: e9bcdbf (e9bcdbf19fb7df842f9db7bfefa003987d0ba8c9)

@marcoieni
Copy link
Member Author

marcoieni commented Jan 21, 2025

mingw1 is too slow. I need to check the logs and see what are the slowest operations
image

@marcoieni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 30, 2025
…<try>

CI: split i686-mingw job to two free runners

try-job: i686-mingw-1
try-job: i686-mingw-2
@bors
Copy link
Collaborator

bors commented Jan 30, 2025

⌛ Trying commit 43e19cd with merge 3445c8f...

@bors
Copy link
Collaborator

bors commented Jan 30, 2025

☀️ Try build successful - checks-actions
Build commit: 3445c8f (3445c8fcbeecf28ca39cc469071c9465e29ed48c)

@marcoieni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 30, 2025
…<try>

CI: split i686-mingw job to two free runners

try-job: i686-mingw-1
try-job: i686-mingw-2
@bors
Copy link
Collaborator

bors commented Jan 30, 2025

⌛ Trying commit 43e19cd with merge 3015d1c...

@bors
Copy link
Collaborator

bors commented Jan 30, 2025

☀️ Try build successful - checks-actions
Build commit: 3015d1c (3015d1c38affb49e3994db8c77fc6d2816d3de1a)

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jan 31, 2025
@marcoieni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 31, 2025
…<try>

CI: split i686-mingw job to two free runners

try-job: i686-mingw-1
try-job: i686-mingw-2
try-job: i686-mingw-3
@bors
Copy link
Collaborator

bors commented Jan 31, 2025

⌛ Trying commit 2325bb9 with merge a8fe99a...

@bors
Copy link
Collaborator

bors commented Jan 31, 2025

☀️ Try build successful - checks-actions
Build commit: a8fe99a (a8fe99aeedc7f13c66579a2f09c0492f6869f0cd)

@ChrisDenton
Copy link
Member

Would this help with the OOM in #135763? It looks like the combined job doesn't have enough memory for a fresh LLVM build.

@marcoieni
Copy link
Member Author

marcoieni commented Jan 31, 2025

I'll have a look at your issue 👍

@ChrisDenton
Copy link
Member

Oh, sorry! And thanks!

@marcoieni
Copy link
Member Author

No, no worries, I was wrong and I edited my message.
This PR moves the runner from the large runner to the small runner, so in theory it could make things worse 😅
I left a comment in the PR to test again with windows 25 👍

@marcoieni marcoieni changed the title CI: split i686-mingw job to two free runners CI: split i686-mingw job to three free runners Jan 31, 2025
@bors
Copy link
Collaborator

bors commented Feb 4, 2025

⌛ Trying commit 8d99c58 with merge ad28d65...

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 4, 2025
…<try>

CI: split i686-mingw job to three free runners

try-job: i686-mingw-1
try-job: i686-mingw-2
try-job: i686-mingw-3
try-job: x86_64-mingw-1
@bors
Copy link
Collaborator

bors commented Feb 4, 2025

☀️ Try build successful - checks-actions
Build commit: ad28d65 (ad28d65e3e34f10d47c4ff2f4908439c5d2f88c2)

@marcoieni
Copy link
Member Author

@rustbot ready

@marcoieni
Copy link
Member Author

r? @Kobzol

@rustbot
Copy link
Collaborator

rustbot commented Feb 10, 2025

Could not assign reviewer from: Kobzol.
User(s) Kobzol are either the PR author, already assigned, or on vacation. Please use r? to specify someone else to assign.

@marcoieni
Copy link
Member Author

r? @Mark-Simulacrum

@marcoieni marcoieni force-pushed the free-runner-i686-mingw branch from 8d99c58 to 00683a0 Compare February 14, 2025 10:10
@marcoieni
Copy link
Member Author

marcoieni commented Feb 14, 2025

since this pr is now a bit old, I merged with master and I'm trying again to see if nothing has changed and we can still merge this.

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 14, 2025
…<try>

CI: split i686-mingw job to three free runners

try-job: i686-mingw-1
try-job: i686-mingw-2
try-job: i686-mingw-3
try-job: x86_64-mingw-1
@bors
Copy link
Collaborator

bors commented Feb 14, 2025

⌛ Trying commit 00683a0 with merge d62afba...

@bors
Copy link
Collaborator

bors commented Feb 14, 2025

☀️ Try build successful - checks-actions
Build commit: d62afba (d62afbabaf9e6b1bea9d26ec84db483a39f559a6)

@marcoieni
Copy link
Member Author

still ok
image

@jdno
Copy link
Member

jdno commented Feb 14, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 14, 2025

📌 Commit 00683a0 has been approved by jdno

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 14, 2025
…r=jdno

CI: split i686-mingw job to three free runners

try-job: i686-mingw-1
try-job: i686-mingw-2
try-job: i686-mingw-3
try-job: x86_64-mingw-1
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 14, 2025
Rollup of 11 pull requests

Successful merges:

 - rust-lang#133312 (triagebot: automatically add more rustdoc related labels)
 - rust-lang#134016 (Stabilize `const_is_char_boundary` and `const_str_split_at`.)
 - rust-lang#135813 (CI: split i686-mingw job to three free runners)
 - rust-lang#136879 (Add safe new() to NotAllOnes)
 - rust-lang#136971 (Add a new check-pass UI test for returning `impl Fn(T) -> impl Trait`)
 - rust-lang#136983 (Prepare standard library for Rust 2024 migration)
 - rust-lang#137002 (Fix early lint check desc in query)
 - rust-lang#137006 (borrowck diagnostics cleanup: remove an unused and a barely-used field)
 - rust-lang#137026 (Stabilize (and const-stabilize) `integer_sign_cast`)
 - rust-lang#137028 (mir_build: Clarify some code for lowering `hir::PatExpr` to THIR)
 - rust-lang#137032 (Decode metadata buffer in one go)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 15, 2025
Rollup of 9 pull requests

Successful merges:

 - rust-lang#135687 (re-export `FromCoroutine` from `core::iter`)
 - rust-lang#135813 (CI: split i686-mingw job to three free runners)
 - rust-lang#136749 (Implement Extend<AsciiChar> for String)
 - rust-lang#136879 (Add safe new() to NotAllOnes)
 - rust-lang#136978 (Windows: Update generated bindings)
 - rust-lang#137028 (mir_build: Clarify some code for lowering `hir::PatExpr` to THIR)
 - rust-lang#137029 (Remove unnecessary check code in unused_delims)
 - rust-lang#137056 (made check_argument_compat public for use in miri)
 - rust-lang#137062 (Forward all default methods for I/O impls)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 92adb92 into rust-lang:master Feb 15, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 15, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 15, 2025
Rollup merge of rust-lang#135813 - marcoieni:free-runner-i686-mingw, r=jdno

CI: split i686-mingw job to three free runners

try-job: i686-mingw-1
try-job: i686-mingw-2
try-job: i686-mingw-3
try-job: x86_64-mingw-1
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request Mar 11, 2025
Rollup of 9 pull requests

Successful merges:

 - rust-lang#135687 (re-export `FromCoroutine` from `core::iter`)
 - rust-lang#135813 (CI: split i686-mingw job to three free runners)
 - rust-lang#136749 (Implement Extend<AsciiChar> for String)
 - rust-lang#136879 (Add safe new() to NotAllOnes)
 - rust-lang#136978 (Windows: Update generated bindings)
 - rust-lang#137028 (mir_build: Clarify some code for lowering `hir::PatExpr` to THIR)
 - rust-lang#137029 (Remove unnecessary check code in unused_delims)
 - rust-lang#137056 (made check_argument_compat public for use in miri)
 - rust-lang#137062 (Forward all default methods for I/O impls)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request Mar 11, 2025
Rollup of 9 pull requests

Successful merges:

 - rust-lang#135687 (re-export `FromCoroutine` from `core::iter`)
 - rust-lang#135813 (CI: split i686-mingw job to three free runners)
 - rust-lang#136749 (Implement Extend<AsciiChar> for String)
 - rust-lang#136879 (Add safe new() to NotAllOnes)
 - rust-lang#136978 (Windows: Update generated bindings)
 - rust-lang#137028 (mir_build: Clarify some code for lowering `hir::PatExpr` to THIR)
 - rust-lang#137029 (Remove unnecessary check code in unused_delims)
 - rust-lang#137056 (made check_argument_compat public for use in miri)
 - rust-lang#137062 (Forward all default methods for I/O impls)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants