Methods of const traits are const #135541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred to the CTFE machinery cc @rust-lang/wg-const-eval |
oli-obk
commented
Jan 15, 2025
| hir::Constness::NotConst | ||
| } | ||
| } | ||
| _ => hir::Constness::NotConst, |
There was a problem hiding this comment.
This catch all is a bit sad, but since a parent could be anything that a fn is in, it could be a module, another fn, anything really.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
compiler-errors
approved these changes
Jan 15, 2025
| @@ -6,12 +6,16 @@ use rustc_middle::ty::TyCtxt; | |||
|
|
|||
| fn parent_impl_constness(tcx: TyCtxt<'_>, def_id: LocalDefId) -> hir::Constness { | |||
There was a problem hiding this comment.
Can u rename this to parent_impl_or_trait_constness?
aa84e39 to
a61cd86
Compare
|
@bors r=compiler-errors |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 15, 2025
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#135497 (fix typo in typenames of pin documentation) - rust-lang#135522 (add incremental test for issue 135514) - rust-lang#135523 (const traits: remove some known-bug that do not seem to make sense) - rust-lang#135535 (Add GUI test for rust-lang#135499) - rust-lang#135541 (Methods of const traits are const) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 16, 2025
Rollup merge of rust-lang#135541 - oli-obk:push-lqlmstussztp, r=compiler-errors Methods of const traits are const Just a small FIXME that gets resolved. I think the `constness` query should not cover all const callable things
|
Uuh, I'm seeing a bunch of new false positives for the For example //@ run-pass
use std::ops::Add;
fn f<T: Add>(a: T, b: T) -> <T as Add>::Output {
a + b
}
fn main() {
println!("a + b is {}", f::<f32>(100f32, 200f32));
}now lints which is not correct |
|
yes, the clippy lint needs to look at const stability of traits. The add trait specifically is unstably const |
github-actions bot
pushed a commit
to tautschnig/verify-rust-std
that referenced
this pull request
Mar 11, 2025
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#135497 (fix typo in typenames of pin documentation) - rust-lang#135522 (add incremental test for issue 135514) - rust-lang#135523 (const traits: remove some known-bug that do not seem to make sense) - rust-lang#135535 (Add GUI test for rust-lang#135499) - rust-lang#135541 (Methods of const traits are const) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small FIXME that gets resolved.
I think the
constnessquery should not cover all const callable things