Skip to content

Update to LLVM 19.1.7 #135484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2025
Merged

Update to LLVM 19.1.7 #135484

merged 1 commit into from
Jan 16, 2025

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Jan 14, 2025

Fixes #134457.
Fixes #111073.

@rustbot
Copy link
Collaborator

rustbot commented Jan 14, 2025

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Jan 14, 2025

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 14, 2025
@nikic nikic added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 14, 2025
@nikic
Copy link
Contributor Author

nikic commented Jan 14, 2025

Diff for this update: rust-lang/llvm-project@59512b0...7e8c93c

@cuviper
Copy link
Member

cuviper commented Jan 14, 2025

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Jan 14, 2025

📌 Commit a40c659 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2025
@dianqk dianqk mentioned this pull request Jan 16, 2025
Closed
@bors
Copy link
Collaborator

bors commented Jan 16, 2025

⌛ Testing commit a40c659 with merge d61f55d...

@bors
Copy link
Collaborator

bors commented Jan 16, 2025

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing d61f55d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 16, 2025
@bors bors merged commit d61f55d into rust-lang:master Jan 16, 2025
8 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 16, 2025
@mxinden mxinden mentioned this pull request Jan 16, 2025
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d61f55d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -3.4%, secondary -0.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.9% [0.9%, 0.9%] 1
Improvements ✅
(primary)		 -3.4% [-3.4%, -3.4%] 1
Improvements ✅
(secondary)		 -1.2% [-1.5%, -0.9%] 3
All ❌✅ (primary) -3.4% [-3.4%, -3.4%] 1

Cycles

Results (secondary 3.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.8% [3.0%, 5.0%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 762.718s -> 764.032s (0.17%)
Artifact size: 326.06 MiB -> 326.06 MiB (0.00%)

@apiraino
Copy link
Contributor

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels handled by them.

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 16, 2025
@cuviper cuviper mentioned this pull request Jan 17, 2025
Merged
@cuviper cuviper modified the milestones: 1.86.0, 1.85.0 Jan 17, 2025
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 17, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2025
@bors
Auto merge of rust-lang#135609 - cuviper:beta-next, r=cuviper
752fecf 
[beta] backports

- do not in-place-iterate over flatmap/flatten rust-lang#135104
- Make sure to mark `IMPL_TRAIT_REDUNDANT_CAPTURES` as `Allow` in edition 2024 rust-lang#135441
- Update to LLVM 19.1.7 rust-lang#135484

r? cuviper
@purplesyringa purplesyringa mentioned this pull request Jan 18, 2025
Closed
@workingjubilee workingjubilee added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.

compiler fails on arithmetic operations tests/ui/sanitize/leak.rs fails on Linux with sanitizers = true
7 participants
@nikic @rustbot @cuviper @bors @rust-timer @apiraino @workingjubilee