r? @onur-ozkan

rustbot has assigned @onur-ozkan.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot label +A-CI +A-testsuite

this is really cool. can you give an example of what it looks like for a failing test?

Sure, it looks like this.
I left the failed test output mostly unchanged other than fully spelling out FAILED instead of just F (for easier searching hopefully)

running 18249 tests
10%  --  1825/18249,  1787 passed, 0 failed, 38 ignored
20%  --  3650/18249,  3606 passed, 0 failed, 44 ignored
30%  --  5475/18249,  5423 passed, 0 failed, 52 ignored
   [ui] tests/ui/explicit-i-suffix.rs ... FAILED
40%  --  7300/18249,  7237 passed, 1 failed, 62 ignored
50%  --  9125/18249,  9052 passed, 1 failed, 72 ignored
60%  -- 10950/18249, 10849 passed, 1 failed, 100 ignored
70%  -- 12775/18249, 12664 passed, 1 failed, 110 ignored
   [ui] tests/ui/process/nofile-limit.rs ... FAILED
80%  -- 14600/18249, 14445 passed, 2 failed, 153 ignored
90%  -- 16425/18249, 16259 passed, 2 failed, 164 ignored
100% -- 18249/18249, 18078 passed, 2 failed, 169 ignored


failures:

---- [ui] tests/ui/explicit-i-suffix.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit status: 1

..... the command and stdout (unchanged)

Sure, it looks like this. I left the failed test output mostly unchanged other than fully spelling out FAILED instead of just F (for easier searching hopefully)

running 18249 tests
10%  --  1825/18249,  1787 passed, 0 failed, 38 ignored
20%  --  3650/18249,  3606 passed, 0 failed, 44 ignored
30%  --  5475/18249,  5423 passed, 0 failed, 52 ignored
   [ui] tests/ui/explicit-i-suffix.rs ... FAILED
40%  --  7300/18249,  7237 passed, 1 failed, 62 ignored
50%  --  9125/18249,  9052 passed, 1 failed, 72 ignored
60%  -- 10950/18249, 10849 passed, 1 failed, 100 ignored
70%  -- 12775/18249, 12664 passed, 1 failed, 110 ignored
   [ui] tests/ui/process/nofile-limit.rs ... FAILED
80%  -- 14600/18249, 14445 passed, 2 failed, 153 ignored
90%  -- 16425/18249, 16259 passed, 2 failed, 164 ignored
100% -- 18249/18249, 18078 passed, 2 failed, 169 ignored


failures:

---- [ui] tests/ui/explicit-i-suffix.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit status: 1

..... the command and stdout (unchanged)

That seems nice, but I assume with this approach there is no way to search for passed or ignored tests?

I wonder if we could place passed, failed and ignored lists under GH groups (cc #134910) so we can expand/collapse them without losing the ability of searching on passed and ignored tests.

I wonder if we could place passed, failed and ignored lists under GH groups (cc #134910) so we can expand/collapse them without losing the ability of searching on passed and ignored tests.

This should be possible but it would require some reworking.
Since GitHub Actions do not support nested ::groups (see my comment) we would need to reorganize the outer Testing <stage> compiletest suite=<suite> mode=<mode> so that we can break it down into multiple groups.

Also I am a bit worried about potentially slowing down the loading time of the logs.
Currently, opening the run the build logs can take anywhere from 2-7 seconds.
If we started logging every test that was passed (that was previously a single . char), we might start running into GitHub performance issues 🥲

I wonder if we could place passed, failed and ignored lists under GH groups (cc #134910) so we can expand/collapse them without losing the ability of searching on passed and ignored tests.

This should be possible but it would require some reworking. Since GitHub Actions do not support nested ::groups (see my comment) we would need to reorganize the outer Testing <stage> compiletest suite=<suite> mode=<mode> so that we can break it down into multiple groups.

Also I am a bit worried about potentially slowing down the loading time of the logs. Currently, opening the run the build logs can take anywhere from 2-7 seconds. If we started logging every test that was passed (that was previously a single . char), we might start running into GitHub performance issues 🥲

I see, thanks for the explanation. In this case this PR is already better than the status quo. So,

@bors r+ rollup

📌 Commit dc11857 has been approved by onur-ozkan

It is now in the queue for this repository.