Skip to content

warn against implementing Freeze #123268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2024
Merged

warn against implementing Freeze #123268

merged 1 commit into from
Mar 31, 2024

Conversation

RalfJung
Copy link
Member

@rustbot
Copy link
Collaborator

rustbot commented Mar 31, 2024

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 31, 2024
Noratrieb
Noratrieb reviewed Mar 31, 2024
View reviewed changes
@RalfJung RalfJung force-pushed the dont-freeze branch 2 times, most recently from 5143221 to 9f18094 Compare March 31, 2024 12:28
@Noratrieb
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 31, 2024

📌 Commit 9f18094 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2024
y21
y21 reviewed Mar 31, 2024
View reviewed changes
@workingjubilee
Copy link
Member

typo. :^)

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 31, 2024
@RalfJung
Copy link
Member Author

Ah, good catch, thanks!

@bors r=Nilstrieb

@bors
Copy link
Collaborator

bors commented Mar 31, 2024

📌 Commit 602401c has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 31, 2024
@workingjubilee workingjubilee mentioned this pull request Mar 31, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2024
@bors
Auto merge of rust-lang#123299 - workingjubilee:rollup-2z8amaj, r=wor…
8058136 
…kingjubilee

Rollup of 5 pull requests

Successful merges:

 - rust-lang#123180 (Rewrite `core-no-fp-fmt-parse` test in Rust)
 - rust-lang#123267 (std::thread: adding get_name haiku implementation.)
 - rust-lang#123268 (warn against implementing Freeze)
 - rust-lang#123271 (doc: describe panic conditions for SliceIndex implementations)
 - rust-lang#123295 (add myself to compiler review rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9ff4c70 into rust-lang:master Mar 31, 2024
@rustbot rustbot added this to the 1.79.0 milestone Mar 31, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2024
@rust-timer
Unrolled build for rust-lang#123268
9ac07ed 
Rollup merge of rust-lang#123268 - RalfJung:dont-freeze, r=Nilstrieb

warn against implementing Freeze

As [requested](rust-lang#123184 (comment)) by `@workingjubilee`
@workingjubilee
Copy link
Member

excellent, thank you everyone! I can't wait to tell someone to stop! :^)

@RalfJung RalfJung deleted the dont-freeze branch April 1, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y21 y21 y21 left review comments

@Noratrieb Noratrieb Noratrieb left review comments

Assignees

@jhpratt jhpratt

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
7 participants
@RalfJung @rustbot @Noratrieb @bors @workingjubilee @y21 @jhpratt