Fix the issue of invalid suggestion for a reference of iterator #127669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nnethercote rustbot has assigned @nnethercote. Use |
chenyukang
commented
Jul 12, 2024
| LL + for (src, dest) in std::iter::zip(fields.iter(), variant.iter().clone()) { | ||
| | | ||
|
|
||
| error[E0277]: `&std::slice::Iter<'_, {integer}>` is not an iterator |
There was a problem hiding this comment.
this diag also seems weird, it's better if we could remove it.
|
Could you break this into two commits?
This makes it much easier to review and see the effect of the change. Thanks! |
c8ed5c5 to
5ebfe69
Compare
5ebfe69 to
48ddf5e
Compare
|
Great, thanks! @bors r+ rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 16, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#127669 (Fix the issue of invalid suggestion for a reference of iterator) - rust-lang#127707 (match lowering: Use an iterator to find `expand_until`) - rust-lang#127730 (Fix and enforce `unsafe_op_in_unsafe_fn` in compiler) - rust-lang#127789 (delete #![allow(unsafe_op_in_unsafe_fn)] in teeos) - rust-lang#127805 (run-make-support: update gimli to 0.31.0) - rust-lang#127808 (Make ErrorGuaranteed discoverable outside types, consts, and lifetimes) - rust-lang#127817 (Fix a bunch of sites that were walking instead of visiting, making it impossible for visitor impls to look at these values) - rust-lang#127818 (Various ast validation simplifications) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 16, 2024
Rollup merge of rust-lang#127669 - chenyukang:yukang-fix-deref-127590, r=nnethercote Fix the issue of invalid suggestion for a reference of iterator Fixes rust-lang#127590
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127590