Skip to content

[do not merge] CI experiments #112049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[do not merge] CI experiments #112049

wants to merge 1 commit into from
+2 −11

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented May 28, 2023 •
edited
Loading

Various CI experiments for try/dist builds.

r? @ghost

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 28, 2023
@Kobzol
Copy link
Member Author

Kobzol commented May 28, 2023

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 28, 2023
@bors
Copy link
Collaborator

bors commented May 28, 2023

⌛ Trying commit c42e33cf36e728937b9e7d9bbb16c17d0b364e23 with merge c60ecf63ab7a2a0a260b0a8ee02adff4f4dbfe87...

@bors
Copy link
Collaborator

bors commented May 28, 2023

☀️ Try build successful - checks-actions
Build commit: c60ecf63ab7a2a0a260b0a8ee02adff4f4dbfe87 (c60ecf63ab7a2a0a260b0a8ee02adff4f4dbfe87)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c60ecf63ab7a2a0a260b0a8ee02adff4f4dbfe87): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.3% [0.3%, 0.3%] 2
Regressions ❌
(secondary)		 0.3% [0.3%, 0.3%] 2
Improvements ✅
(primary)		 -0.3% [-0.3%, -0.3%] 1
Improvements ✅
(secondary)		 -0.4% [-0.7%, -0.2%] 9
All ❌✅ (primary) 0.1% [-0.3%, 0.3%] 3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.4% [3.4%, 3.4%] 1
Regressions ❌
(secondary)		 1.8% [1.8%, 1.8%] 1
Improvements ✅
(primary)		 -3.5% [-3.5%, -3.5%] 1
Improvements ✅
(secondary)		 -3.4% [-3.7%, -3.1%] 2
All ❌✅ (primary) -0.1% [-3.5%, 3.4%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.0% [-2.2%, -1.7%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 646.44s -> 646.666s (0.03%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 29, 2023
@Kobzol
Copy link
Member Author

Kobzol commented May 29, 2023

Looks like removing libcore from the profile set doesn't hurt much. Now I'll try to also completely remove rustc-perf gathering when gathering LLVM PGO profiles.

Looks like after the initial stage 2 build with an instrumented LLVM, there is already 6 GiB of profiles (after benchmarks it's usually 20 GiB). So instrumenting stage 2 build provides a lot of data! I'll try what happens if we delete the profiles.

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 29, 2023
@bors
Copy link
Collaborator

bors commented May 29, 2023

⌛ Trying commit 31c917d813e3461b6babe1220a1ac15fc66eae53 with merge 3004a6cee0725e571674b0efdefcd9b82b1e11d6...

@bors
Copy link
Collaborator

bors commented May 29, 2023

☀️ Try build successful - checks-actions
Build commit: 3004a6cee0725e571674b0efdefcd9b82b1e11d6 (3004a6cee0725e571674b0efdefcd9b82b1e11d6)

@rust-timer

This comment has been minimized.

Sign in to view
@Kobzol
Copy link
Member Author

Kobzol commented May 29, 2023

@bors try

@bors
Copy link
Collaborator

bors commented May 29, 2023

⌛ Trying commit 042e02535bb5a95c8d6d77fc5954d762b73079e0 with merge ed48ba9307a0a1b523e3519499c3918be2dba056...

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3004a6cee0725e571674b0efdefcd9b82b1e11d6): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.2% [0.3%, 7.3%] 51
Regressions ❌
(secondary)		 3.1% [0.4%, 5.9%] 24
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 3.2% [0.3%, 7.3%] 51

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.5% [2.5%, 2.5%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.6% [0.8%, 4.1%] 32
Regressions ❌
(secondary)		 2.8% [1.8%, 3.6%] 12
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.6% [0.8%, 4.1%] 32

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 642.999s -> 642.878s (-0.02%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 29, 2023
@bors
Copy link
Collaborator

bors commented May 29, 2023

☀️ Try build successful - checks-actions
Build commit: ed48ba9307a0a1b523e3519499c3918be2dba056 (ed48ba9307a0a1b523e3519499c3918be2dba056)

@Kobzol
Copy link
Member Author

Kobzol commented May 29, 2023

@rust-timer build ed48ba9307a0a1b523e3519499c3918be2dba056

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ed48ba9307a0a1b523e3519499c3918be2dba056): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.0% [-2.0%, -0.3%] 33
Improvements ✅
(secondary)		 -1.1% [-1.5%, -0.4%] 12
All ❌✅ (primary) -1.0% [-2.0%, -0.3%] 33

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.5% [2.5%, 2.5%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.8% [-2.8%, -2.8%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 642.999s -> 644.35s (0.21%)

@rustbot rustbot removed the perf-regression Performance regression. label May 29, 2023
@Kobzol Kobzol force-pushed the pgo-omit-benchmarks branch from 34f589d to d20be04 Compare September 6, 2025 10:13
@Kobzol
Copy link
Member Author

Kobzol commented Sep 6, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Sep 6, 2025
@rust-bors
Auto merge of #112049 - Kobzol:pgo-omit-benchmarks, r=<try>
b7f4ece 
[do not merge] CI experiments

try-job: dist-x86_64-linux
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 6, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Sep 6, 2025

💔 Test for b7f4ece failed: CI. Failed jobs:

@Kobzol
Copy link
Member Author

Kobzol commented Sep 6, 2025

@bors try

rust-bors bot added a commit that referenced this pull request Sep 6, 2025
@rust-bors
Auto merge of #112049 - Kobzol:pgo-omit-benchmarks, r=<try>
71ea9a0 
[do not merge] CI experiments
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Sep 6, 2025

☀️ Try build successful (CI)
Build commit: 71ea9a0 (71ea9a0cacc3473c7b6852c17453259f74635c62, parent: 0d0f4eac8b98133e5da6d3604d86a8f3b5a67844)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (71ea9a0): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -8.4% [-36.7%, -0.2%] 67
Improvements ✅
(secondary)		 -4.5% [-18.5%, -0.1%] 88
All ❌✅ (primary) -8.4% [-36.7%, -0.2%] 67

Max RSS (memory usage)

Results (primary -5.8%, secondary -2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.3% [2.3%, 4.9%] 3
Improvements ✅
(primary)		 -5.8% [-16.9%, -0.6%] 27
Improvements ✅
(secondary)		 -4.2% [-8.6%, -2.3%] 11
All ❌✅ (primary) -5.8% [-16.9%, -0.6%] 27

Cycles

Results (primary -14.6%, secondary -9.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -14.6% [-37.1%, -3.0%] 40
Improvements ✅
(secondary)		 -9.4% [-21.2%, -2.1%] 41
All ❌✅ (primary) -14.6% [-37.1%, -3.0%] 40

Binary size

Results (primary -30.9%, secondary -25.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -30.9% [-62.4%, -0.2%] 79
Improvements ✅
(secondary)		 -25.5% [-69.9%, -0.0%] 86
All ❌✅ (primary) -30.9% [-62.4%, -0.2%] 79

Bootstrap: 469.522s -> 467.253s (-0.48%)
Artifact size: 390.39 MiB -> 387.98 MiB (-0.62%)

@rustbot rustbot removed S-waiting-on-perf Status: Waiting on a perf run to be completed. perf-regression Performance regression. labels Sep 6, 2025
@Kobzol Kobzol force-pushed the pgo-omit-benchmarks branch from d20be04 to 042b55c Compare September 6, 2025 19:52
@Kobzol Kobzol force-pushed the pgo-omit-benchmarks branch from 042b55c to f8ab528 Compare September 6, 2025 19:52
@Kobzol
Copy link
Member Author

Kobzol commented Sep 6, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Sep 6, 2025
@rust-bors
Auto merge of #112049 - Kobzol:pgo-omit-benchmarks, r=<try>
87c3e1e 
[do not merge] CI experiments
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 6, 2025
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu-llvm-19-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
failures:

---- [ui] tests/ui/backtrace/dylib-dep.rs stdout ----

error: test did not exit with success! code=None so test would pass with `run-crash`
status: signal: 6 (SIGABRT) (core dumped)
command: cd "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/backtrace/dylib-dep" && RUSTC="/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" RUST_TEST_THREADS="4" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/backtrace/dylib-dep/a"
stdout: none
--- stderr -------------------------------
-----------------------------------
looking for:
 /checkout/tests/ui/backtrace/dylib-dep.rs:71
 /checkout/tests/ui/backtrace/auxiliary/dylib-dep-helper.rs:18
 /checkout/tests/ui/backtrace/dylib-dep.rs:70
found:
Backtrace [
    { fn: "std::backtrace::Backtrace::create" },
    { fn: "dylib_dep::verify" },
    { fn: "dylib_dep::main::{{closure}}" },
    { fn: "core::ops::function::FnOnce::call_once" },
    { fn: "foo" },
    { fn: "dylib_dep::main" },
    { fn: "core::ops::function::FnOnce::call_once" },
    { fn: "std::sys::backtrace::__rust_begin_short_backtrace" },
    { fn: "std::rt::lang_start::{{closure}}" },
    { fn: "std::rt::lang_start_internal" },
    { fn: "std::rt::lang_start" },
    { fn: "main" },
    { fn: "__libc_start_main" },
    { fn: "_start" },
]

thread 'main' (38322) panicked at /checkout/tests/ui/backtrace/dylib-dep.rs:54:9:
expected backtrace to contain /checkout/tests/ui/backtrace/dylib-dep.rs
stack backtrace:
---
   5:     0xff96b82caed0 - std::panicking::default_hook::hd1a577fc5053f09c
   6:     0xff96b82cb7ac - std::panicking::panic_with_hook::h2973796ec5d30ef0
   7:     0xff96b82cb478 - std::panicking::panic_handler::{{closure}}::h4a64dc5c3964fbce
   8:     0xff96b82c2ffc - std::sys::backtrace::__rust_end_short_backtrace::hb766245a6dab5fff
   9:     0xff96b829d150 - __rustc[31a1d40a898edf36]::rust_begin_unwind
  10:     0xff96b829ca74 - core::panicking::panic_nounwind_fmt::h7c21b61993f09eb7
  11:     0xff96b829c9d4 - core::panicking::panic_nounwind::h78c9a8a171c43981
  12:     0xff96b829cb9c - core::panicking::panic_cannot_unwind::hbbac1401733d5811
  13:     0xff96b83f079c - foo
  14:     0xab585da668d8 - dylib_dep::main::ha3017fb5e5b597b8
  15:     0xab585da632f4 - core::ops::function::FnOnce::call_once::ha271f0bbefb8356c
  16:     0xab585da62dec - std::sys::backtrace::__rust_begin_short_backtrace::h7be4f4c43a191c20
  17:     0xab585da62bf4 - std::rt::lang_start::{{closure}}::h703f3628e10efd30
  18:     0xff96b82aff40 - std::rt::lang_start_internal::h1bbb75fa8a73a0c1
  19:     0xab585da62bd8 - std::rt::lang_start::h26402063e550b883
---

---- [ui] tests/ui/backtrace/dylib-dep.rs stdout end ----
---- [ui] tests/ui/backtrace/line-tables-only.rs stdout ----

error: test did not exit with success! code=Some(101) so test would pass with `run-fail`
status: exit status: 101
command: cd "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/backtrace/line-tables-only" && RUSTC="/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" RUST_TEST_THREADS="4" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/backtrace/line-tables-only/a"
stdout: none
--- stderr -------------------------------
Backtrace [
    { fn: "std::backtrace::Backtrace::create" },
    { fn: "line_tables_only_helper::capture_backtrace::{{closure}}" },
    { fn: "baz" },
    { fn: "bar" },
    { fn: "foo" },
    { fn: "line_tables_only_helper::capture_backtrace" },
    { fn: "line_tables_only::main" },
    { fn: "std::sys::backtrace::__rust_begin_short_backtrace" },
    { fn: "std::rt::lang_start::{{closure}}" },
    { fn: "std::rt::lang_start_internal" },
    { fn: "main" },
    { fn: "__libc_start_main" },
    { fn: "_start" },
]

thread 'main' (38331) panicked at /checkout/tests/ui/backtrace/line-tables-only.rs:34:5:
backtrace does not contain expected file line-tables-only-helper.rs
stack backtrace:
---

---- [ui] tests/ui/backtrace/line-tables-only.rs stdout end ----
---- [ui] tests/ui/codegen/remark-flag-functionality.rs#all stdout ----

error in revision `all`: 1 diagnostics reported in JSON output but not expected in test file
tests/ui/codegen/remark-flag-functionality.rs:?: WARN: -C remark requires "-C debuginfo=n" to show source locations

thread '[ui] tests/ui/codegen/remark-flag-functionality.rs#all' panicked at src/tools/compiletest/src/runtest.rs:909:13:
errors differ from expected
status: exit status: 0
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/codegen/remark-flag-functionality.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--cfg" "all" "--check-cfg" "cfg(test,FALSE,all,inline,merge1,merge2)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/codegen/remark-flag-functionality.all" "-A" "unused" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type=lib" "-Cdebuginfo=1" "-Copt-level=2" "-Cremark=all"

stack backtrace:
   8: __rustc::rust_begin_unwind
             at /rustc/788da80fcfcef3f34c90def5baa32813e39a1a41/library/std/src/panicking.rs:697:5
   9: core::panicking::panic_fmt
---
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
---- [ui] tests/ui/codegen/remark-flag-functionality.rs#all stdout end ----
---- [ui] tests/ui/codegen/remark-flag-functionality.rs#inline stdout ----

error in revision `inline`: 1 diagnostics reported in JSON output but not expected in test file
tests/ui/codegen/remark-flag-functionality.rs:?: WARN: -C remark requires "-C debuginfo=n" to show source locations

thread '[ui] tests/ui/codegen/remark-flag-functionality.rs#inline' panicked at src/tools/compiletest/src/runtest.rs:909:13:
errors differ from expected
status: exit status: 0
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/codegen/remark-flag-functionality.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--cfg" "inline" "--check-cfg" "cfg(test,FALSE,all,inline,merge1,merge2)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/codegen/remark-flag-functionality.inline" "-A" "unused" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type=lib" "-Cdebuginfo=1" "-Copt-level=2" "-Cremark=inline"

stack backtrace:
   8: __rustc::rust_begin_unwind
             at /rustc/788da80fcfcef3f34c90def5baa32813e39a1a41/library/std/src/panicking.rs:697:5
   9: core::panicking::panic_fmt
---
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
---- [ui] tests/ui/codegen/remark-flag-functionality.rs#inline stdout end ----
---- [ui] tests/ui/codegen/remark-flag-functionality.rs#merge1 stdout ----

error in revision `merge1`: 1 diagnostics reported in JSON output but not expected in test file
tests/ui/codegen/remark-flag-functionality.rs:?: WARN: -C remark requires "-C debuginfo=n" to show source locations

thread '[ui] tests/ui/codegen/remark-flag-functionality.rs#merge1' panicked at src/tools/compiletest/src/runtest.rs:909:13:
errors differ from expected
status: exit status: 0
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/codegen/remark-flag-functionality.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--cfg" "merge1" "--check-cfg" "cfg(test,FALSE,all,inline,merge1,merge2)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/codegen/remark-flag-functionality.merge1" "-A" "unused" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type=lib" "-Cdebuginfo=1" "-Copt-level=2" "-Cremark=all" "-Cremark=giraffe"

stack backtrace:
   8: __rustc::rust_begin_unwind
             at /rustc/788da80fcfcef3f34c90def5baa32813e39a1a41/library/std/src/panicking.rs:697:5
   9: core::panicking::panic_fmt
---
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
---- [ui] tests/ui/codegen/remark-flag-functionality.rs#merge1 stdout end ----
---- [ui] tests/ui/codegen/remark-flag-functionality.rs#merge2 stdout ----

error in revision `merge2`: 1 diagnostics reported in JSON output but not expected in test file
tests/ui/codegen/remark-flag-functionality.rs:?: WARN: -C remark requires "-C debuginfo=n" to show source locations

thread '[ui] tests/ui/codegen/remark-flag-functionality.rs#merge2' panicked at src/tools/compiletest/src/runtest.rs:909:13:
errors differ from expected
status: exit status: 0
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/codegen/remark-flag-functionality.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--cfg" "merge2" "--check-cfg" "cfg(test,FALSE,all,inline,merge1,merge2)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/codegen/remark-flag-functionality.merge2" "-A" "unused" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type=lib" "-Cdebuginfo=1" "-Copt-level=2" "-Cremark=inline" "-Cremark=giraffe"

stack backtrace:
   8: __rustc::rust_begin_unwind
             at /rustc/788da80fcfcef3f34c90def5baa32813e39a1a41/library/std/src/panicking.rs:697:5
   9: core::panicking::panic_fmt
---
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
---- [ui] tests/ui/codegen/remark-flag-functionality.rs#merge2 stdout end ----
---- [ui] tests/ui/runtime/backtrace-debuginfo.rs stdout ----

error: test did not exit with success! code=Some(101) so test would pass with `run-fail`
status: exit status: 101
command: cd "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/runtime/backtrace-debuginfo" && RUSTC="/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" RUST_TEST_THREADS="4" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/runtime/backtrace-debuginfo/a"
--- stdout -------------------------------
---------------------------------------
trace does not match position list
still need to find ["backtrace-debuginfo.rs:192", "backtrace-debuginfo.rs:128"]

--- stdout
backtrace-debuginfo.rs:128
backtrace-debuginfo.rs:192

---
  21:     0xab0b4b4c4630 - _start
  22:                0x0 - <unknown>

---------------------------------------
trace does not match position list
still need to find ["backtrace-debuginfo.rs:192", "backtrace-debuginfo.rs:128"]

--- stdout
backtrace-debuginfo.rs:128
backtrace-debuginfo.rs:192

---
  21:     0xaad169194630 - _start
  22:                0x0 - <unknown>

---------------------------------------
trace does not match position list
still need to find ["backtrace-debuginfo.rs:192", "backtrace-debuginfo.rs:128", "backtrace-debuginfo.rs:91", "backtrace-debuginfo-aux.rs:5"]

--- stdout
backtrace-debuginfo-aux.rs:5
backtrace-debuginfo.rs:91
backtrace-debuginfo.rs:128
---
   7:     0xffc7264eabf0 - std::panicking::begin_panic::{{closure}}::hfa9107486f600ab8
   8:     0xffc7264e2ff0 - std::sys::backtrace::__rust_end_short_backtrace::h836790cf212a51ad
   9:     0xffc7264b7124 - std::panicking::begin_panic::h8bf922836b51605e
  10:     0xaac5237c6484 - backtrace_debuginfo::inner::{{closure}}::hcd667a4d6c445e28
  11:     0xaac5237c5f2c - backtrace_debuginfo::aux::callback::hf5e9cb74b2af0a69
  12:     0xaac5237c6320 - backtrace_debuginfo::inner::h74f38559f4d22d45
  13:     0xaac5237c6674 - backtrace_debuginfo::outer::he646e4089de0c9bd
  14:     0xaac5237c615c - backtrace_debuginfo::main::h424f5d8817c1d699
  15:     0xaac5237c92cc - core::ops::function::FnOnce::call_once::h037484952a913599
  16:     0xaac5237c80e0 - std::sys::backtrace::__rust_begin_short_backtrace::heb70b16d7413e8f1
---
  23:     0xaac5237c4630 - _start
  24:                0x0 - <unknown>

---------------------------------------
trace does not match position list
still need to find ["backtrace-debuginfo.rs:192", "backtrace-debuginfo.rs:128", "backtrace-debuginfo.rs:94", "backtrace-debuginfo-aux.rs:12"]

--- stdout
backtrace-debuginfo-aux.rs:12
backtrace-debuginfo.rs:94
backtrace-debuginfo.rs:128
---
  22:     0xab93a9e74630 - _start
  23:                0x0 - <unknown>

---------------------------------------
trace does not match position list
still need to find ["backtrace-debuginfo.rs:192", "backtrace-debuginfo.rs:129"]

--- stdout
backtrace-debuginfo.rs:129
backtrace-debuginfo.rs:192

---
  20:     0xab4c1d904630 - _start
  21:                0x0 - <unknown>

---------------------------------------
trace does not match position list
still need to find ["backtrace-debuginfo.rs:192", "backtrace-debuginfo.rs:129"]

--- stdout
backtrace-debuginfo.rs:129
backtrace-debuginfo.rs:192

---
  20:     0xab3645e24630 - _start
  21:                0x0 - <unknown>

---------------------------------------
trace does not match position list
still need to find ["backtrace-debuginfo.rs:192", "backtrace-debuginfo.rs:129", "backtrace-debuginfo.rs:112"]

--- stdout
backtrace-debuginfo.rs:112
backtrace-debuginfo.rs:129
backtrace-debuginfo.rs:192
---
  20:     0xab22f9824630 - _start
  21:                0x0 - <unknown>

---------------------------------------
trace does not match position list
still need to find ["backtrace-debuginfo.rs:192", "backtrace-debuginfo.rs:129", "backtrace-debuginfo.rs:114", "backtrace-debuginfo-aux.rs:5"]

--- stdout
backtrace-debuginfo-aux.rs:5
backtrace-debuginfo.rs:114
backtrace-debuginfo.rs:129
---
   7:     0xff394f08abf0 - std::panicking::begin_panic::{{closure}}::hfa9107486f600ab8
   8:     0xff394f082ff0 - std::sys::backtrace::__rust_end_short_backtrace::h836790cf212a51ad
   9:     0xff394f057124 - std::panicking::begin_panic::h8bf922836b51605e
  10:     0xab503cc55d1c - backtrace_debuginfo::inner_inlined::{{closure}}::h9789430e5c825105
  11:     0xab503cc55ee0 - backtrace_debuginfo::aux::callback::h43111d5497a69cac
  12:     0xab503cc56914 - backtrace_debuginfo::outer::he646e4089de0c9bd
  13:     0xab503cc5615c - backtrace_debuginfo::main::h424f5d8817c1d699
  14:     0xab503cc592cc - core::ops::function::FnOnce::call_once::h037484952a913599
  15:     0xab503cc580e0 - std::sys::backtrace::__rust_begin_short_backtrace::heb70b16d7413e8f1
  16:     0xab503cc57f44 - std::rt::lang_start::{{closure}}::hd57860ea37ec4396
  17:     0xff394f06ff40 - std::rt::lang_start_internal::h1bbb75fa8a73a0c1
  18:     0xab503cc57f28 - std::rt::lang_start::h4628e61c7f1a0761
  19:     0xab503cc62f38 - main
  20:     0xff394ee22294 - <unknown>
  21:     0xff394ee22378 - __libc_start_main
  22:     0xab503cc54630 - _start
  23:                0x0 - <unknown>

---------------------------------------
trace does not match position list
still need to find ["backtrace-debuginfo.rs:192", "backtrace-debuginfo.rs:129", "backtrace-debuginfo.rs:117", "backtrace-debuginfo-aux.rs:12"]

--- stdout
backtrace-debuginfo-aux.rs:12
backtrace-debuginfo.rs:117
backtrace-debuginfo.rs:129
---
  21:     0xab3c66cb4630 - _start
  22:                0x0 - <unknown>

---------------------------------------
trace does not match position list
still need to find ["backtrace-debuginfo.rs:192", "backtrace-debuginfo.rs:129", "backtrace-debuginfo.rs:123"]

--- stdout
backtrace-debuginfo.rs:123
backtrace-debuginfo.rs:129
backtrace-debuginfo.rs:192

@rust-bors
Copy link

rust-bors bot commented Sep 6, 2025

☀️ Try build successful (CI)
Build commit: 87c3e1e (87c3e1ecd699573f7cb4c9074b8727956bd37a74, parent: bea625f3275e3c897dc965ed97a1d19ef7831f01)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (87c3e1e): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -12.4% [-42.8%, -0.1%] 80
Improvements ✅
(secondary)		 -8.6% [-34.3%, -0.1%] 102
All ❌✅ (primary) -12.4% [-42.8%, -0.1%] 80

Max RSS (memory usage)

Results (primary -6.6%, secondary -5.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.8% [3.8%, 3.8%] 1
Improvements ✅
(primary)		 -6.6% [-23.0%, -1.3%] 50
Improvements ✅
(secondary)		 -6.0% [-25.1%, -2.0%] 23
All ❌✅ (primary) -6.6% [-23.0%, -1.3%] 50

Cycles

Results (primary -19.2%, secondary -14.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -19.2% [-42.7%, -2.1%] 50
Improvements ✅
(secondary)		 -14.6% [-35.1%, -2.3%] 54
All ❌✅ (primary) -19.2% [-42.7%, -2.1%] 50

Binary size

Results (primary -45.2%, secondary -56.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -45.2% [-88.5%, -0.2%] 83
Improvements ✅
(secondary)		 -56.6% [-88.6%, -0.0%] 88
All ❌✅ (primary) -45.2% [-88.5%, -0.2%] 83

Bootstrap: 468.001s -> 465.788s (-0.47%)
Artifact size: 387.44 MiB -> 379.64 MiB (-2.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Kobzol Kobzol

Labels
A-CI Area: Our Github Actions CI A-compiletest Area: The compiletest test runner A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-testsuite Area: The testsuite used to check the correctness of rustc A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.