Skip to content

Build Fuchsia tests in CI #119399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Build Fuchsia tests in CI #119399

wants to merge 7 commits into from

Conversation

tmandry
Copy link
Member

@tmandry tmandry commented Dec 29, 2023 •
edited
Loading

This would have caught rust-lang/rust-clippy#11952 and #119593.

@rustbot

This comment was marked as outdated.

Sign in to view
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 29, 2023
@tmandry
Copy link
Member Author

tmandry commented Dec 29, 2023

r? @ghost

@rustbot

This comment was marked as off-topic.

Sign in to view
@tmandry
Copy link
Member Author

tmandry commented Dec 29, 2023

Looks like baseline is about 38m, let's see how this goes...

@bors try

@bors
Copy link
Collaborator

bors commented Dec 29, 2023

⌛ Trying commit 97b9519 with merge 21d39f0...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 29, 2023
@bors
Auto merge of rust-lang#119399 - tmandry:build-fuchsia-tests, r=<try>
21d39f0 
Build Fuchsia tests in CI

This would have caught rust-lang/rust-clippy#11952.
@tmandry tmandry force-pushed the build-fuchsia-tests branch from 97b9519 to 2340efa Compare December 29, 2023 00:33
@tmandry
Copy link
Member Author

tmandry commented Dec 29, 2023

@bors try

@bors
Copy link
Collaborator

bors commented Dec 29, 2023

⌛ Trying commit 88026c2 with merge 0bfe718...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 29, 2023
@bors
Auto merge of rust-lang#119399 - tmandry:build-fuchsia-tests, r=<try>
0bfe718 
Build Fuchsia tests in CI

This would have caught rust-lang/rust-clippy#11952.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tmandry
Copy link
Member Author

tmandry commented Dec 29, 2023

Looks like we are catching some new ICEs. Yay coverage!

@bors
Copy link
Collaborator

bors commented Dec 29, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2023
@tmandry tmandry mentioned this pull request Jan 3, 2024
Closed
@tmandry
Copy link
Member Author

tmandry commented Jan 23, 2024

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 23, 2024
@bors
Auto merge of rust-lang#119399 - tmandry:build-fuchsia-tests, r=<try>
174fe66 
Build Fuchsia tests in CI

This would have caught rust-lang/rust-clippy#11952 and rust-lang#119593.
@bors

This comment was marked as outdated.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

This comment was marked as outdated.

Sign in to view
@tmandry
Copy link
Member Author

tmandry commented Jan 24, 2024

@bors try

@bors
Copy link
Collaborator

bors commented Jan 24, 2024

⌛ Trying commit ed3db05 with merge c8259ec...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 24, 2024
@bors
Auto merge of rust-lang#119399 - tmandry:build-fuchsia-tests, r=<try>
c8259ec 
Build Fuchsia tests in CI

This would have caught rust-lang/rust-clippy#11952 and rust-lang#119593.
@rust-log-analyzer

This comment was marked as off-topic.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jan 24, 2024

☀️ Try build successful - checks-actions
Build commit: c8259ec (c8259ec037be0f4b317a6fc7e3ce244c1566d604)

@tmandry
Copy link
Member Author

tmandry commented Jan 25, 2024

Success! Let's try everything together now.

@bors try

@bors
Copy link
Collaborator

bors commented Jan 25, 2024

⌛ Trying commit 7e359e7 with merge f029dfb...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 25, 2024
@bors
Auto merge of rust-lang#119399 - tmandry:build-fuchsia-tests, r=<try>
f029dfb 
Build Fuchsia tests in CI

This would have caught rust-lang/rust-clippy#11952 and rust-lang#119593.
@rust-log-analyzer

This comment was marked as off-topic.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jan 25, 2024

☀️ Try build successful - checks-actions
Build commit: f029dfb (f029dfb0acaf030a23cb3b3b6afb0baf18f23327)

@tmandry tmandry mentioned this pull request Jan 26, 2024
Merged
@tmandry
Copy link
Member Author

tmandry commented Jan 26, 2024

Continuing in #120358.

@tmandry tmandry closed this Jan 26, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 26, 2024
@bors
Auto merge of rust-lang#120358 - tmandry:bump-fuchsia-8c-tests, r=<try>
6b66035 
Bump Fuchsia, build tests, and use 8 core bots

- Build Fuchsia on 8 cores instead of 16
- Skip building cranelift for Fuchsia
- Bump Fuchsia (includes building tests)

This includes a change to the upstream build_fuchsia_from_rust_ci script that builds a minimal set of tests, to improve coverage on this builder.

See prior discussion on rust-lang#119400 about building on 8 cores instead of 16. This PR combines changes from that and rust-lang#119399, plus clean up.

r? `@Mark-Simulacrum`
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 26, 2024
@bors
Auto merge of rust-lang#120358 - tmandry:bump-fuchsia-8c-tests, r=<try>
4134524 
Bump Fuchsia, build tests, and use 8 core bots

- Build Fuchsia on 8 cores instead of 16
- Skip building cranelift for Fuchsia
- Bump Fuchsia (includes building tests)

This includes a change to the upstream build_fuchsia_from_rust_ci script that builds a minimal set of tests, to improve coverage on this builder.

See prior discussion on rust-lang#119400 about building on 8 cores instead of 16. This PR combines changes from that and rust-lang#119399, plus clean up.

r? `@Mark-Simulacrum`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 27, 2024
@matthiaskrgr
Rollup merge of rust-lang#120358 - tmandry:bump-fuchsia-8c-tests, r=M…
612ee18 
…ark-Simulacrum

Bump Fuchsia, build tests, and use 8 core bots

- Build Fuchsia on 8 cores instead of 16
- Skip building cranelift for Fuchsia
- Bump Fuchsia (includes building tests)

This includes a change to the upstream build_fuchsia_from_rust_ci script that builds a minimal set of tests, to improve coverage on this builder. This would have caught rust-lang/rust-clippy#11952 and rust-lang#119593.

See prior discussion on rust-lang#119400 about building on 8 cores instead of 16. This PR combines changes from that and rust-lang#119399, plus clean up.

r? `@Mark-Simulacrum`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 27, 2024
@matthiaskrgr
Rollup merge of rust-lang#120358 - tmandry:bump-fuchsia-8c-tests, r=M…
68b39be 
…ark-Simulacrum

Bump Fuchsia, build tests, and use 8 core bots

- Build Fuchsia on 8 cores instead of 16
- Skip building cranelift for Fuchsia
- Bump Fuchsia (includes building tests)

This includes a change to the upstream build_fuchsia_from_rust_ci script that builds a minimal set of tests, to improve coverage on this builder. This would have caught rust-lang/rust-clippy#11952 and rust-lang#119593.

See prior discussion on rust-lang#119400 about building on 8 cores instead of 16. This PR combines changes from that and rust-lang#119399, plus clean up.

r? ``@Mark-Simulacrum``
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 27, 2024
@matthiaskrgr
Rollup merge of rust-lang#120358 - tmandry:bump-fuchsia-8c-tests, r=M…
28a6e29 
…ark-Simulacrum

Bump Fuchsia, build tests, and use 8 core bots

- Build Fuchsia on 8 cores instead of 16
- Skip building cranelift for Fuchsia
- Bump Fuchsia (includes building tests)

This includes a change to the upstream build_fuchsia_from_rust_ci script that builds a minimal set of tests, to improve coverage on this builder. This would have caught rust-lang/rust-clippy#11952 and rust-lang#119593.

See prior discussion on rust-lang#119400 about building on 8 cores instead of 16. This PR combines changes from that and rust-lang#119399, plus clean up.

r? ```@Mark-Simulacrum```
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 28, 2024
@matthiaskrgr
Rollup merge of rust-lang#120358 - tmandry:bump-fuchsia-8c-tests, r=M…
9af1a77 
…ark-Simulacrum

Bump Fuchsia, build tests, and use 8 core bots

- Build Fuchsia on 8 cores instead of 16
- Skip building cranelift for Fuchsia
- Bump Fuchsia (includes building tests)

This includes a change to the upstream build_fuchsia_from_rust_ci script that builds a minimal set of tests, to improve coverage on this builder. This would have caught rust-lang/rust-clippy#11952 and rust-lang#119593.

See prior discussion on rust-lang#119400 about building on 8 cores instead of 16. This PR combines changes from that and rust-lang#119399, plus clean up.

r? ````@Mark-Simulacrum````
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 28, 2024
@matthiaskrgr
Rollup merge of rust-lang#120358 - tmandry:bump-fuchsia-8c-tests, r=M…
b5b89f6 
…ark-Simulacrum

Bump Fuchsia, build tests, and use 8 core bots

- Build Fuchsia on 8 cores instead of 16
- Skip building cranelift for Fuchsia
- Bump Fuchsia (includes building tests)

This includes a change to the upstream build_fuchsia_from_rust_ci script that builds a minimal set of tests, to improve coverage on this builder. This would have caught rust-lang/rust-clippy#11952 and rust-lang#119593.

See prior discussion on rust-lang#119400 about building on 8 cores instead of 16. This PR combines changes from that and rust-lang#119399, plus clean up.

r? `````@Mark-Simulacrum`````
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 31, 2024
@bors
Auto merge of rust-lang#120358 - tmandry:bump-fuchsia-8c-tests, r=Mar…
cdaa12e 
…k-Simulacrum

Bump Fuchsia, build tests, and use 8 core bots

- Build Fuchsia on 8 cores instead of 16
- Skip building cranelift for Fuchsia
- Bump Fuchsia (includes building tests)

This includes a change to the upstream build_fuchsia_from_rust_ci script that builds a minimal set of tests, to improve coverage on this builder. This would have caught rust-lang/rust-clippy#11952 and rust-lang#119593.

See prior discussion on rust-lang#119400 about building on 8 cores instead of 16. This PR combines changes from that and rust-lang#119399, plus clean up.

r? `@Mark-Simulacrum`
@workingjubilee workingjubilee added the O-fuchsia Operating system: Fuchsia label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-fuchsia Operating system: Fuchsia S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tmandry @rustbot @bors @rust-log-analyzer @Kobzol @workingjubilee