Use copied instead of manual map
#117549
Merged
Use copied instead of manual map
#117549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
petrochenkov
reviewed
Nov 3, 2023
| @@ -41,8 +41,7 @@ impl<'hir> LoweringContext<'_, 'hir> { | |||
| } | |||
| // Merge attributes into the inner expression. | |||
| if !e.attrs.is_empty() { | |||
| let old_attrs = | |||
| self.attrs.get(&ex.hir_id.local_id).map(|la| *la).unwrap_or(&[]); | |||
| let old_attrs = self.attrs.get(&ex.hir_id.local_id).copied().unwrap_or(&[]); | |||
There was a problem hiding this comment.
Suggested change
| let old_attrs = self.attrs.get(&ex.hir_id.local_id).copied().unwrap_or(&[]); | |
| let old_attrs = self.attrs.get(&ex.hir_id.local_id).copied().unwrap_or_default(); |
There was a problem hiding this comment.
I don't feel strongly about it, but very slightly prefer unwrap_or: it's both fewer keystrokes and slightly less cognitive load for the reader (no need to consider the type or what its Default implementation is).
There was a problem hiding this comment.
Both are present in the codebase, I don't think this should be changed, but if anything I think it should be in a follow-up PR.
|
@bors r+ rollup |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 17, 2023
Use `copied` instead of manual `map`
This was referenced Nov 17, 2023
|
How did you find these? Is it a clippy lint? |
Apparently there is one: https://rust-lang.github.io/rust-clippy/master/#/map_clone |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 17, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#117338 (Remove asmjs) - rust-lang#117549 (Use `copied` instead of manual `map`) - rust-lang#117745 (Emit smir) - rust-lang#117964 (When using existing fn as module, don't claim it doesn't exist) - rust-lang#118006 (clarify `fn discriminant` guarantees: only free lifetimes may get erased) - rust-lang#118016 (Add stable mir members to triagebot config) - rust-lang#118022 (Miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 18, 2023
Rollup merge of rust-lang#117549 - DaniPopes:more-copied, r=b-naber Use `copied` instead of manual `map`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.