When not finding assoc fn on type, look for builder fn #117006

estebank · 2023-10-21T01:18:53Z

When we have a resolution error when looking at a fully qualified path on a type, look for all associated functions on inherent impls that return Self and mention them to the user.

error[E0599]: no function or associated item named `new` found for struct `TcpStream` in the current scope
   --> tests/ui/resolve/fn-new-doesnt-exist.rs:4:28
    |
4   |    let stream = TcpStream::new();
    |                            ^^^ function or associated item not found in `TcpStream`
    |
note: if you're trying to build a new `TcpStream` consider using one of the following associated functions:
      TcpStream::connect
      TcpStream::connect_timeout
   --> /home/gh-estebank/rust/library/std/src/net/tcp.rs:156:5
    |
156 |     pub fn connect<A: ToSocketAddrs>(addr: A) -> io::Result<TcpStream> {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
172 |     pub fn connect_timeout(addr: &SocketAddr, timeout: Duration) -> io::Result<TcpStream> {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Fix #69512.

rustbot · 2023-10-21T01:19:00Z

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

tests/ui/issues/issue-42880.stderr

tests/ui/resolve/issue-82865.stderr

compiler/rustc_hir_typeck/src/method/suggest.rs

davidtwco · 2023-11-04T01:13:24Z

Sorry for the delay in getting to this, will re-assign to compiler-errors since they've left a review already.

r? @compiler-errors

compiler-errors

r=me after addressing

tests/ui/parser/emoji-identifiers.stderr

tests/ui/issues/issue-42880.stderr

compiler-errors · 2023-11-06T23:04:07Z

compiler/rustc_hir_typeck/src/method/suggest.rs

@@ -408,6 +408,86 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
            err.downgrade_to_delayed_bug();
        }

+        if let (ty::Adt(adt_def, _), SelfSource::QPath(_)) = (rcvr_ty.kind(), source) {


please pull this out into a method. Also, can you use a let-chain here instead of destructuring a tuple?

I tend to use tuple destructuring in favor of let-chains when I want to make sure rustfmt works, particularly in long blocks. I can change it, of course. I personally like let-chains more.

When we have a resolution error when looking at a fully qualified path on a type, look for all associated functions on inherent impls that return `Self` and mention them to the user. Fix rust-lang#69512.

estebank · 2023-11-07T00:58:48Z

@bors r=compiler-errors

bors · 2023-11-07T00:58:51Z

📌 Commit f926031 has been approved by compiler-errors

It is now in the queue for this repository.

bors · 2023-11-07T02:05:33Z

⌛ Testing commit f926031 with merge 4e0fb98...

bors · 2023-11-07T04:02:45Z

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 4e0fb98 to master...

89: Automated pull from upstream `master` r=Dajamante a=github-actions[bot] This PR pulls the following changes from the upstream repository: * rust-lang/rust#117006 * rust-lang/rust#117511 * rust-lang/rust#117641 * rust-lang/rust#117637 * rust-lang/rust#117631 * rust-lang/rust#117516 * rust-lang/rust#117190 * rust-lang/rust#117292 * rust-lang/rust#117603 * rust-lang/rust#116988 * rust-lang/rust#117630 * rust-lang/rust#117615 * rust-lang/rust#117613 * rust-lang/rust#117592 * rust-lang/rust#117578 * rust-lang/rust#117435 * rust-lang/rust#117607 90: bump serde and serde_derive r=tshepang a=Dajamante Trying to get around the failure seen in #86 Co-authored-by: Ralf Jung <post@ralfj.de> Co-authored-by: Esteban Küber <esteban@kuber.com.ar> Co-authored-by: SparrowLii <liyuan179@huawei.com> Co-authored-by: Matthias Krüger <matthias.krueger@famsik.de> Co-authored-by: Gurinder Singh <frederick.the.fool@gmail.com> Co-authored-by: Michael Goulet <michael@errs.io> Co-authored-by: Thom Chiovoloni <thom@shift.click> Co-authored-by: klensy <klensy@users.noreply.github.com> Co-authored-by: Jack Huey <31162821+jackh726@users.noreply.github.com> Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com> Co-authored-by: hkalbasi <hamidrezakalbasi@protonmail.com> Co-authored-by: bors <bors@rust-lang.org> Co-authored-by: Sven Marnach <sven@mozilla.com> Co-authored-by: Rémy Rakic <remy.rakic+github@gmail.com> Co-authored-by: aissata <aimaiga2@gmail.com>

rust-timer · 2023-11-07T12:32:39Z

Finished benchmarking commit (4e0fb98): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-0.3%, -0.3%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.7%, 0.7%]	1
Regressions ❌ (secondary)	1.6%	[1.2%, 3.6%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-2.9%, -2.6%]	2
All ❌✅ (primary)	0.7%	[0.7%, 0.7%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[1.9%, 3.2%]	3
Improvements ✅ (primary)	-0.6%	[-0.8%, -0.5%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.6%	[-0.8%, -0.5%]	2

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Bootstrap: 662.627s -> 663.851s (0.18%)
Artifact size: 308.96 MiB -> 309.01 MiB (0.02%)

…stebank Method suggestion code tweaks I was rummaging around the method suggestion code after rust-lang#117006 (comment) and saw a few things to simplify. This is two unrelated commits, both in the same file. Review them separately, if you'd like. r? estebank

Rollup merge of rust-lang#117655 - compiler-errors:method-tweaks, r=estebank Method suggestion code tweaks I was rummaging around the method suggestion code after rust-lang#117006 (comment) and saw a few things to simplify. This is two unrelated commits, both in the same file. Review them separately, if you'd like. r? estebank

Update Rust toolchain from nightly-2023-11-07 to nightly-2023-11-08 without any other source changes. This is an automatically generated pull request. If any of the CI checks fail, manual intervention is required. In such a case, review the changes at https://github.com/rust-lang/rust from rust-lang@189d6c7 up to rust-lang@7adc89b. The log for this commit range is: rust-lang@7adc89b69b Auto merge of rust-lang#117680 - matthiaskrgr:rollup-kgaa4ma, r=matthiaskrgr rust-lang@518fe492f1 Rollup merge of rust-lang#117675 - zmodem:vectorize_h, r=durin42 rust-lang@f6f6fd1d1a Rollup merge of rust-lang#117639 - rustbot:docs-update, r=ehuss rust-lang@f8c67704f2 Rollup merge of rust-lang#117616 - RalfJung:unstable-target-features, r=compiler-errors rust-lang@cd5b5e08fe Rollup merge of rust-lang#115485 - DaniPopes:rustdoc-macro-consts, r=jackh726,fmease rust-lang@118a2deea5 Auto merge of rust-lang#117617 - Urgau:bump-libc-0.2.150, r=Mark-Simulacrum rust-lang@84abf837b8 manually bless a wasm-only test rust-lang@752a6132e5 llvm-wrapper: Remove include of non-existant Vectorize.h rust-lang@9bd71afb90 Auto merge of rust-lang#115904 - notriddle:notriddle/preload-bold, r=GuillaumeGomez rust-lang@187d1afa9d Auto merge of rust-lang#117297 - clubby789:fn-trait-missing-paren, r=TaKO8Ki rust-lang@61a3eea804 Auto merge of rust-lang#117229 - matthewjasper:thir-unsafeck-fixes, r=cjgillot rust-lang@114f1f6838 Auto merge of rust-lang#117610 - compiler-errors:object-hmm, r=aliemjay rust-lang@504f63efb0 Auto merge of rust-lang#117418 - compiler-errors:better_error_body, r=oli-obk rust-lang@4e0fb98a5c Auto merge of rust-lang#117006 - estebank:issue-69512, r=compiler-errors rust-lang@f926031ea5 When not finding assoc fn on type, look for builder fn rust-lang@7b97a5ca84 Auto merge of rust-lang#117511 - gurry:117406-err-packed-structs, r=compiler-errors rust-lang@5a9f07cc97 Build a better MIR body when errors are encountered rust-lang@171d5587ca Don't instantiate the binder twice when assembling object candidate rust-lang@24e14dd8b4 Only check predicates for late-bound non-lifetime vars in object candidate assembly rust-lang@bf65e3bddb Update books rust-lang@868de8e76b Visit patterns in THIR let expressions rust-lang@2b59992736 Add suggestion to THIR unsafe_op_in_unsafe_fn lint rust-lang@2b2c0f9886 Allow tests with rust-rustfix and revisions rust-lang@931692fa13 Recognise thread local statics in THIR unsafeck rust-lang@b85c6835d0 warn when using an unstable feature with -Ctarget-feature rust-lang@15719a8c1d libc: bump dependency to 0.2.150 rust-lang@4b3ece475d Emit explanatory note for move errors in packed struct derives rust-lang@904aceec7d Give a better diagnostic for missing parens in Fn* bounds rust-lang@2b858b7eb8 Format macro const literals with pretty printer rust-lang@2a92981301 rustdoc: stop preloading Source Serif 4 Bold Co-authored-by: celinval <celinval@users.noreply.github.com> Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com>

rustbot assigned davidtwco Oct 21, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 21, 2023

compiler-errors reviewed Oct 21, 2023

View reviewed changes

tests/ui/issues/issue-42880.stderr Outdated Show resolved Hide resolved

compiler-errors reviewed Oct 21, 2023

View reviewed changes

tests/ui/resolve/issue-82865.stderr Show resolved Hide resolved

compiler-errors reviewed Oct 21, 2023

View reviewed changes

compiler/rustc_hir_typeck/src/method/suggest.rs Outdated Show resolved Hide resolved

estebank force-pushed the issue-69512 branch from aa030d0 to 1158985 Compare October 21, 2023 15:51

This comment has been minimized.

Sign in to view

estebank force-pushed the issue-69512 branch from 1158985 to d26584d Compare October 21, 2023 17:15

This comment was marked as resolved.

Sign in to view

This comment was marked as outdated.

Sign in to view

estebank force-pushed the issue-69512 branch from d26584d to 22633fe Compare October 23, 2023 18:25

This comment has been minimized.

Sign in to view

estebank force-pushed the issue-69512 branch from 22633fe to 593276c Compare October 23, 2023 23:36

rustbot assigned compiler-errors and unassigned davidtwco Nov 4, 2023

compiler-errors requested changes Nov 6, 2023

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2023

When not finding assoc fn on type, look for builder fn

f926031

When we have a resolution error when looking at a fully qualified path on a type, look for all associated functions on inherent impls that return `Self` and mention them to the user. Fix rust-lang#69512.

estebank force-pushed the issue-69512 branch from 593276c to f926031 Compare November 7, 2023 00:54

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 7, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 7, 2023

bors merged commit 4e0fb98 into rust-lang:master Nov 7, 2023

rustbot added this to the 1.75.0 milestone Nov 7, 2023

github-actions bot mentioned this pull request Nov 7, 2023

Automated pull from upstream master ferrocene/ferrocene#89

Merged

compiler-errors mentioned this pull request Nov 7, 2023

Method suggestion code tweaks #117655

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

When not finding assoc fn on type, look for builder fn #117006

When not finding assoc fn on type, look for builder fn #117006

Uh oh!

estebank commented Oct 21, 2023 •

edited

Loading

Uh oh!

rustbot commented Oct 21, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment was marked as resolved.

This comment was marked as outdated.

This comment has been minimized.

davidtwco commented Nov 4, 2023

Uh oh!

compiler-errors left a comment

Uh oh!

Uh oh!

Uh oh!

compiler-errors Nov 6, 2023

Uh oh!

estebank Nov 7, 2023

Uh oh!

estebank commented Nov 7, 2023

Uh oh!

bors commented Nov 7, 2023

Uh oh!

bors commented Nov 7, 2023

Uh oh!

bors commented Nov 7, 2023

Uh oh!

rust-timer commented Nov 7, 2023

Uh oh!

Uh oh!

When not finding assoc fn on type, look for builder fn #117006

When not finding assoc fn on type, look for builder fn #117006

Uh oh!

Conversation

estebank commented Oct 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 21, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment was marked as resolved.

This comment was marked as outdated.

This comment has been minimized.

davidtwco commented Nov 4, 2023

Uh oh!

compiler-errors left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

compiler-errors Nov 6, 2023

Choose a reason for hiding this comment

Uh oh!

estebank Nov 7, 2023

Choose a reason for hiding this comment

Uh oh!

estebank commented Nov 7, 2023

Uh oh!

bors commented Nov 7, 2023

Uh oh!

bors commented Nov 7, 2023

Uh oh!

bors commented Nov 7, 2023

Uh oh!

rust-timer commented Nov 7, 2023

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

estebank commented Oct 21, 2023 •

edited

Loading