cleanup leftovers of const_err lint #115771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
commented
Sep 12, 2023
| @@ -1,14 +1,14 @@ | |||
| error[E0080]: values of the type `[u8; 2305843009213693951]` are too big for the current architecture | |||
| error[E0080]: could not evaluate static initializer | |||
There was a problem hiding this comment.
Now that this is always a hard error I don't see a good reason to emit a different diagnostic just for the "too big" case.
|
@bors r+ rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 13, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#115736 (Remove `verbose_generic_activity_with_arg`) - rust-lang#115771 (cleanup leftovers of const_err lint) - rust-lang#115798 (add helper method for finding the one non-1-ZST field) - rust-lang#115812 (Merge settings.css into rustdoc.css) - rust-lang#115815 (fix: return early when has tainted in mir pass) - rust-lang#115816 (Disabled socketpair for Vita) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 13, 2023
Rollup merge of rust-lang#115771 - RalfJung:no-more-const-err-lint, r=oli-obk cleanup leftovers of const_err lint Some code / comments seem to not have been updated when const_err was turned into a hard error, so we can do a bit of cleanup here. r? `@oli-obk`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some code / comments seem to not have been updated when const_err was turned into a hard error, so we can do a bit of cleanup here.
r? @oli-obk