unix time module now return result #114038

Stargateur · 2023-07-24T23:26:58Z

First try to fix #108277 without break anything.

if anyone who read this know tips to be able to check compilation for different target I could use some help. So far I installed many target with rustup but ./x check --all-targets doesn't seem to use them.

TODO:

better error
test, how ?

@rustbot label -S-waiting-on-author +S-waiting-on-review

rustbot · 2023-07-24T23:27:05Z

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

thomcc · 2023-07-29T06:46:27Z

if anyone who read this know tips to be able to check compilation for different target I could use some help. So far I installed many target with rustup but ./x check --all-targets doesn't seem to use them.

I don't think --all-targets is right, I think you need to check each --target individually? Note that it does need to be check, and you may need to ensure the llvm submodule is not checked out (this may have been fixed).

bors · 2023-09-21T21:25:29Z

☔ The latest upstream changes (presumably #115230) made this pull request unmergeable. Please resolve the merge conflicts.

Stargateur · 2023-09-22T01:51:27Z

I got no idea how to remove git submodule change from a commit, I don't even know why it's added git submodule change when I didn't commit any submodule change... I hate git submodules so hard.

After one hour finally remove somehow the git submodules change.

bors · 2023-10-24T06:39:44Z

☔ The latest upstream changes (presumably #116238) made this pull request unmergeable. Please resolve the merge conflicts.

thomcc · 2024-02-01T22:54:22Z

I'm going to be away for a few months, so I'm rerolling my PRs so that folks don't have to wait for me. Sorry/thanks.

r? libs

ChrisDenton · 2024-02-21T15:28:00Z

Hi @Stargateur, could you rebase this PR please?

library/std/src/sys/unix/time.rs

ChrisDenton · 2024-03-14T03:06:57Z

looks good to me, thanks!

@bors r+

bors · 2024-03-14T03:06:59Z

📌 Commit 408c0ea has been approved by ChrisDenton

It is now in the queue for this repository.

unix time module now return result First try to fix rust-lang#108277 without break anything. if anyone who read this know tips to be able to check compilation for different target I could use some help. So far I installed many target with rustup but `./x check --all-targets` doesn't seem to use them. TODO: - [x] better error - [ ] test, how ? `@rustbot` label -S-waiting-on-author +S-waiting-on-review

…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#104353 (Add CStr::bytes iterator) - rust-lang#114038 (unix time module now return result) - rust-lang#119676 (rustdoc-search: search types by higher-order functions) - rust-lang#120699 (Document `TRACK_DIAGNOSTIC` calls.) - rust-lang#121899 (Document how removing a type's field can be bad and what to do instead) - rust-lang#121940 (Mention Register Size in `#[warn(asm_sub_register)]`) - rust-lang#122397 (Various cleanups around the const eval query providers) - rust-lang#122405 (Add methods to create StableMIR constant) - rust-lang#122416 (Various style improvements to `rustc_lint::levels`) - rust-lang#122440 (const-eval: organize and extend tests for required-consts) - rust-lang#122461 (fix unsoundness in Step::forward_unchecked for signed integers) r? `@ghost` `@rustbot` modify labels: rollup

unix time module now return result First try to fix rust-lang#108277 without break anything. if anyone who read this know tips to be able to check compilation for different target I could use some help. So far I installed many target with rustup but `./x check --all-targets` doesn't seem to use them. TODO: - [x] better error - [ ] test, how ? ``@rustbot`` label -S-waiting-on-author +S-waiting-on-review

bors · 2024-03-14T10:05:35Z

⌛ Testing commit 408c0ea with merge e69f14b...

bors · 2024-03-14T12:16:02Z

☀️ Test successful - checks-actions
Approved by: ChrisDenton
Pushing e69f14b to master...

rust-timer · 2024-03-14T13:31:07Z

Finished benchmarking commit (e69f14b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.9%	[2.9%, 2.9%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.5%	[-6.0%, -2.1%]	3
Improvements ✅ (secondary)	-2.0%	[-2.0%, -2.0%]	1
All ❌✅ (primary)	-1.9%	[-6.0%, 2.9%]	4

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.6%	[2.5%, 4.4%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.949s -> 669.429s (-0.08%)
Artifact size: 310.79 MiB -> 310.79 MiB (-0.00%)

rustbot assigned thomcc Jul 24, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 24, 2023

This comment has been minimized.

Sign in to view

Stargateur force-pushed the 108277 branch from 5daf630 to ac88da6 Compare July 25, 2023 01:12

This comment has been minimized.

Sign in to view

Stargateur force-pushed the 108277 branch from ac88da6 to 8fb1e7c Compare July 25, 2023 02:20

This comment has been minimized.

Sign in to view

Stargateur force-pushed the 108277 branch from 8fb1e7c to efc3d3c Compare July 25, 2023 03:10

Stargateur marked this pull request as ready for review July 25, 2023 03:43

Stargateur force-pushed the 108277 branch from efc3d3c to e694eff Compare July 25, 2023 04:00

Dylan-DPC added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2023

fogti mentioned this pull request Sep 17, 2023

unix/birthtime: use broad support of libstd alexcrichton/filetime#100

Merged

Stargateur force-pushed the 108277 branch from e694eff to be78042 Compare September 22, 2023 01:41

rustbot added the O-unix Operating system: Unix-like label Sep 22, 2023

Stargateur force-pushed the 108277 branch 2 times, most recently from 49b8bfe to 1eb1559 Compare September 22, 2023 02:33

rustbot assigned m-ou-se and unassigned thomcc Feb 1, 2024

Dylan-DPC added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 12, 2024

m-ou-se added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2024

ChrisDenton assigned ChrisDenton and unassigned m-ou-se Feb 21, 2024

ChrisDenton reviewed Feb 21, 2024

View reviewed changes

library/std/src/sys/unix/time.rs Outdated Show resolved Hide resolved

ChrisDenton added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Feb 25, 2024

m-ou-se reviewed Feb 28, 2024

View reviewed changes

library/std/src/sys/unix/time.rs Outdated Show resolved Hide resolved

riking reviewed Feb 29, 2024

View reviewed changes

library/std/src/sys/unix/time.rs Outdated Show resolved Hide resolved

Stargateur force-pushed the 108277 branch from 270b999 to 932f4a9 Compare March 6, 2024 08:13

This comment has been minimized.

Sign in to view

unix time module now return result

408c0ea

Stargateur force-pushed the 108277 branch from 932f4a9 to 408c0ea Compare March 6, 2024 09:08

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 6, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2024

matthiaskrgr mentioned this pull request Mar 14, 2024

Rollup of 11 pull requests #122466

Closed

matthiaskrgr mentioned this pull request Mar 14, 2024

Rollup of 10 pull requests #122474

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 14, 2024

bors merged commit e69f14b into rust-lang:master Mar 14, 2024

rustbot added this to the 1.78.0 milestone Mar 14, 2024

rafi mentioned this pull request May 1, 2024

feat: re-enable the file created attribute sxyazi/yazi#987

Merged

unix time module now return result #114038

unix time module now return result #114038

Uh oh!

Conversation

Stargateur commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 24, 2023

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

thomcc commented Jul 29, 2023

Uh oh!

bors commented Sep 21, 2023

Uh oh!

Stargateur commented Sep 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Oct 24, 2023

Uh oh!

thomcc commented Feb 1, 2024

Uh oh!

ChrisDenton commented Feb 21, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

ChrisDenton commented Mar 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Mar 14, 2024

Uh oh!

bors commented Mar 14, 2024

Uh oh!

bors commented Mar 14, 2024

Uh oh!

rust-timer commented Mar 14, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

Stargateur commented Jul 24, 2023 •

edited

Loading

Stargateur commented Sep 22, 2023 •

edited

Loading

ChrisDenton commented Mar 14, 2024 •

edited

Loading