Support casting boxes to dyn* #102641
Merged
Support casting boxes to dyn* #102641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eholk
commented
Oct 4, 2022
| @@ -285,6 +286,10 @@ impl<'a, 'tcx, Bx: BuilderMethods<'a, 'tcx>> FunctionCx<'a, 'tcx, Bx> { | |||
| bug!("Only valid to do a DynStar cast into a DynStar type") | |||
| }; | |||
| let vtable = get_vtable(bx.cx(), source.ty(self.mir, bx.tcx()), trait_ref); | |||
| let data = match operand.layout.pointee_info_at(bx.cx(), Size::ZERO) { | |||
There was a problem hiding this comment.
It seems like there ought to be a better way to check if an operand is a pointer.
Also, this will likely be unnecessary once we have the conversion traits.
There was a problem hiding this comment.
Yeah pointee_info is definitely the wrong thing to check here. That type is for optimization hints only.
You have the full type layout here, you can just check layout.abi().
This comment has been minimized.
This comment has been minimized.
|
@rustbot author |
|
Huh, I'm having a hard time reproducing that failure on my machine. The tests are passing for me. |
|
Ah, I was able to run the tests in docker on my machine and now I'm getting the same failure. On to debugging! |
|
@rustbot ready |
|
@bors r+ |
|
Sure, I added a fixme comment. Feel free to r- if you think it needs more detail. |
|
LGTM |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 12, 2022
Support casting boxes to dyn* Boxes have a pointer type at codegen time which LLVM does not allow to be transparently converted to an integer. Work around this by inserting a `ptrtoint` instruction if the argument is a pointer. r? `@compiler-errors` Fixes rust-lang#102427
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 13, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#102641 (Support casting boxes to dyn*) - rust-lang#102836 (rustc_target: Fix json target specs using LLD linker flavors in link args) - rust-lang#102949 (should-skip-this: add missing backslash) - rust-lang#102967 (Add test for issue 102964) - rust-lang#102971 (tidy: error if a lang feature is already present) - rust-lang#102974 (Fix small word dupe typos) - rust-lang#102980 (rustdoc: merge separate `.item-info` CSS) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boxes have a pointer type at codegen time which LLVM does not allow to be transparently converted to an integer. Work around this by inserting a
ptrtointinstruction if the argument is a pointer.r? @compiler-errors
Fixes #102427