Deny non-lifetime bound vars in for<..> || closure binders
#108186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
cjgillot
reviewed
Feb 17, 2023
| @@ -52,6 +52,8 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> { | |||
| ) -> Ty<'tcx> { | |||
| trace!("decl = {:#?}", closure.fn_decl); | |||
|
|
|||
| deny_non_region_late_bound(self.tcx, closure.bound_generic_params, "closure"); | |||
There was a problem hiding this comment.
All this checks should probably be in rustc_hir_analysis::collect::lifetimes.
There was a problem hiding this comment.
I attempted to implement something like that. If binder doesn't allow late-bound ty or consts, then it'll resolve to ResolvedArg::Error instead, so we never actually see these late-bound type or const variables showing up where they shouldn't be.
Not sure if this is what you were looking for.
f4dd264 to
cec7835
Compare
|
@bors r+ |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 18, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#108031 (Don't recover lifetimes/labels containing emojis as character literals) - rust-lang#108046 (Don't allow evaluating queries that were fed in a previous compiler run) - rust-lang#108162 (Don't eagerly convert principal to string) - rust-lang#108186 (Deny non-lifetime bound vars in `for<..> ||` closure binders) - rust-lang#108197 (Update cargo) - rust-lang#108205 (link to llvm changes that prompted the special cases) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the check for illegal bound var types from astconv to resolve_bound_vars. If a binder is defined to have a type or const late-bound var that's not allowed, we'll resolve any usages to ty error or const error values, so we shouldn't ever see late-bound types or consts in places they aren't expected.
Fixes #108184
Fixes #108181
Fixes #108192