Gracefully exit if --keep-stage flag is used on a clean source tree #107397
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @albertlarsan68 (or someone else) soon. Please see the contribution instructions for more information. |
|
I am not sure whether to land this, cc #107019 @jyn514 @GentBinaku. |
This comment has been minimized.
This comment has been minimized.
afe8cb5 to
678156f
Compare
|
The no-merge policy got me a little confused, but hopefully these changes should fix the remaining issues :) |
|
Can you squash your commits please? |
0ceebd7 to
65186e0
Compare
|
Thanks for your PR! |
|
oops, think I accidentally deleted the wrong branch |
|
@bors r=albertlarsan68 |
|
💡 This pull request was already approved, no need to approve it again.
|
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#106618 (Disable `linux_ext` in wasm32 and fortanix rustdoc builds.) - rust-lang#107097 (Fix def-use dominance check) - rust-lang#107154 (library/std/sys_common: Define MIN_ALIGN for m68k-unknown-linux-gnu) - rust-lang#107397 (Gracefully exit if --keep-stage flag is used on a clean source tree) - rust-lang#107401 (remove the usize field from CandidateSource::AliasBound) - rust-lang#107413 (make more pleasant to read) - rust-lang#107422 (Also erase substs for new infcx in pin move error) - rust-lang#107425 (Check for missing space between fat arrow and range pattern) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
| eprintln!( | ||
| "Warning: Unable to find the stamp file, did you try to keep a nonexistent build stage?" | ||
| ); | ||
| crate::detail_exit(1); |
There was a problem hiding this comment.
I have two comments here:
- This should say "error", not "warning"
- This should print the file path of the stamp file; currently it's a regression compared to the existing error message.
@Teapot4195 do you think you could make a follow-up PR with both those changes?
There was a problem hiding this comment.
Yeah, I'll make a follow up PR for those changes
…ark-Simulacrum When stamp doesn't exist, should say Error, and print path to stamp file Follow up pr for rust-lang#107397
Instead of quitting with an obscure No such file or directory error, give the user a clearer and easier to understand error (as well as suggesting a possible cause for the error).
This is the first time I have written rust since 2020, and the first PR I will ever make to rust, so please do point out any mistakes I have made 😄 .
This fixes #107392