Check arg expressions properly on error in confirm_builtin_call
#106055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rustbot has picked a reviewer for you, use r? to override) |
confirm_builtin_callconfirm_builtin_call
estebank
reviewed
Dec 22, 2022
Comment on lines
493
to
495
| let Some(callee_ty) = self.typeck_results.borrow().expr_ty_adjusted_opt(callee_expr) else { | ||
| return None; | ||
| }; |
There was a problem hiding this comment.
Isn't this
Suggested change
| let Some(callee_ty) = self.typeck_results.borrow().expr_ty_adjusted_opt(callee_expr) else { | |
| return None; | |
| }; | |
| let callee_ty = self.typeck_results.borrow().expr_ty_adjusted_opt(callee_expr)?; |
c8abbf6 to
69abe44
Compare
|
@bors r=estebank |
Noratrieb
added a commit
to Noratrieb/rust
that referenced
this pull request
Dec 23, 2022
…estebank Check arg expressions properly on error in `confirm_builtin_call` Makes sure we don't regress diagnostic output when we have an expr error nested inside of a bad fn call: rust-lang#105973 (comment) Fixes rust-lang#106030 Fixes rust-lang#105244
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 23, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#105661 (implement the skeleton of the updated trait solver) - rust-lang#105853 (Make the pre-push script work on directories with spaces) - rust-lang#106043 (Move tests) - rust-lang#106048 (Run `tidy` in its own job in PR CI) - rust-lang#106055 (Check arg expressions properly on error in `confirm_builtin_call`) - rust-lang#106067 (A few metadata nits) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes sure we don't regress diagnostic output when we have an expr error nested inside of a bad fn call: #105973 (comment)
Fixes #106030
Fixes #105244