Skip to content

Conversation

hkBst
Copy link
Member

@hkBst hkBst commented May 27, 2025

No description provided.

@hkBst hkBst mentioned this pull request May 27, 2025
@hkBst
Copy link
Member Author

hkBst commented May 27, 2025

This is failing because of using nightly test feature (for bench functionality). Should we allow this or should we use something else, maybe criterion? Or is there another way?

@GuillaumeGomez
Copy link
Member

To avoid this problem, create a new benches folder in which you put the benches. There you can put the #![feature(test)]. Done this way, the crate itself won't require nightly to build so all good. :)

@GuillaumeGomez
Copy link
Member

This is great, thanks a lot! Now summoning someone who can actually merge. XD

cc @Urgau

@Urgau
Copy link
Member

Urgau commented May 27, 2025

Looks fine to me, but didn't do a deep dive into all the benches, I trust @GuillaumeGomez did it.

One tough: it would be good to check those benches in CI.

@Urgau Urgau merged commit 16ab1b7 into rust-lang:main May 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants